- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.3]: aaa: Kerberos negotiation for RESTAPI should be enabled by d...
by piotr.kliczewski＠gmail.com 19 Aug '16

19 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility ...................................................................... aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility The restapi negotiate should be enabled by default, ENGINE_RESTAPI_NEGO=true. This maintains compatibilty with v3 restapi clients. Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10 Bug-Url: https://bugzilla.redhat.com/1367513 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Request state does not match session state after succes...
by mperina＠redhat.com 18 Aug '16

18 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Request state does not match session state after successful login ...................................................................... aaa: Request state does not match session state after successful login Fix the usability issues with mismatched session state when the login screen session has expired. The client id and client secret with the redirect uri check should be sufficient security check, session "state" which is a random string and was passed between sso and engine as an additional level of security can be dropped with out any security threats. Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601 Bug-Url: https://bugzilla.redhat.com/1367921 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLoginServlet.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/OAuthCallbackServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java 11 files changed, 8 insertions(+), 59 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9874c007e2d3382bbcdc8a280302306e2e6dc601 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: fedora: result dir must not exist for lorax
by sbonazzo＠redhat.com 18 Aug '16

18 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora: result dir must not exist for lorax ...................................................................... fedora: result dir must not exist for lorax livemedia-creator need a non existent result dir Change-Id: I3be078334134bc649b8ebd73f7a8ce13fc0de234 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M fedora-24/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3be078334134bc649b8ebd73f7a8ce13fc0de234 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Setup: Change the host nickname from host_ID to host_name. r...
by sbonazzo＠redhat.com 18 Aug '16

18 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Setup: Change the host nickname from host_ID to host_name. remove hosted_engine_ prefix from nickname. ...................................................................... Setup: Change the host nickname from host_ID to host_name. remove hosted_engine_ prefix from nickname. this is a fix for previous change id Ia77cb1e46c214cd27efff6b6463dadcbdde04105 which was reverted Change-Id: I629f9ea514c55bc6c4e2f9d56bd8d44de93d4b2f Bug-Url: https://bugzilla.redhat.com/1313916 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M src/plugins/gr-he-setup/engine/add_host.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I629f9ea514c55bc6c4e2f9d56bd8d44de93d4b2f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: fedora: set resultdir for livemedia-creator
by sbonazzo＠redhat.com 18 Aug '16

18 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora: set resultdir for livemedia-creator ...................................................................... fedora: set resultdir for livemedia-creator If not specified, resultdir is a temporary directory in /var/tmp with random name. Using local directory instead. Change-Id: I025d6789e80528bd39da0b761a334c709baa206a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M fedora-24/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I025d6789e80528bd39da0b761a334c709baa206a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Improve the documentation of action methods
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Improve the documentation of action methods ...................................................................... Improve the documentation of action methods Currently the action methods, like "start", "stop", etc, don't their parameters documented. This patch fixes that issue. Change-Id: I18de9b55b7a5d0ce021951c4155d83dec964f651 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit f225c225bd2863e090f38f20c15cdf012eef0cf0) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18de9b55b7a5d0ce021951c4155d83dec964f651 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update CHANGES.adoc for release 4.0.0.alpha20
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.0.0.alpha20 ...................................................................... Update CHANGES.adoc for release 4.0.0.alpha20 This patch updates the CHANGES.adoc file, documenting the relevant changes in release 4.0.0.alpha20. Change-Id: I42b82d80be64fedfe0cb30e02d42180768cee7f0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42b82d80be64fedfe0cb30e02d42180768cee7f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add support for secondary parameters
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for secondary parameters ...................................................................... Add support for secondary parameters The "add" and "update" methods support one primary parameter that corresponds to the HTTP request body, and multiple secondary parameters that correspond to URL query parameters. For example, the method to add a virtual machine looks has the primary "vm" parameter, and also the "clone" secondary parameters. Currently secondary parameters aren't supported by the SDK, they are just ignored. This patch adds support for those parameters. Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46 Bug-Url: https://bugzilla.redhat.com/1366548 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 1bd1cfbca47fb753909628eeac6afb867fed78c7) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/add_independent_vm.rb M sdk/spec/spec_helper.rb M sdk/spec/vms_service_spec.rb 4 files changed, 230 insertions(+), 62 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Improve support for Yard tags
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Improve support for Yard tags ...................................................................... Improve support for Yard tags This patch adds a new "addYardTag" method to the Ruby buffer class to simplify the generation of Yard tags that contain multiple lines. Change-Id: I9b94c93114840b7371401d2d9b9a9f97412c5c24 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e3fd523b765cc6cd595f9aec17c94f296c7ce0fa) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java 6 files changed, 142 insertions(+), 70 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b94c93114840b7371401d2d9b9a9f97412c5c24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update to model 4.0.32
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.0.32 ...................................................................... Update to model 4.0.32 The more relevant changes since the previoius update of the model are the following: * Add `logicalName` attribute to the disk attachment type. * Fix the name of the parameter to get virtual machine from affinity label, should be `vm` instead of `host`. * Add the `clone_permissions` parameter to the operations that add virtual machines and templates. * Add the `clone` parameter to the operation that adds a new virtual machine. * Add the `ad_partner_mac` attribute to the bonding type. * Add the `ad_aggregator_id` attribute to the host NIC type. * Add the `ExternalVmImportsService` and related types. Change-Id: I15ba12d2cd35af8d7fe8f4942e8435644540a7c6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15ba12d2cd35af8d7fe8f4942e8435644540a7c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0