- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: make VmBase comparable
by ahadas＠redhat.com 18 Aug '16

18 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: make VmBase comparable ...................................................................... core: make VmBase comparable The comparison is done according to the ID of the VM. Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - image info detection
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: image upload - image info detection ...................................................................... webadmin: image upload - image info detection On 'Image Upload' dialog, upon selection a file: Image information is detected by its header and according to qcow2 spec [1]. The following properties are detected (and displayed in dialog): * Volume format (raw/cow). * Actual size. (For COW:) * Virtual size. * Backing file. * Qcow2 Compat (0.10/1.1). Validation: * Format is set according to the detected info. * Uploading an image with a backing file is unsupported. * Only compat 0.10 is currently supported. * Minimal disk size should be max(actual, virtual). [1] See http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/qcow2.txt Screenshot: http://imgur.com/a/Z1zWC Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5 Bug-Url: https://bugzilla.redhat.com/1357548 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImageInfoForm.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImageInfoModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 15 files changed, 343 insertions(+), 60 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Clean up leftover Linq networking methods
by amureini＠redhat.com 18 Aug '16

18 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Clean up leftover Linq networking methods ...................................................................... webadmin: Clean up leftover Linq networking methods Commit b4ccb43af7203d6c761e6b777cc14aae94b4645b removed a sizable chunk of code around SetupNetworks. This patch finishes the job and removes the [now] unused methods left in the Linq class. Change-Id: Idd31a2d1e30602a21c835327ec0629445ce9c224 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 0 insertions(+), 64 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd31a2d1e30602a21c835327ec0629445ce9c224 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Refactoring of VM from pool allocation process
by ahadas＠redhat.com 18 Aug '16

18 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Refactoring of VM from pool allocation process ...................................................................... core: Refactoring of VM from pool allocation process All functionality of looking for an available VM in a pool and taking locks on it is moved to a separate class VmPoolHandler. Both VmPoolMonitor and AttachUserToVmFromPoolAndRunCommand are using it. Every VM that needs to be run is locked at the moment it is found. This approach helps to prevent race conditions and makes any internal lock objects redundant. Change-Id: I6bbc6d650e0a706f7ff9970ac2dd425e20b6bfc8 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java 7 files changed, 484 insertions(+), 402 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bbc6d650e0a706f7ff9970ac2dd425e20b6bfc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - logging
by laravot＠redhat.com 18 Aug '16

18 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - logging ...................................................................... core: StorageJobCallback - logging This patch changes and aligns the logging in StorageJobCallback to the "Command {} id: '{}': MESSAGE" pattern. Change-Id: Ifc38c6dcb0088234c99d9a99c1d2226d200e70f6 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc38c6dcb0088234c99d9a99c1d2226d200e70f6 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding support for entity polling
by laravot＠redhat.com 18 Aug '16

18 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: adding support for entity polling ...................................................................... core: adding support for entity polling This patch adds the EntityPollingCommand which represents a command that supports entity polling in case of NonResponsive host or a case in which the host job cache was cleared before the polling was completed. Additionally this patch adds the entity polling support to StorageJobCallback. Change-Id: Ib991ff56a4334fd452e45119693ee982619d4545 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java 2 files changed, 65 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib991ff56a4334fd452e45119693ee982619d4545 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Name plular element tag same as the member
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Name plular element tag same as the member ...................................................................... Name plular element tag same as the member Previously when we send action and contruct XML with list of the entity we named tags by the entity. This patch changes the behavior, so we name it by the member which is written. For example if we want to create bonds, we will send following xml: <action> <modified_bonds> <host_nic> <bonding> <options>...</options> <slaves> <host_nic> <name>eth0</name> </host_nic> <host_nic> <name>eth1</name> </host_nic> </slaves> </bonding> <name>bond0</name> </host_nic> </modified_bonds> </action> Previously we sent <host_nics> instead of <modified_bonds>. Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit e6fe52809b0bbfc7390af364d645c4140d0095b6) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/tests/server.py A sdk/tests/test_setupnetworks.py 3 files changed, 111 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1405d540f95abc8dc9dcfa0ac3b2a477b4cba06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.32
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.32 ...................................................................... restapi: Update to model 4.0.32 The more relevant changes included in the new version of the model are the following: * Add the `clone_permissions` parameter to the operations that add virtual machines and templates. * Add the `clone` parameter to the operation that adds a new virtual machine. * Add the `ad_partner_mac` attribute to the bonding type. * Add the `ad_aggregator_id` attribute to the host NIC type. * Add the `ExternalVmImportsService` and related types. * Add the `active` property back to the disk type. Note that all those changes were actually introduced in version 4.0.31 of the model, but there was a small bug affecting the SDKs but not the engine. Fixing that bug required making a new 4.0.32 release, and it is better to keep the engine in sync with the latest model. Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5 Related-To: https://bugzilla.redhat.com/1281666 Related-To: https://bugzilla.redhat.com/1346847 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M pom.xml 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Send query parameters with Add/Update actions
by omachace＠redhat.com 18 Aug '16

18 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Send query parameters with Add/Update actions ...................................................................... Send query parameters with Add/Update actions There are use cases where user can sent query parameters, along with creating/updating entity action. For example when creating virtual machine he can also copy permissions from template to new virtual machine. This patch add the support so the SDK sends the query parameters, supported by backend. Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366547 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 458c678c8f1904b7b4e492ff5a6a44221633beae) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java A sdk/examples/add_independet_vm.py M sdk/tests/server.py M sdk/tests/test_vm_service.py 4 files changed, 124 insertions(+), 11 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac351dfd6f0e4acc18fd481b90be4adcfae69dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: README: update and make less confusing
by sbonazzo＠redhat.com 18 Aug '16

18 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: README: update and make less confusing ...................................................................... README: update and make less confusing The readme is slightly wrong wrt vdsm-hook-faqemu, we fix that by using correct variables. Additionally, we make the section explaining hook installation slightly clearer by referring to the engine as engine instead of manager, and improving the wording. Change-Id: Ib06c9e47f5cd02be06442a22367d6b2b0fea9c03 Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M README 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/62528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib06c9e47f5cd02be06442a22367d6b2b0fea9c03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0