- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: aaa: Kerberos negotiation for RESTAPI should be enabled by d...
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility ...................................................................... aaa: Kerberos negotiation for RESTAPI should be enabled by default to maintain SDK v3 compatibility The restapi negotiate should be enabled by default, ENGINE_RESTAPI_NEGO=true. This maintains compatibilty with v3 restapi clients. Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10 Bug-Url: https://bugzilla.redhat.com/1367513 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da5a99a9dc58c4ca896e8bcf9bee7c1bb80ad10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: upload model: Save disk's Guid, not its String.
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: upload model: Save disk's Guid, not its String. ...................................................................... webadmin: upload model: Save disk's Guid, not its String. Instead of making redundant transmissions from GUID to String and back, just have the disk's Guid as a Guid type, not a String. Change-Id: I7a12b476820323a0756770759b1a8a1df62c55cb Bug-Url: https://bugzilla.redhat.com/1343878 Bug-Url: https://bugzilla.redhat.com/1328877 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a12b476820323a0756770759b1a8a1df62c55cb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Don't call finazlize on image upload progress.
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Don't call finazlize on image upload progress. ...................................................................... webadmin: Don't call finazlize on image upload progress. Currently, when a progress callback triggered while uploading an image, and the upload status is not "TRANSFERRING", there is a call to finalize upload. This is wrong, because in any scenario in which the status becomes anything other than "TRANSFERRING", finalizing the upload already happens. that means that currently a call for finalizing will happen twice. Remove the call for finalizeUpload in onProgress(). Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Bug-Url: https://bugzilla.redhat.com/1343878 Bug-Url: https://bugzilla.redhat.com/1328877 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core+webadmin: Audit log a network error while uploading disk.
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core+webadmin: Audit log a network error while uploading disk. ...................................................................... core+webadmin: Audit log a network error while uploading disk. Currently when uploading a disk via webadmin, nothing warns the user in case of a failure. e.g when the connectivity with ovirt-imageio-proxy can't be established. This scenario can happen if the proxy is down/not installed, or if the user did not add the engine's CA as a certified authority in its browser. This patch adds AuditLog message to UploadImageStatusCommandParameters, so if some error happens in the client side, it will append an AuditLogMessge to the command, and this message will be logged and shown to the user. Also, handling the scenario of a network error in JS side is added in this patch to demonstrate the new usage of the command and solve the network error handling issue. Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c Bug-Url: https://bugzilla.redhat.com/1343878 Bug-Url: https://bugzilla.redhat.com/1328877 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 5 files changed, 43 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add a replaceWith method for custom seperator
by masayag＠redhat.com 18 Aug '16

18 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add a replaceWith method for custom seperator ...................................................................... engine: Add a replaceWith method for custom seperator To be used when there is a need for a custom seperator but still keep the default printed items. Bug-Url: https://bugzilla.redhat.com/1294354 Change-Id: I8d9082ed5d48871cbb3e0f3b857f53986bc3c993 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/62390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d9082ed5d48871cbb3e0f3b857f53986bc3c993 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.9
by juan.hernandez＠redhat.com 18 Aug '16

18 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.9 ...................................................................... restapi: Update to model 4.1.9 The more relevant changes included in the new version of the model are the following: * Add the `clone_permissions` parameter to the operations that add virtual machines and templates. * Add the `clone` parameter to the operation that adds a new virtual machine. * Add the `ad_partner_mac` attribute to the bonding type. * Add the `ad_aggregator_id` attribute to the host NIC type. * Add the `upgradecheck` action to the host service. * Add the `ExternalVmImportsService` and related types. * Add the `active` property back to the disk type. Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M pom.xml 3 files changed, 14 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4ec501f1065ebb8a949c6cc3eb9f0a1315aee5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Only internal commands can manipulate read-only labels
by rgolan＠redhat.com 18 Aug '16

18 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: Only internal commands can manipulate read-only labels ...................................................................... core: Only internal commands can manipulate read-only labels Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86 Bug-Url: https://bugzilla.redhat.com/1346250 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddLabelCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveLabelCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateLabelCommand.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I934010ad6d6d8c8713feb09b1d3ad7d23646ef86 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Cluster update updates VMs only if necessary
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Cluster update updates VMs only if necessary ...................................................................... core: Cluster update updates VMs only if necessary i.e. if cluster compatibility version has changed. This patch is supposed to decrease of probability of DB deadlocks caused by concurrent updates of VM devices by limiting calls of UpdateVmCommand. This is a lightweight backport of https://gerrit.ovirt.org/#/c/60995 intended to be 3.6 only. Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Bug-Url: https://bugzilla.redhat.com/1349526 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: packaging: setup: Enroll missing pki on upgrade
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Enroll missing pki on upgrade ...................................................................... packaging: setup: Enroll missing pki on upgrade Without this patch, imageio-proxy pki will not be generated on upgrade from 3.6, because it did not exist then. Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8 Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 8ba1dfc0f249b6c53b0920fbd65aa5f4af8764ea) (cherry picked from commit a093bc82998fde17bb0ef8547c19861378275af3) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67669b0b81e87690ff31d90247d803f175423fe8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: packaging: spec: Require ovirt-imageio-proxy-setup
by tnisan＠redhat.com 18 Aug '16

18 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: spec: Require ovirt-imageio-proxy-setup ...................................................................... packaging: spec: Require ovirt-imageio-proxy-setup Make the engine plugin of engine-setup require ovirt-imageio-proxy-setup. Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac Bug-Url: https://bugzilla.redhat.com/1365744 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit dcb12b888d6f35258883e540c68a09974d1c03c5) (cherry picked from commit 87360124530710ee9d117425a90847c0f54c79d0) --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I402b6896bf1da810ad2a0650219f46e9b2f6e4ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0