- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Make new VM disk mark as bootable by default
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make new VM disk mark as bootable by default ...................................................................... webadmin: Make new VM disk mark as bootable by default Change-Id: If8e36584d8cfd3c8f3b8c469926f612317641e37 Bug-Url: https://bugzilla.redhat.com/1365087 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e36584d8cfd3c8f3b8c469926f612317641e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core+webadmin: Audit log a network error while uploading disk.
by derez＠redhat.com 17 Aug '16

17 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core+webadmin: Audit log a network error while uploading disk. ...................................................................... core+webadmin: Audit log a network error while uploading disk. Currently when uploading a disk via webadmin, nothing warns the user in case of a failure. e.g when the connectivity with ovirt-imageio-proxy can't be established. This scenario can happen if the proxy is down/not installed, or if the user did not add the engine's CA as a certified authority in its browser. This patch adds AuditLog message to UploadImageStatusCommandParameters, so if some error happens in the client side, it will append an AuditLogMessge to the command, and this message will be logged and shown to the user. Also, handling the scenario of a network error in JS side is added in this patch to demonstrate the new usage of the command and solve the network error handling issue. Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c Bug-Url: https://bugzilla.redhat.com/1343878 Bug-Url: https://bugzilla.redhat.com/1328877 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 5 files changed, 43 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: master: drop ioprocess ppc64le
by eedri＠redhat.com 17 Aug '16

17 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: publisher: master: drop ioprocess ppc64le ...................................................................... publisher: master: drop ioprocess ppc64le both x86_64 and ppc64le ioprocess build jobs creates python-ioprocess package requiring ioprocess = %version-%release but the jobs differs in %release. This cause either x86_64 or ppc64le to fail due to missing ioprocess package due to the newer release. Dropping ppc64le solving this issue temporarily until we find a way to build both ppc64le and x86_64 from the same src.rpm or we implement an alternative solution Change-Id: Ib507e3ba41b1e152c31879e412a8d69b7d127ecd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Eyal Edri: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib507e3ba41b1e152c31879e412a8d69b7d127ecd Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Prevent changing default quota
by rgolan＠redhat.com 17 Aug '16

17 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: Prevent changing default quota ...................................................................... core: Prevent changing default quota Commands fail validation if changing default quota. Change-Id: I989b82a76436afd862d4def560807776efd24913 Bug-Url: https://bugzilla.redhat.com/1297210 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateQuotaCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QuotaCRUDParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 18 files changed, 158 insertions(+), 83 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/59635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I989b82a76436afd862d4def560807776efd24913 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix possible deadlock
by rgolan＠redhat.com 17 Aug '16

17 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: fix possible deadlock ...................................................................... core: fix possible deadlock VmsMonitoring.analyzeVms() method takes a lock for each VM, which will not be unlocked when an exception is thrown inside VmAnalyzer.analyze(). On exception, analyzeVms() will not return anything and the calling method, perform(), will call unlockVms() with an empty list. Change-Id: I5926f935e64f51a17a3ff0ca8a19309ae7792b0c Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/61614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5926f935e64f51a17a3ff0ca8a19309ae7792b0c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow ...................................................................... webadmin: fix NPE in "DC guide me" -> "Create Cluster" flow This patch disables creating a new MAC pool from the mentioned flow. Change-Id: I4010a765e6362915da2ee3a7a4a3d12c393310e3 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 2 files changed, 21 insertions(+), 9 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4010a765e6362915da2ee3a7a4a3d12c393310e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removed static calls to DbFacade in UploadImage commands
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: removed static calls to DbFacade in UploadImage commands ...................................................................... core: removed static calls to DbFacade in UploadImage commands Introduced ImageTransferUpdater bean: * Contains the logic of UploadImageCommand -> updateEntity. * Injected in UploadImageCommand and UploadImageStatusCommand. * Used in order to avoid static calls to DbFacade. Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java 3 files changed, 112 insertions(+), 81 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject ImageTransferDao in UploadImageStatusCommand
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: inject ImageTransferDao in UploadImageStatusCommand ...................................................................... core: inject ImageTransferDao in UploadImageStatusCommand Injecting ImageTransferDao member in UploadImageStatusCommand class. Change-Id: Ie731ac5a4e813b6273b1dd89f732ac71aa3efab1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie731ac5a4e813b6273b1dd89f732ac71aa3efab1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inject ImageTransferDao in UploadImageCommand
by derez＠redhat.com 16 Aug '16

16 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: core: inject ImageTransferDao in UploadImageCommand ...................................................................... core: inject ImageTransferDao in UploadImageCommand Injecting ImageTransferDao member in UploadImageCommand class. Change-Id: I8ce9f646f72c0b99b53dc9879888c811de15d317 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ce9f646f72c0b99b53dc9879888c811de15d317 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant param in ChildCommandsCallbackBase....
by masayag＠redhat.com 16 Aug '16

16 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant param in ChildCommandsCallbackBase.endAction ...................................................................... engine: remove redundant param in ChildCommandsCallbackBase.endAction Change-Id: Ib084e6e757e0fadf1488b895f8cd8a9ee1a49fdb Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib084e6e757e0fadf1488b895f8cd8a9ee1a49fdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0