- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Correct 'Pass-Through Host CPU' Tooltip
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correct 'Pass-Through Host CPU' Tooltip ...................................................................... webadmin: Correct 'Pass-Through Host CPU' Tooltip This patch corrects the wording of the tooltip for the 'Pass-Through Host CPU' option to indicate that the option is not available unless 'Do not allow migration' is selected. It also contains a small refactor that makes the variable naming and conditional predicates ordering consistent across branches. Change-Id: Ice8fc5556f139a39eeb352d423dfd3431cbefbcb Bug-Url: https://bugzilla.redhat.com/1360775 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice8fc5556f139a39eeb352d423dfd3431cbefbcb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix scrolling on import iscsi domain dialog
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix scrolling on import iscsi domain dialog ...................................................................... webadmin: fix scrolling on import iscsi domain dialog Import storage domain dialog: fix scrolling on import iSCSI tables. Change-Id: I18deede2d3bb25452af1483171c939b024cf83dd Bug-Url: https://bugzilla.redhat.com/1367416 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.ui.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18deede2d3bb25452af1483171c939b024cf83dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: v2v- kvm username and password are not mandatory
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: v2v- kvm username and password are not mandatory ...................................................................... webadmin: v2v- kvm username and password are not mandatory The user, password fields are no longer mandatory. This is supported by adding a checkbox named "authenticaton requires" as exists in the external providers dialog. The user name validation rules are also changed by ommiting the check for special chars and domain. Furthermore, add a tooltip with a short explanation on the KVM URI field. Change-Id: I807559e74d18dd37f746b5f4eface1850f4cd6f0 Bug-Url: https://bugzilla.redhat.com/1351542 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 4 files changed, 59 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I807559e74d18dd37f746b5f4eface1850f4cd6f0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix hosted engine SD initial status warning
by rgolan＠redhat.com 17 Aug '16

17 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix hosted engine SD initial status warning ...................................................................... core: Fix hosted engine SD initial status warning Changed the warning message displayed in a situation where the hosted engine has been imported, but has no storage domain, to be clearer for users. Change-Id: Ia7ab035cee62600398a59d824adc87900d54174e Bug-Url: https://bugzilla.redhat.com/1358313 Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/62241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7ab035cee62600398a59d824adc87900d54174e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix V3 for force remove data center
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix V3 for force remove data center ...................................................................... restapi: Fix V3 for force remove data center In version 3 of the API it was possible to remove a data center specifying the "force" parameter in the request body: DELETE /datacenters/123 Content-Type: application/xml <action> <force>true</true> </action> But in version 4 this was replaced with a parameter, because DELETE requests wity bodies are forbidden: DELETE /datacenters/123?force=true But we need to preserve the old behaviour for backwards compatibility. That is what this patch does. Change-Id: Ibf04e0f19f109c287319f4e4f6bcc6e9d5218f86 Bug-Url: https://bugzilla.redhat.com/1366794 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 587a01290016bfbdc5be17fe101fb37713453fb5) --- M backend/manager/modules/restapi/README.adoc M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterServer.java 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf04e0f19f109c287319f4e4f6bcc6e9d5218f86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix scrolling on import iscsi domain dialog
by derez＠redhat.com 17 Aug '16

17 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix scrolling on import iscsi domain dialog ...................................................................... webadmin: fix scrolling on import iscsi domain dialog Import storage domain dialog: fix scrolling on import iSCSI tables. Change-Id: I18deede2d3bb25452af1483171c939b024cf83dd Bug-Url: https://bugzilla.redhat.com/1367416 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.ui.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/62404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18deede2d3bb25452af1483171c939b024cf83dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix V3 for force remove data center
by juan.hernandez＠redhat.com 17 Aug '16

17 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix V3 for force remove data center ...................................................................... restapi: Fix V3 for force remove data center In version 3 of the API it was possible to remove a data center specifying the "force" parameter in the request body: DELETE /datacenters/123 Content-Type: application/xml <action> <force>true</true> </action> But in version 4 this was replaced with a parameter, because DELETE requests wity bodies are forbidden: DELETE /datacenters/123?force=true But we need to preserve the old behaviour for backwards compatibility. That is what this patch does. Change-Id: Ibf04e0f19f109c287319f4e4f6bcc6e9d5218f86 Bug-Url: https://bugzilla.redhat.com/1366794 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.adoc M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterServer.java 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf04e0f19f109c287319f4e4f6bcc6e9d5218f86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Wrong error message passed from SSO on password grant t...
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Wrong error message passed from SSO on password grant type failure ...................................................................... aaa: Wrong error message passed from SSO on password grant type failure Authentication failure in obtaining token from SSO using password grant type should return correct error message. Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Bug-Url: https://bugzilla.redhat.com/1366927 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Set default switchType if none is received from vdsm
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Set default switchType if none is received from vdsm ...................................................................... engine: Set default switchType if none is received from vdsm 3.6 vdsms do not report a switch type. This must be set to legacy, otherwise the network will be reported as out of sync. Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Bug-Url: https://bugzilla.redhat.com/1367483 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine : Compensation context data is cleared although the d...
by tnisan＠redhat.com 17 Aug '16

17 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: engine : Compensation context data is cleared although the data wasn't reverted on parent-child command scenario ...................................................................... engine : Compensation context data is cleared although the data wasn't reverted on parent-child command scenario Compensation should be performed and the data should be cleared only if there is compensation data for the command. Change-Id: Id49c6206cfcc5216e907d8445e8c091af3c68a94 Bug-Url: https://bugzilla.redhat.com/1364804 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java 4 files changed, 24 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id49c6206cfcc5216e907d8445e8c091af3c68a94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0