- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: remove redundant condition in ChildCommandsCallbackBase
by masayag＠redhat.com 16 Aug '16

16 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant condition in ChildCommandsCallbackBase ...................................................................... engine: remove redundant condition in ChildCommandsCallbackBase Change-Id: I35084024cf1b41c7c0501af4ca6bd3ebfa052074 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35084024cf1b41c7c0501af4ca6bd3ebfa052074 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't generate streaming support code
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't generate streaming support code ...................................................................... restapi: Don't generate streaming support code When version 4 of the API was planned it was decided to introduce support for streaming results. This required the introduction of streaming XML and JSON parsing and rendering code, automatically generated from the model. But this code isn't currently used, and generating increases the compilation time and incorrectly reduces the percentage of coverage reported by some tools. To avoid those inconveniences this patch removes the generation of this code from the bulid process. This will be reintroduced later, when the streaming support is completed. Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18 Bug-Url: https://bugzilla.redhat.com/1367398 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit fc6d358b24514e01cea90d20a1d8051c7b6822c5) --- M backend/manager/modules/restapi/interface/definition/pom.xml 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Verified; Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff09f64dc755493facaa4c9b7e457860c4982f18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update capabilities for V3
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update capabilities for V3 ...................................................................... restapi: Update capabilities for V3 The "capabilities" provided by version 4 of the engine for version 3 of the API aren't generated directly, instead they are stored in a "capabilities.xml" file that is extracted from version 3 of the engine. This file needs to be updated when there are relevant changes in version 3 of the engine. This patch updates it, using version 3.6.7.5 of the engine. Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Bug-Url: https://bugzilla.redhat.com/1367400 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 69939e4e8b071653c6ba3232cb133b4edf0351fe) --- M backend/manager/modules/restapi/jaxrs/src/main/resources/v3/capabilities.xml 1 file changed, 38 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: re-enlarge the create snapshot message dialog
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: re-enlarge the create snapshot message dialog ...................................................................... webadmin: re-enlarge the create snapshot message dialog In case there are no disks allowing a snapshot for the VM, the message panel size should be enlarged to contain the following two messages: "Could not detect Guest Agent on the VM. Note that without a Guest Agent the data on the created snapshot may be inconsistent. There are no disks allowing a snapshot, only the configuration will be a part of the VM snapshot.". And therefore the whole dialog should be enlarged also. Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6 Bug-Url: https://bugzilla.redhat.com/1360914 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotCreatePopupView.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28fad0bbaea9dc16163a9f0ecd71f35668762a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: enlarge the create snapshot message dialog
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: enlarge the create snapshot message dialog ...................................................................... webadmin: enlarge the create snapshot message dialog Enlarge the size of the message Panel inside the snapshot creation dialog in order to avoid message truncation. Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Bug-Url: https://bugzilla.redhat.com/1360914 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/uicompat/exclude-filters.xml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Set default switchType if none is received from vdsm
by mperina＠redhat.com 16 Aug '16

16 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: engine: Set default switchType if none is received from vdsm ...................................................................... engine: Set default switchType if none is received from vdsm 3.6 vdsms do not report a switch type. This must be set to legacy, otherwise the network will be reported as out of sync. Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Bug-Url: https://bugzilla.redhat.com/1367483 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09c1c826919c8e5084148dd9599612f20f11938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Wrong error message passed from SSO on password grant t...
by mperina＠redhat.com 16 Aug '16

16 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: Wrong error message passed from SSO on password grant type failure ...................................................................... aaa: Wrong error message passed from SSO on password grant type failure Authentication failure in obtaining token from SSO using password grant type should return correct error message. Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Bug-Url: https://bugzilla.redhat.com/1366927 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Aleksei Slaikovskii: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd2a4971bd9ff67eb0929c8e42d504ff76fb61d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: gluster: fix tool tip issue in VolumeStatusCell
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix tool tip issue in VolumeStatusCell ...................................................................... gluster: fix tool tip issue in VolumeStatusCell BrowserEvents are not propagated to base class AbstractCell from VolumeStatusCell. As a result tooltip was not getting displayed. Fixing by calling super class onBrowserEvent always Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Bug-Url: https://bugzilla.redhat.com/1365604 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> (cherry picked from commit c0913aa5de82b34b54939e4350d9ad9cb1f0112a) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeStatusCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Alexander Wels: Looks good to me, approved Ramesh N: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994f9c158a8a381cf44615ff0c9e9311cebd53f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update capabilities for V3
by juan.hernandez＠redhat.com 16 Aug '16

16 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update capabilities for V3 ...................................................................... restapi: Update capabilities for V3 The "capabilities" provided by version 4 of the engine for version 3 of the API aren't generated directly, instead they are stored in a "capabilities.xml" file that is extracted from version 3 of the engine. This file needs to be updated when there are relevant changes in version 3 of the engine. This patch updates it, using version 3.6.7.5 of the engine. Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/resources/v3/capabilities.xml 1 file changed, 38 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3085a972be693c5638005f0acaeab58233bb077 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: gluster: fix enumtranslater issue in SizeConverter
by tnisan＠redhat.com 16 Aug '16

16 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: gluster: fix enumtranslater issue in SizeConverter ...................................................................... gluster: fix enumtranslater issue in SizeConverter LocalizedEnums are not defined correctly for SizeConverter.SizeUnit. As a result enum translation was not working correctly. Correcting the definitions in LocalizedEnums. Note: since EnumTranslator gives the enum name when the localization key is missing, it is not visible in the UI. Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da Bug-Url: https://bugzilla.redhat.com/1358837 Bug-Url: https://bugzilla.redhat.com/1269132 Bug-Url: https://bugzilla.redhat.com/1353289 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 18 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/62349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85846470dbf10752fc89c9c5a79f353441f4f2da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0