- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: Make VdsArchitectureHelper a CDI singleton
by mbetak＠redhat.com 15 Aug '16

15 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Make VdsArchitectureHelper a CDI singleton ...................................................................... backend: Make VdsArchitectureHelper a CDI singleton Change-Id: I4cdca46c04943204d7ebda1069f6a5f7ea095d10 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java 2 files changed, 20 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Betak: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cdca46c04943204d7ebda1069f6a5f7ea095d10 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Default method for ClusterEditChecker#getDetailedMe...
by mbetak＠redhat.com 15 Aug '16

15 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: backend: Default method for ClusterEditChecker#getDetailedMessage ...................................................................... backend: Default method for ClusterEditChecker#getDetailedMessage Used Java 8 remove a bit of boilerplate. Also added missing @Singleton annotation to SuspendedVMClusterEditChecker. Change-Id: I6d06817556c5ddab7f33fc53c9e23aae148681bf Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceClusterEditChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterEditChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java 3 files changed, 6 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified; Passed CI tests Arik Hadas: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d06817556c5ddab7f33fc53c9e23aae148681bf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Use CDI in FenceAgentExecutor
by mperina＠redhat.com 15 Aug '16

15 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: backend: Use CDI in FenceAgentExecutor ...................................................................... backend: Use CDI in FenceAgentExecutor Change-Id: I57840f665c3b8618d3aa1514e841b13777e87909 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java 2 files changed, 24 insertions(+), 18 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/62260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57840f665c3b8618d3aa1514e841b13777e87909 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix checking for libvirt upgrade
by tnisan＠redhat.com 15 Aug '16

15 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix checking for libvirt upgrade ...................................................................... core: Fix checking for libvirt upgrade VDSM does not depend directly on libvirt, but it depends on following subpackages: libvirt-client libvirt-daemon-config-nwfilter libvirt-daemon-kvm libvirt-lock-sanlock libvirt-python This patch replace libvirt with above subpackages in package list which we use for host upgrades. Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e Bug-Url: https://bugzilla.redhat.com/1344020 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Version decreaseing message split
by ahadas＠redhat.com 15 Aug '16

15 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Version decreaseing message split ...................................................................... core: Version decreaseing message split Message "Cannot decrease data center compatibility version." was wrongly used also for clusters. New special message created for cluster flow. Change-Id: Iccef388b54a0caccc29f468ff8504f4920d60612 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 20 insertions(+), 13 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccef388b54a0caccc29f468ff8504f4920d60612 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Adding tooltip with bond properties to bond icon
by tjelinek＠redhat.com 15 Aug '16

15 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Adding tooltip with bond properties to bond icon ...................................................................... webadmin: Adding tooltip with bond properties to bond icon To show the state of the bond properties without raising any alerts, a tooltip is added to the bond icon. For bond in DOWN/NONE statuses, only the status will be displayed. For UP status: bond status, ad_partner_mac, ad_aggragator_id, and slave ad_aggregator_id's will be displayed. Change-Id: I7e3a339ce61cb5cc7e71793de893e1ab257d527e Bug-Url: https://bugzilla.redhat.com/1281666 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages.properties 6 files changed, 65 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Marcin Mirecki: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e3a339ce61cb5cc7e71793de893e1ab257d527e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix checking for libvirt upgrade
by mperina＠redhat.com 15 Aug '16

15 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Fix checking for libvirt upgrade ...................................................................... core: Fix checking for libvirt upgrade VDSM does not depend directly on libvirt, but it depends on following subpackages: libvirt-client libvirt-daemon-config-nwfilter libvirt-daemon-kvm libvirt-lock-sanlock libvirt-python This patch replace libvirt with above subpackages in package list which we use for host upgrades. Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e Bug-Url: https://bugzilla.redhat.com/1344020 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia605636957cdbe7381b0ddf42525f6db77b8870e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: log num of running vms only upon change
by piotr.kliczewski＠gmail.com 14 Aug '16

14 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: log num of running vms only upon change ...................................................................... core: log num of running vms only upon change The log of the number of running VMs on a host flooded the engine log. Therefore, adding some logic in order to log it only when the number of running VMs on a host is changed. Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Bug-Url: https://bugzilla.redhat.com/1366138 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: unlock vms properly in vm-devices monitoring
by piotr.kliczewski＠gmail.com 14 Aug '16

14 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: unlock vms properly in vm-devices monitoring ...................................................................... core: unlock vms properly in vm-devices monitoring Obviously, We should unlock the VMs that VM-devices monitoring locks inside a finally block. Change-Id: Id8f7f7eafc6b91550cd85e810db4a4a74a3d663c Bug-Url: https://bugzilla.redhat.com/1361860 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8f7f7eafc6b91550cd85e810db4a4a74a3d663c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Revert "packaging: setup: Enroll missing pki on upgrade"
by piotr.kliczewski＠gmail.com 14 Aug '16

14 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Revert "packaging: setup: Enroll missing pki on upgrade" ...................................................................... Revert "packaging: setup: Enroll missing pki on upgrade" This reverts commit f897210ba4336572717aa1924e44f65a5bc77a2f. Change-Id: I851c41c8a0eb73d664a56be57f2b34e859ca1abd Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I851c41c8a0eb73d664a56be57f2b34e859ca1abd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0