- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddVmCommand comment style
by amureini＠redhat.com 14 Aug '16

14 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommand comment style ...................................................................... core: AddVmCommand comment style Having a javadoc style comment in a non-javadoc place may potentially break some doclets. This patch converts this comment's style to a plain old inline comment (//) to avoid such potential problems. Change-Id: I14a34b1e96365c768c7fb018664a214b66706af8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14a34b1e96365c768c7fb018664a214b66706af8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmCommand: Remove DbFacade references
by amureini＠redhat.com 14 Aug '16

14 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommand: Remove DbFacade references ...................................................................... core: AddVmCommand: Remove DbFacade references Stop calling the deprecated DbFacade.getInstance() method and use the available getXYZDao() methods. Change-Id: I4c4c6e8964d62b1a41c3a4adbcf91869d22a0b86 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 3 files changed, 17 insertions(+), 23 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c4c6e8964d62b1a41c3a4adbcf91869d22a0b86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmCommand type inference
by amureini＠redhat.com 14 Aug '16

14 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommand type inference ...................................................................... core: AddVmCommand type inference Change-Id: Iba0b62cecdb3130ad8a8d5a9251a3bc60a50be33 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba0b62cecdb3130ad8a8d5a9251a3bc60a50be33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove 3.6.8 from CI
by eedri＠redhat.com 14 Aug '16

14 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: remove 3.6.8 from CI ...................................................................... remove 3.6.8 from CI Change-Id: I5d75b98ff3b49e8a7d567ccc61e0d29e2cca6300 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d75b98ff3b49e8a7d567ccc61e0d29e2cca6300 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: reducing ovirt-engine build-artifacts time to 2 hours
by eedri＠redhat.com 14 Aug '16

14 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: reducing ovirt-engine build-artifacts time to 2 hours ...................................................................... reducing ovirt-engine build-artifacts time to 2 hours Now that we have experimental flow running on latest artifacts we need a faster flow publishing RPMs to experimental and 6 hours is too much time to wait. In additon, recent improvements done in CI allows us to run more jobs and not worry on load or long build queue. We might considering changing this to run per commit at some point if we see we have the resources for it. Change-Id: I54dc71ffda131d6d8c847e0849a4d146071aef38 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54dc71ffda131d6d8c847e0849a4d146071aef38 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "packaging: setup: Enroll missing pki on upgrade"
by eedri＠redhat.com 14 Aug '16

14 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Revert "packaging: setup: Enroll missing pki on upgrade" ...................................................................... Revert "packaging: setup: Enroll missing pki on upgrade" This reverts commit f87e5c1ba7c58d342ba520422b0ec36fb01a866e. Change-Id: If74a568b7fbf4b3b28d710a5db980e8111aac175 Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74a568b7fbf4b3b28d710a5db980e8111aac175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor maintenance parameters
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor maintenance parameters ...................................................................... core: refactor maintenance parameters 1. Rename class field _isInternal to internal 2. Put the constructors at the top Change-Id: I124c014d7ee47fa39fc131ab690c42e5f94e30ec Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceVdsParameters.java 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124c014d7ee47fa39fc131ab690c42e5f94e30ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use only vm dynamic data in destroy command
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm dynamic data in destroy command ...................................................................... core: use only vm dynamic data in destroy command There is no real need to fetch the whole VM object, only the dynamic part is required. Change-Id: Ic36e27be2dac0d5b5f69502c5ad28e645eafb66d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36e27be2dac0d5b5f69502c5ad28e645eafb66d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify GetAllVmStats with stream api
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: simplify GetAllVmStats with stream api ...................................................................... core: simplify GetAllVmStats with stream api Change-Id: I721d94a6952a2d9d52fcd1a48f56e30f0000646a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I721d94a6952a2d9d52fcd1a48f56e30f0000646a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in maintenance command
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in maintenance command ...................................................................... core: cleanup in maintenance command 1. Inline _isInternal class field 2. Replace nested for-loops with stream API 3. Remove use of depracated DbFacade#getInstance Change-Id: Ie3111212c01f7d39e1c8a7b170162754e50d80ba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3111212c01f7d39e1c8a7b170162754e50d80ba Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0