- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Refactor CurrentUser code
by piotr.kliczewski＠gmail.com 13 Aug '16

13 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Refactor CurrentUser code ...................................................................... webadmin: Refactor CurrentUser code CurrentUser#onUserLogin is typically called after UI plugins get initialized. Keeping separate DbUser reference in CurrentUser is not only redundant but also dangerous -- before CurrentUser#onUserLogin executes, UI plugins will get 'null' from api.loginUserName() and api.loginUserId() functions. This patch also removes some unused methods from CurrentUser. Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Bug-Url: https://bugzilla.redhat.com/1361656 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java 2 files changed, 10 insertions(+), 24 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/62161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: database: memory_and_disk_images_storage_domain_view
by piotr.kliczewski＠gmail.com 13 Aug '16

13 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: database: memory_and_disk_images_storage_domain_view ...................................................................... database: memory_and_disk_images_storage_domain_view Inline EXISTS conditions in a select list, should, in theory perform a query once per row of the select list, while moving the same logic to a LEFT JOIN should allow the database to perform the query just once and hash-join it, resulting in a performance improvement. This patch also adds the missing indexes on the snapshots table to make these joins efficient. According to the work done on verifying bug #1302752, on a loaded system with 500 hosts, 7K VMs and 3 disks per VM, this patch improves the query's runtime by a factor of 33 - from 6600 msecs to 200 msecs. Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Bug-Url: https://bugzilla.redhat.com/1363823 Bug-Url: https://bugzilla.redhat.com/1302752 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0860_memory_and_disk_images_storage_domain_view_join_indexes.sql 2 files changed, 13 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/62286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: database: memory_and_disk_images_storage_domain_view
by amureini＠redhat.com 12 Aug '16

12 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: database: memory_and_disk_images_storage_domain_view ...................................................................... database: memory_and_disk_images_storage_domain_view Inline EXISTS conditions in a select list, should, in theory perform a query once per row of the select list, while moving the same logic to a LEFT JOIN should allow the database to perform the query just once and hash-join it, resulting in a performance improvement. This patch also adds the missing indexes on the snapshots table to make these joins efficient. According to the work done on verifying bug #1302752, on a loaded system with 500 hosts, 7K VMs and 3 disks per VM, this patch improves the query's runtime by a factor of 33 - from 6600 msecs to 200 msecs. Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Related-To: https://bugzilla.redhat.com/1363823 Related-To: https://bugzilla.redhat.com/1302752 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0220_memory_and_disk_images_storage_domain_view_join_indexes.sql 2 files changed, 13 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Enroll missing pki on upgrade
by piotr.kliczewski＠gmail.com 12 Aug '16

12 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: Enroll missing pki on upgrade ...................................................................... packaging: setup: Enroll missing pki on upgrade Without this patch, imageio-proxy pki will not be generated on upgrade from 3.6, because it did not exist then. Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine : Async tasks should handle exception in creating task
by piotr.kliczewski＠gmail.com 12 Aug '16

12 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Async tasks should handle exception in creating task ...................................................................... engine : Async tasks should handle exception in creating task When async tasks have multiple child commands and one of them fails to be submitted to vdsm, the AsyncTaskManager should be able to keep track of the root command and invoke endWithFailure. Change-Id: Ic51a7d94b7c593a178222fee2e0cf01eaa7cfc45 Bug-Url: https://bugzilla.redhat.com/1360373 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51a7d94b7c593a178222fee2e0cf01eaa7cfc45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live 4.0.2
by sbonazzo＠redhat.com 12 Aug '16

12 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live 4.0.2 ...................................................................... build: ovirt-live 4.0.2 Change-Id: I86c4ddb0904a018128f745fb34bab490b218a572 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c4ddb0904a018128f745fb34bab490b218a572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: enlarge the create snapshot message dialog
by tjelinek＠redhat.com 12 Aug '16

12 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: enlarge the create snapshot message dialog ...................................................................... webadmin: enlarge the create snapshot message dialog Enlarge the size of the message Panel inside the snapshot creation dialog in order to avoid message truncation. Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Bug-Url: https://bugzilla.redhat.com/1360914 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/62218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e4716171b39c99774ae36d2eb51cb8d8583cb43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: el7: move glusterfs to 3.8
by sbonazzo＠redhat.com 11 Aug '16

11 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: el7: move glusterfs to 3.8 ...................................................................... el7: move glusterfs to 3.8 Moving glusterfs to 3.8 since it's the default for Fedora 24 and CentOS Storage SIG. Change-Id: I3746f619d6c2dba20e9a0b8fd5f7fa233b2386d9 Bug-Url: https://bugzilla.redhat.com/1366118 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.repos M configure.ac M ovirt-el7-deps.repo.in M ovirt-release-master.spec.in 4 files changed, 9 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3746f619d6c2dba20e9a0b8fd5f7fa233b2386d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: repos: move to GlusterFS 3.8
by sbonazzo＠redhat.com 11 Aug '16

11 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: repos: move to GlusterFS 3.8 ...................................................................... repos: move to GlusterFS 3.8 Moving glusterfs to 3.8 since it's the default for Fedora 24 and CentOS Storage SIG. Change-Id: I6d8b6bf5ea94ca81be33465ba214c8ece0f3c366 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d8b6bf5ea94ca81be33465ba214c8ece0f3c366 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ioprocess: explicitly set job name for build_artifacts
by sbonazzo＠redhat.com 11 Aug '16

11 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ioprocess: explicitly set job name for build_artifacts ...................................................................... ioprocess: explicitly set job name for build_artifacts explicitly set job name for build_artifacts dropped in the ppc64le patch, should re-enable deploy to experimental job. Change-Id: I4f0f545a8691357d419c2c32300d66d432646c56 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f0f545a8691357d419c2c32300d66d432646c56 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0