April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: allow to perform hotplug/unplug/attach when vm is paus...
by mlipchuk＠redhat.com 08 Apr '13

08 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: allow to perform hotplug/unplug/attach when vm is paused. ...................................................................... core: allow to perform hotplug/unplug/attach when vm is paused. When a VM is paused there's no reason not to allow hot plugging/unplugging/attaching a disk. Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6 Bug-Url: https://bugzilla.redhat.com/918498 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/12986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Console connect button availability fix
by tjelinek＠redhat.com 08 Apr '13

08 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Console connect button availability fix ...................................................................... webadmin: Console connect button availability fix This patch fixes the behavior of console button availability broken by I00158bbd. For the availability check, the ConsoleUtils is used. It also removes the event for connecting to console (it was needed because uicommonweb is not under gin management). Now the UiCommonDefaultTypeResolver is used for resolving needed classes (adding new interfaces/moving classes was needed to make this possible). The signature of the methods of the console options persister is changed - the console context parameter was removed because it's redundant (can be infered from the model parameter). Change-Id: If102303d6b5c5ac45959b87a540c8ea278c227c3 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/AsyncCallFailureHandler.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleOptionsFrontendPersister.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ErrorPopupManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/HasConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UtilsModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVirtualMachinePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 37 files changed, 394 insertions(+), 299 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If102303d6b5c5ac45959b87a540c8ea278c227c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: sos - fixed behaviour when -a option is used
by knesenko＠redhat.com 08 Apr '13

08 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - fixed behaviour when -a option is used ...................................................................... sos - fixed behaviour when -a option is used calling sosreport -a -o postgresql set all the postgresql plugin options to True which was an unexpected and unhandled value. Fixed also some minor issues like wrong indentation, instance attribute declaration out of __init__, file built-in redefinition. (cherry picked from commit 4b1c6eb7b4ba44c30ea9e6fb5841e2eaf619dcc4) Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/postgresql.py 1 file changed, 40 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix VM pop-up Host tab
by gchaplik＠redhat.com 08 Apr '13

08 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix VM pop-up Host tab ...................................................................... webadmin: Fix VM pop-up Host tab In the VM pop-up view, host tab - the logic of the UI visibility and availability is wrong. CPU pinning topology textbox should always be visible. Both 'Use Host CPU' and 'CPU Pinning topology' are unavailable for clusters with compatibility version under 3.2. Logic of the flags 'Use Host CPU' and 'CPU Pinning topology' should be as follows: A = 'cpu pinning' available B = 'use host cpu' available For RHEV: Any Selected Host Host ------------------------------------------------------------- Allow auto migration Allow Man. migration B Do not allow migration B A+B For oVirt: Any Selected Host Host ------------------------------------------------------------- Allow auto migration A Allow Man. migration B A Do not allow migration B A+B Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Bug-Url: https://bugzilla.redhat.com/905831 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 38 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added validation for bond name format
by masayag＠redhat.com 08 Apr '13

08 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Added validation for bond name format ...................................................................... core: Added validation for bond name format Added enforcement for bond names of the form "^bond\d*$", the format assumed and used by VDSM. This is to enable adding new bonds from the engine. Change-Id: Id4ea20997c03c35c1f47d9ab12a49a39dd9c778a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ea20997c03c35c1f47d9ab12a49a39dd9c778a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added validation for host NIC name length
by masayag＠redhat.com 08 Apr '13

08 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Added validation for host NIC name length ...................................................................... core: Added validation for host NIC name length Linux apparently limits NIC names to be at most 15 characters long, so I enforced that rule on our corresponding entities. Change-Id: I901734ef19ae63c5879c19022bb2ed229a23b3a3 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I901734ef19ae63c5879c19022bb2ed229a23b3a3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: redo patch 12748: show the correct VM's console ...
by tjelinek＠redhat.com 08 Apr '13

08 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: redo patch 12748: show the correct VM's console type ...................................................................... userportal: redo patch 12748: show the correct VM's console type The console type presented in VMs lists at the user-portal (basic + extended) is based on the default display type defined for the VMs, which is not always right because VM can be run in Run-Once mode with a display type which is different from the default. This patch ensure that the right console type is displayed for each VM in the user portal by changing the way the console type is determined - if the VM is running then we determine the console type according to the actual display type (presented by the display type field in VmDynamic), and according to the default display type, as before, only if the VM is not running. Change-Id: I488ceeba48c02e21b19762260a21d0efe1a2eab9 Bug-Url: https://bugzilla.redhat.com/907776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I488ceeba48c02e21b19762260a21d0efe1a2eab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: connect --help will log the user out of the disconnecte...
by mpastern＠redhat.com 08 Apr '13

08 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: connect --help will log the user out of the disconnected cli ...................................................................... cli: connect --help will log the user out of the disconnected cli Running connect --help in a disconnect cli will print help message and log user off cli. This patch uses a regex to convert command --help to help command and execute it. Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Bug-Url: https://bugzilla.redhat.com/890340 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: major cleanup
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: major cleanup ...................................................................... packaging: engine-service: major cleanup Last patch in series of engine-service, after all core issues merged into existing implementation, this introduce python only rework and cleanups. 1. Removal global variable. 2. Previous patch already use python subprocess instead of direct exec. 3. Use python logging instead of direct syslog calls. 4. Add debug log. 5. Add debug parameter. 6. Add gettext support. 7. Modular functional. 8. Remove one time used variables. 9. Remove replication of configuration variable into local variables. 10. Remove dead code. 11. pyflakes free 12. pep8 complaint. Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in 3 files changed, 887 insertions(+), 601 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: fix systemd packaging per fedora ...
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: fix systemd packaging per fedora requirements ...................................................................... packaging: engine-service: fix systemd packaging per fedora requirements Change-Id: I84d290d2cc389450be183cd85fb91ee1e58e4e9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84d290d2cc389450be183cd85fb91ee1e58e4e9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0