April 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: dialog: human: accept empty note text
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: human: accept empty note text ...................................................................... dialog: human: accept empty note text Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: "dual mode" on vm with agent should be reported as "...
by alkaplan＠redhat.com 07 Apr '13

07 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: "dual mode" on vm with agent should be reported as "virtio" ...................................................................... engine: "dual mode" on vm with agent should be reported as "virtio" vnic with "dual mode" on vm with an agent should be reported to the vdsm as "virtio" only. Currently, there is a leftover code that prepares also an interface with "rtl8139" type. But does nothing with it. So there is not a real bug, just a code fix. Also, the vm.getHasAgent() returned false even if there is an agent on the vm. The cause of the bug is that the guest-agent-version was updated in the RunVmCommand.attachCd method only if there was an active ISO domain in the dc. In this patch the guest agent version update was moved to the runVm method to make sure the version is always updated when trying to run the vm. Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Bug-Url: https://bugzilla.redhat.com/923889 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing EvenlyDistributeVDComparer
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing EvenlyDistributeVDComparer ...................................................................... engine: Removing EvenlyDistributeVDComparer The following class is not in use anymore Change-Id: I76739488192cf13bc5d6356f9feda6f452d6edf4 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EvenlyDistributeVDComparer.java 1 file changed, 0 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76739488192cf13bc5d6356f9feda6f452d6edf4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: It is not possible add non-operational network to ...
by alkaplan＠redhat.com 07 Apr '13

07 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: It is not possible add non-operational network to vNic of vm. ...................................................................... webadmin: It is not possible add non-operational network to vNic of vm. Removed the if that avoided adding the non-operational networks to the network list. Change-Id: I6183a5abcddc343323b82c39111de9f2f1ba5166 Bug-Url: https://bugzilla.redhat.com/948160 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6183a5abcddc343323b82c39111de9f2f1ba5166 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Add permit to role issues(#919202)
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add permit to role issues(#919202) ...................................................................... restapi : Add permit to role issues(#919202) When trying to add permit to role the permit name needs to accept both lower case and upper case names. Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Bug-Url: https://bugzilla.redhat.com/919202 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving update of vds dynamic data - status
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving update of vds dynamic data - status ...................................................................... engine: Improving update of vds dynamic data - status Instead of updating all vds dynamic data we can update only its status Change-Id: I59c0c1c34c7c9ddcb481fda17decc91875eb1638 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 4 insertions(+), 12 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59c0c1c34c7c9ddcb481fda17decc91875eb1638 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Imroving updates of vds dynamic
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Imroving updates of vds dynamic ...................................................................... engine: Imroving updates of vds dynamic The following patch is removing call for UpdateVdsDynamicData command in order to update net_config_dirty field. The change is make a simple update instead of: 1. Run query for VdsDynamic 2. Acquire lock on VdsManager 3. Perform update Change-Id: Ic9e76b6ddd20ebd36a00d68b44da3a3a954ad87d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 5 files changed, 41 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9e76b6ddd20ebd36a00d68b44da3a3a954ad87d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: "help add" fails to format the error when number of pro...
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "help add" fails to format the error when number of provided args in incorrect ...................................................................... cli: "help add" fails to format the error when number of provided args in incorrect 'help add' command for gluster-related entities like glustervolume and brick does not work. The following error is seen - (connected)]# help add glustervolume unknown error: not enough arguments for format string Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Bug-Url: https://bugzilla.redhat.com/922018 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving GetAsyncTasksByStoragePoolId query
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving GetAsyncTasksByStoragePoolId query ...................................................................... engine: Improving GetAsyncTasksByStoragePoolId query The following patch will simplify a query, we don't need to make any join, access to async_tasks table is enough Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing call to host by query
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replacing call to host by query ...................................................................... engine: Replacing call to host by query The following patch should replace a call to host by query during moving host to maintenance. All task should be kept in Db so no need to perform an XML RPC call. Query to DB is much more efficient and faster. Change-Id: I1e864961ab05538bd565d74f31869f64aa40b758 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 3 files changed, 9 insertions(+), 32 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e864961ab05538bd565d74f31869f64aa40b758 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0