April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Removed unused import that broke the build
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Removed unused import that broke the build ...................................................................... restapi: Removed unused import that broke the build Not sure how it got there... Change-Id: I71d6c34cdf29ab63efb4f0553cb58b84e9b3b5ac Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/13680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d6c34cdf29ab63efb4f0553cb58b84e9b3b5ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Added mapping to derived classes of VdsNetworkInter...
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added mapping to derived classes of VdsNetworkInterface ...................................................................... restapi: Added mapping to derived classes of VdsNetworkInterface The mapping now uses Bond, Vlan and Nic. This to enable specific bean validation, etc. Change-Id: Iaabecc4d723923506e98cd3bc397ad406c4ef5c0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/13556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaabecc4d723923506e98cd3bc397ad406c4ef5c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StringHelper usages in types module
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in types module ...................................................................... core: Remove StringHelper usages in types module Removed all the usages of the deprecated StringHelper class and replaced them with standard calls to StringUtils. Change-Id: If571a276077252672577f63b160a95c81f8bdeb4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CdRomMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 5 files changed, 15 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If571a276077252672577f63b160a95c81f8bdeb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StringHelper usages in jaxrs module
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in jaxrs module ...................................................................... core: Remove StringHelper usages in jaxrs module Removed all the usages of the deprecated StringHelper class and replaced them with standard calls to StringUtils. Change-Id: I86d4266462bb936db9be551a1a321cdcb8f5929f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java 4 files changed, 11 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86d4266462bb936db9be551a1a321cdcb8f5929f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Use DbUser.isGroup() properly
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Use DbUser.isGroup() properly ...................................................................... restapi: Use DbUser.isGroup() properly Replaced an explicit string check on DbUser's user name with the BE's method isGroup(). This achieves two goals: 1. It's easier to understand. 2. It removes a dependency on the deprecated StringHelper. Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: doc: fix wrong setting for fake and development
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix wrong setting for fake and development ...................................................................... doc: fix wrong setting for fake and development Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: dialog: support tuple in addition to list
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: support tuple in addition to list ...................................................................... dialog: support tuple in addition to list Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: dialog: human: accept empty note text
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: human: accept empty note text ...................................................................... dialog: human: accept empty note text Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Error when adding/removing permissions with filter...
by yzaslavs＠redhat.com 07 Apr '13

07 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : Error when adding/removing permissions with filtered api(#919686) ...................................................................... restapi : Error when adding/removing permissions with filtered api(#919686) Internal server error when UserVmManager adds a User role permission on a VM, the permission gets added. Insufficent privileges error when removing the permission which was added. Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Bug-Url: https://bugzilla.redhat.com/919686 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in otopi[master]: dialog: support tuple in addition to list
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: support tuple in addition to list ...................................................................... dialog: support tuple in addition to list Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0