April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Live snapshot should order child commands
by mlipchuk＠redhat.com 04 Apr '13

04 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Live snapshot should order child commands ...................................................................... core: Live snapshot should order child commands End method of live snapshot should order the list of the child commands by image id to avoid dead lock with UpdateRunTimeInfo when updating disk image dynamic. Change-Id: I2999a2f9fb042a70eaf34e17668877040d57a068 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/909937 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2999a2f9fb042a70eaf34e17668877040d57a068 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetPermittedStorageDomainsByTemplateId
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetPermittedStorageDomainsByTemplateId ...................................................................... core: Remove GetPermittedStorageDomainsByTemplateId GetPermittedStorageDomainsByTemplateIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetPermittedStorageDoaminsByTemplateIdQuery class 2. The GetPermittedStorageDoaminsByTemplateId constant representing it in VdcQueryType 3. The GetPermittedStorageDomainsByTemplateIdParameters class which was only used by the removed query class. 3. The getPermittedStorageDomainsById method in StorageDomainDAO (which was only used by the query), its implementation, and its test. 4. The Getstorage_domain_by_id_with_permitted_action stored procedure that was only used by the said DAO function. Change-Id: I94f586e0daeebc0f768639b39444b30ff3101378 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/storages_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermittedStorageDomainsByTemplateIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermittedStorageDomainsByTemplateIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 7 files changed, 3 insertions(+), 93 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f586e0daeebc0f768639b39444b30ff3101378 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetStorageSessionsListQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetStorageSessionsListQuery ...................................................................... core: Remove GetStorageSessionsListQuery GetStorageSessionsListQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetStorageSessionsListQuery class 2. The GetStorageSessionsList constant representing it in VdcQueryType 3. The GetStorageSessionsListVDSCommand class which was only used by this query. 4. The GetStorageSessionList constant representing it in VDSCommandType. 5. The getSessionsList() method IVdsServer/VdsServerConnector/VdsServerWrapper, which was only used by GetStorageSessionsListVDSCommand. 6. The SessionsListReturnForXmlRpc class which was only used by GetStorageSessionsListVDSCommand. Change-Id: I5ee43140a7ca0cbe9a2c15cc787c270ead619bda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageSessionsListQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageSessionsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SessionsListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 0 insertions(+), 115 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ee43140a7ca0cbe9a2c15cc787c270ead619bda Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetVGInfoQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetVGInfoQuery ...................................................................... core: Remove unused GetVGInfoQuery Removed the unused GetVGInfoiQuery. This patch removes the following: 1. The unused GetVGInfoQuery class. 2. The VGQueryParameterBase class only used by GetVGInfoQuery. 3. The GetVGInfo constant in VdcQueryType corresponding to the removed class. Change-Id: I1e43d685ffd2c0664094c024f883c853d7edfc75 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVGInfoQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 50 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e43d685ffd2c0664094c024f883c853d7edfc75 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed the unused GetImageByImageIdQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed the unused GetImageByImageIdQuery ...................................................................... core: Removed the unused GetImageByImageIdQuery This patch removes the unused query GetImageByImageIdQuery. This patch contains: 1. Removing aforementioned class, which has no usages in the code. 2. Removed the GetImageByImageId constant from VdcQueryType. 3. Renamed GetImageByImageIdParameters to GetStorageDomainsByImageIdParameters since GetStorageDomainsByImageIdQuery is now the only class that uses it. Change-Id: Ib1ee84d3e8c903fc9a9cfd6144e8c44af06d04c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImageByImageIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByImageIdParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainsByImageIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskStorageListModel.java 7 files changed, 31 insertions(+), 47 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ee84d3e8c903fc9a9cfd6144e8c44af06d04c4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: null checks added for Volume general model propert...
by kmayilsa＠redhat.com 04 Apr '13

04 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: null checks added for Volume general model properties ...................................................................... webadmin: null checks added for Volume general model properties null checks are added for the volume general model properties to avoid NPE. Change-Id: Icaa6463054d6eefd589f5991c43b09b7d9247507 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaa6463054d6eefd589f5991c43b09b7d9247507 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding Volume ID to volume general tab
by kmayilsa＠redhat.com 04 Apr '13

04 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Adding Volume ID to volume general tab ...................................................................... webadmin: Adding Volume ID to volume general tab Volume ID field is added to volume's general subtab, it will display the UUID of the selected volume. Change-Id: If571171963d36669b436d24fced633b34afaaf81 Bug-Url: https://bugzilla.redhat.com/887806 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java 3 files changed, 20 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If571171963d36669b436d24fced633b34afaaf81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: add enable SPICE proxy checkbox
by tjelinek＠redhat.com 04 Apr '13

04 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: add enable SPICE proxy checkbox ...................................................................... userportal,webadmin: add enable SPICE proxy checkbox Added a new checkbox under SPICE options of the console popup window named "Enable SPICE Proxy". The behavior: - if the SPICE proxy is configured on system level (SpiceProxyDefault) + the "Enable SPICE Proxy" checkbox is enabled and checked by default + if the selection is changed, than it is stored in the brower level - if the SPICE proxy is NOT configured on system level (SpiceProxyDefault): + the "Enable SPICE Proxy" is not editable and has a title: "No SPICE proxy defined on system level" + it is not checked + if it was previously checked and this preference stored on browser level, this preference is ignored and the checkbox will be unchecked Change-Id: I879a4976c649f1d568f42c2d72f9e995a618d874 Bug-Url: https://bugzilla.redhat.com/924605 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 11 files changed, 86 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I879a4976c649f1d568f42c2d72f9e995a618d874 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated the use of the taskcleaner utility
by juan.hernandez＠redhat.com 04 Apr '13

04 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated the use of the taskcleaner utility ...................................................................... packaging: Updated the use of the taskcleaner utility Taskcleaner utility was updated with new options. This patch provides update to our code to use these new options instead of previous ones. Change-Id: I6c4185a6cdadb9ef152e3b3130c30d2c19cb07c0 Bug-Url: https://bugzilla.redhat.com/921201 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c4185a6cdadb9ef152e3b3130c30d2c19cb07c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Persist the changes from console popup
by tjelinek＠redhat.com 04 Apr '13

04 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Persist the changes from console popup ...................................................................... userportal,webadmin: Persist the changes from console popup Make the changes made in console popup (both WA and UP) persistent per browser. The core of the implementation is the ConsoleOptionsFrontendPersisterImpl which is a gin managed class containing two methods: - storeToLocalStorage - loadFromLocalStorage This methods needs the model to/from to copy the data to/from local storage and the context, which can be webadmin, userportal's basic view or userportal's extended view (because the values are configured separatly for this three places). The load method copies the selected data from local storage only if they are still possible in the specific context (for example when the user selected some spice options, this has been stored to local storage and than he changed the default console to VNC, the spice options are not going to be copied). When using, you need to make sure that you load the stored data from the local storage before opening the edit console and before connecting to the console, and also that you store all the data to local storage after the user changes them in the edit console. Change-Id: I847e17c6e28db7921f0bc162f0ff70399e671a03 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManager.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtils.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleOptionsFrontendPersister.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolePopupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UtilsModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVirtualMachinePresenter.java 17 files changed, 285 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I847e17c6e28db7921f0bc162f0ff70399e671a03 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0