April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added POSIX VFS validation & hint on storage creat...
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added POSIX VFS validation & hint on storage create ...................................................................... webadmin: Added POSIX VFS validation & hint on storage create Added a validation of special characters to a VFS type when creating a POSIX domain to allow only ascii characters, also added a tooltip hint on the input field to explain and show common types Change-Id: I6a34d269da73f1b42b2b2917469f8ea337ca51ee Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java 3 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a34d269da73f1b42b2b2917469f8ea337ca51ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Provide snapshot name to audit log
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Provide snapshot name to audit log ...................................................................... core: Provide snapshot name to audit log VM snapshot name not provided in the event log when a snapshot is previewed problem fixed. Change-Id: I6988302018ff04966f973f3950c12cad6072ab82 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 20 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6988302018ff04966f973f3950c12cad6072ab82 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetUsersByVmidQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetUsersByVmidQuery ...................................................................... core: Remove unused GetUsersByVmidQuery Remove the GetUsersByVmidQuery, which is not used anywhere in the code base. This patch removes the redundant GetUsersBVmidQuery class, its parameter class GetUsersByVmidParameters and its corresponding constant in VdcQueryType. Change-Id: I1f3dc0aa392c89c03e43c34f98df3fbf68dbd493 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f3dc0aa392c89c03e43c34f98df3fbf68dbd493 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove the unused GetNonOperationalVdsQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove the unused GetNonOperationalVdsQuery ...................................................................... core: Remove the unused GetNonOperationalVdsQuery Remove GetNonOperationalVdsQuery, since it is not used anywhere in the codebase. This patch removes: 1. The GetNonOperationalVdsQuery class. 2. The NetworkNonOperationalQueryParameters only used by the aforementioned class. 3. The corresponding GetNonOperationalVds constant in VdcQueryType. Please enter the commit message for your changes. Lines starting Change-Id: I21bef4c93c3f40ebcbb39182ca18dda55ef0a7b0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNonOperationalVdsQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 68 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21bef4c93c3f40ebcbb39182ca18dda55ef0a7b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVdsByTypeQuery leftovers
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVdsByTypeQuery leftovers ...................................................................... core: Remove GetVdsByTypeQuery leftovers Removed the VdcQueryType.GetVdsByType constant and the GetVdsByTypeParameters class as the GetVdsByType query no longer exists in the codebase. Change-Id: I42ecd45ccf58e544305df394e727926097f63dda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByTypeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42ecd45ccf58e544305df394e727926097f63dda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVdsByHostQuery leftovers
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVdsByHostQuery leftovers ...................................................................... core: Remove GetVdsByHostQuery leftovers Removed the VdcQueryType.GetVdsByHost constant and the GetVdsByHostParameters class as the GetVdsByHost query no longer exists in the codebase. Change-Id: Ib426d8ae35d8536286f02dc67141b0f641f43971 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByHostParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib426d8ae35d8536286f02dc67141b0f641f43971 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adding "MIGRATION" role as a network usage.
by alkaplan＠redhat.com 04 Apr '13

04 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Adding "MIGRATION" role as a network usage. ...................................................................... restapi: Adding "MIGRATION" role as a network usage. Migration role on a NetworkCluster indicates the migration of vm's in the cluster will be done via this network. Change-Id: If001d1388e3054f9f6215e3cb3d2f23cc84de05f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java 5 files changed, 56 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If001d1388e3054f9f6215e3cb3d2f23cc84de05f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: reimplemented engine_firewalld
by juan.hernandez＠redhat.com 04 Apr '13

04 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: reimplemented engine_firewalld ...................................................................... packaging: reimplemented engine_firewalld Reimplemented using the firewall-cmd command instead of the python API, avoiding issues with dbus. The firewall-cmd command will be used also in otopi based rewrite of the engine-setup command. Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Bug-Url: https://bugzilla.redhat.com/924071 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine_firewalld.py 2 files changed, 42 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webdmin: Restrict destination host parameter for admi...
by ofrenkel＠redhat.com 04 Apr '13

04 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine,webdmin: Restrict destination host parameter for administrators ...................................................................... engine,webdmin: Restrict destination host parameter for administrators Users aren't supposed to be able to provide any host level parameters to commands. New action groups added: - EDIT_ADMIN_VM_PROPERTIES - EDIT_ADMIN_TEMPLATE_PROPERTIES The permission check is applied if e.g. destination host is specified and is different from the default VM destination host for Run/RunOnce/UpdateVM/UpdateVmTemplate/AddVM/AddVmTemplate VM actions. The new action groups are assigned to: - SuperUser, DataCenterAdmin, (ClusterAdmin, TemplateAdmin) roles. GUI role tree is updated. Permissions are propagated into REST API layer. Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53 Bug-Url: https://bugzilla.redhat.com/902353 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0030_add_edit_admin_vm_props.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 15 files changed, 177 insertions(+), 29 deletions(-) Approvals: Libor Spevak: Verified Omer Frenkel: Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: prepare for the next development iteration
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare for the next development iteration ...................................................................... sdk: prepare for the next development iteration Change-Id: I0ddd39938451686d00b0391d109fdc2cac897403 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ddd39938451686d00b0391d109fdc2cac897403 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0