April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Refactored BackendGlusterBrickResource
by sanjal＠redhat.com 05 Apr '13

05 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: restapi: Refactored BackendGlusterBrickResource ...................................................................... restapi: Refactored BackendGlusterBrickResource Refactored BackendGlusterBrickResource to use parent's populateAdvancedDetails method to populate brick with advance details in case of All-Content set to true. Change-Id: I70354105b57159e6ba872804701910b4111b734b Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java 3 files changed, 24 insertions(+), 33 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70354105b57159e6ba872804701910b4111b734b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: do not allow execution as non-roo...
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: do not allow execution as non-root ...................................................................... packaging: engine-service: do not allow execution as non-root all downstream has a mean to execute the script under the correct account. So no need for us to change identity nor expect other user. Change-Id: Ic30ce5316918a98bf2ef4cbf17d0eb91b85c74d1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 7 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic30ce5316918a98bf2ef4cbf17d0eb91b85c74d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: remove /usr/bin symlink
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove /usr/bin symlink ...................................................................... packaging: engine-service: remove /usr/bin symlink The engine-service script is not a utility to be used by user but by downstream packager, hence no reason to install at /usr/bin. Change-Id: I49fc25ad586b8f04e1588d04ab772858f2bfd169 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 2 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49fc25ad586b8f04e1588d04ab772858f2bfd169 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: add missing global
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: add missing global ...................................................................... packaging: engine-service: add missing global Change-Id: Id7df1b3c222c5de67e96423ef0fd686e9cf579b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7df1b3c222c5de67e96423ef0fd686e9cf579b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: support setting attributes on generated files
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: support setting attributes on generated files ...................................................................... packaging: support setting attributes on generated files ensure generated scripts are executable. Change-Id: Iacd9614777540f6ed6da741de5157b888beb7629 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/engine-service.sysv.in M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd9614777540f6ed6da741de5157b888beb7629 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: doc: fix wrong setting for fake and development
by Alon Bar-Lev 04 Apr '13

04 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix wrong setting for fake and development ...................................................................... doc: fix wrong setting for fake and development Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove api's StrigUtils
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove api's StrigUtils ...................................................................... core: Remove api's StrigUtils This patch removes the class org.ovirt.engine.api.common.util.StringUtils. It only had one method (isNullOrEmpty(String)), which was only used in two places. This method's body is completely identical to org.apache.commons.lang.StringUtils.isEmpty(String), so it could easily be replaced. Change-Id: Ia6f116f861975db24b710db457b40491908ff1d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/StatusUtils.java D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/StringUtils.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java 3 files changed, 5 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6f116f861975db24b710db457b40491908ff1d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Short comparison findbugs
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Short comparison findbugs ...................................................................... webadmin: Short comparison findbugs Fixed findbugs warnings in StorageGeneralModel.java:129 and StorageGeneralModel.java:142 Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Creating template by specifing vm name, does not w...
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Creating template by specifing vm name, does not work (#915285) ...................................................................... restapi : Creating template by specifing vm name, does not work (#915285) Creating template by specifing vm name, does not work, works only when vm id is specified. This patch lets the user create a template from a VM by specifying the vm name. Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915285 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java 10 files changed, 234 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add an alert when adding a Domain to uninitialized...
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add an alert when adding a Domain to uninitialized pool ...................................................................... webadmin: Add an alert when adding a Domain to uninitialized pool When trying to add a Storage Domain to an uninitialized Storage Pool there should be a warning message that the Pool is uninitialized and that the user should first add a data domain to initialize the pool Change-Id: I30c2b37f2cf59ef9c57ff96d1ffc4c23d452819e Bug-Url: https://bugzilla.redhat.com/887378 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 4 files changed, 53 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30c2b37f2cf59ef9c57ff96d1ffc4c23d452819e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0