December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix NPE on addition of external vm
by ahadas＠redhat.com 22 Dec '14

22 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix NPE on addition of external vm ...................................................................... core: fix NPE on addition of external vm We add externally managed VMs using AddVmFromScratch command. This command is called by the monitoring thread so no user is set as the 'current user' when it is executed. Thus we got NPE when trying to set the its disk permissions. However, this kind of VMs are diskless VMs so we are not supposed to set disk permissions for it. Thus, changing AddVmCommand#addDiskPermissions in a way that the disk owners will not be retrieved for diskless VMs prevents the NPE. Change-Id: I2e0cff201b1c8c89682fc2c3a4ddbc88b4ec803e Bug-Url: https://bugzilla.redhat.com/1176528 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e0cff201b1c8c89682fc2c3a4ddbc88b4ec803e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Making the tests optional
by alitke＠redhat.com 22 Dec '14

22 Dec '14

Adam Litke has submitted this change and it was merged. Change subject: Making the tests optional ...................................................................... Making the tests optional Disabled by default as that's the default behavior we want at the project (run the tests when you want to run the tests, build the package when you want to build the package). Change-Id: I8567b4c93f8b02c448815d4ea853469381a2847f Signed-off-by: David Caro <dcaroest(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/36122 Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Adam Litke: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/36122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8567b4c93f8b02c448815d4ea853469381a2847f Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix ClassCastException in AsyncDataProvier, DataCe...
by tnisan＠redhat.com 22 Dec '14

22 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix ClassCastException in AsyncDataProvier, DataCenterGuideModel ...................................................................... webadmin: Fix ClassCastException in AsyncDataProvier, DataCenterGuideModel Due to a change introduced in patch 31cd7918c9c5eb5c2d6ddf5526b366fdb2d0f4bc queries that once returned an ArrayList are now returning LinkedList which resulted in a ClassCastException making the data center guide dialogs stuck in the process Change-Id: I7007e30fbd579b1055f8bfd1da558b723965a6cd Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7007e30fbd579b1055f8bfd1da558b723965a6cd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc version bump
by oourfali＠redhat.com 22 Dec '14

22 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc version bump ...................................................................... jsonrpc version bump Bug-Url: https://bugzilla.redhat.com/1176407 Bug-Url: https://bugzilla.redhat.com/1175824 Change-Id: I2b71c75e54ff35a8bf0e33a9a50d8c5d6f38dcaf Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b71c75e54ff35a8bf0e33a9a50d8c5d6f38dcaf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: getdisksvmguid hit the perf due to all_disks_including...
by oourfali＠redhat.com 22 Dec '14

22 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: getdisksvmguid hit the perf due to all_disks_including_snapshots view ...................................................................... core: getdisksvmguid hit the perf due to all_disks_including_snapshots view Add index Replace UNION with UNION ALL, which doing group by of the images to avoid duplicates Change-Id: I076e804cab601f3873cf2fdccba77abe42da60d3 Bug-Url: https://bugzilla.redhat.com/1141543 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0660_add_index_image_storage_domain_map.sql 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liran Zelkha: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I076e804cab601f3873cf2fdccba77abe42da60d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: remove user/group sync
by oourfali＠redhat.com 22 Dec '14

22 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: remove user/group sync ...................................................................... aaa: remove user/group sync Since all queries are performed using the engine sessions table, the users groups are always derived from the principal on user login there is no need to periodically sync users. The groupids is updated on user login Change-Id: I15248a628647430d7f3d22e68e66456caffbcb40 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1176306 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/AddUserCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DbUserCacheManager.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserGroupListModel.java M packaging/dbscripts/ad_groups_sp.sql 15 files changed, 103 insertions(+), 293 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15248a628647430d7f3d22e68e66456caffbcb40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix vm images list initialization
by ahadas＠redhat.com 22 Dec '14

22 Dec '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix vm images list initialization ...................................................................... core: fix vm images list initialization Move the initialization of the images list of VM to be in VmBase instead of in VM so when we instantiate VM with an instance of VmStatic which includes images list, those images will be used and will not be overridden. Change-Id: If7d713935c2449340ae01bd705c2edf907fbd1cd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/36319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7d713935c2449340ae01bd705c2edf907fbd1cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Import domain fails with SQL constraint violation exce...
by tnisan＠redhat.com 21 Dec '14

21 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Import domain fails with SQL constraint violation exception ...................................................................... core: Import domain fails with SQL constraint violation exception Change-Id: Ibf734bf1c9b32b16f2249bc1b0fd94b431d46110 Bug-Url: https://bugzilla.redhat.com/1176430 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 3 files changed, 6 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf734bf1c9b32b16f2249bc1b0fd94b431d46110 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix ClassCastException in StorageListModel
by tnisan＠redhat.com 21 Dec '14

21 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix ClassCastException in StorageListModel ...................................................................... webadmin: Fix ClassCastException in StorageListModel Due to a change introduced in patch 27578 the GetHostsForStorageOperation query returns a LinkedList instead of an ArrayList, StorageListModel wrongly casted the result explicitely to ArrayList which resulted in a ClassCastException making it impossible to remove a storage domain Change-Id: I8d16d99b51dbc55be1805c832f79bdf83c1d6764 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d16d99b51dbc55be1805c832f79bdf83c1d6764 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: RFE: sysprep file name should be according to its version
by tnisan＠redhat.com 21 Dec '14

21 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: RFE: sysprep file name should be according to its version ...................................................................... RFE: sysprep file name should be according to its version We are using sysprep inside a floppy by the filename: sysprep.inf, - which is what sysprep is looking for in .ini file format that was in xp and 2003. The new format is xml and the filename should be "Unattend.xml" for this versions. Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Bug-Url: https://bugzilla.redhat.com/1174814 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/conf/osinfo-defaults.properties 6 files changed, 39 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1aff3a70c4d34c3e4ba74152e61551f09d33fff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0