December 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Rename CommandSuffix to match java standard
by masayag＠redhat.com 28 Dec '14

28 Dec '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename CommandSuffix to match java standard ...................................................................... engine: Rename CommandSuffix to match java standard Change-Id: Iaa4d4431b721013bb175137af17689802fb9339b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4d4431b721013bb175137af17689802fb9339b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Rename QueryPrefix to QUERY_SUFFIX
by masayag＠redhat.com 28 Dec '14

28 Dec '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename QueryPrefix to QUERY_SUFFIX ...................................................................... engine: Rename QueryPrefix to QUERY_SUFFIX The attribute name should be change to reflect its nature (a suffix of a query class name) and to match java naming standard. Change-Id: I8db1fff2b8c7bb23e0bc0c6fbe5576b7199a7b8d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8db1fff2b8c7bb23e0bc0c6fbe5576b7199a7b8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix search on fedora 21
by oourfali＠redhat.com 28 Dec '14

28 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix search on fedora 21 ...................................................................... core: fix search on fedora 21 The problem was JDK 8 that is installed by default on f21 The search mechanism relies on column order retrieved from a map, it seems that there are differences that cause that return the columns in different order in JDK 8. Code was changed to use a alphabetic order of the column names to build the condition and relevant test expectations were updated accordingly. Change-Id: I4e6f2cb0832dc21be9fab9f24858e6f7c4c613ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163400 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e6f2cb0832dc21be9fab9f24858e6f7c4c613ba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bll: cleanup minor coverity issue
by oourfali＠redhat.com 28 Dec '14

28 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: bll: cleanup minor coverity issue ...................................................................... bll: cleanup minor coverity issue Change-Id: Id41b29c4b2212b9253d3bd2b5c8cb74cd4275d7e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractUserQueryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41b29c4b2212b9253d3bd2b5c8cb74cd4275d7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: clean env at start
by sbonazzo＠redhat.com 26 Dec '14

26 Dec '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: clean env at start ...................................................................... packaging: engine-backup: clean env at start Change-Id: Iec7c2a0d5a0c3314943f6bf90b8728bebf79e7ce Bug-Url: https://bugzilla.redhat.com/1172191 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec7c2a0d5a0c3314943f6bf90b8728bebf79e7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: event map: render optional.
by oourfali＠redhat.com 25 Dec '14

25 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: event map: render optional. ...................................................................... event map: render optional. Event map currently must contain 'UNASSIGNED' for each event that does not have a down event. This means that the list of events is maintained twice (AuditLogType and event_map) and occasionally creates bugs[1]. I'm suggesting to make event map optional so that only events that are actually linked with a down event will be in the table. Event registration/deletion side (commands) need not be aware of the existence of event map since only the notifier uses it. [1] https://bugzilla.redhat.com/1119285 Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java M packaging/dbscripts/event_sp.sql A packaging/dbscripts/upgrade/03_06_0690_render_event_map_optional.sql 7 files changed, 37 insertions(+), 77 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93d39249c9b57802948f356b5f0ad470ab7f32b1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000397 Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove a proxy use of ImagesHandler filter
by mlipchuk＠redhat.com 25 Dec '14

25 Dec '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove a proxy use of ImagesHandler filter ...................................................................... core: Remove a proxy use of ImagesHandler filter Remove the use of parameters in VmHandler Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 3 files changed, 7 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/26205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fencing proxy should be checked for cluster level
by oourfali＠redhat.com 25 Dec '14

25 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fencing proxy should be checked for cluster level ...................................................................... core: fencing proxy should be checked for cluster level Previous patch checked the host itself rather than the proxy Change-Id: I351655e49f4e1e8db7941426fc645575b940d7d5 Bug-Url: https://bugzilla.redhat.com/1177144 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I351655e49f4e1e8db7941426fc645575b940d7d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fencing proxy should be checked for cluster level
by oourfali＠redhat.com 25 Dec '14

25 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fencing proxy should be checked for cluster level ...................................................................... core: fencing proxy should be checked for cluster level Previous patch checked the host itself rather than the proxy Change-Id: I351655e49f4e1e8db7941426fc645575b940d7d5 Bug-Url: https://bugzilla.redhat.com/1177144 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I351655e49f4e1e8db7941426fc645575b940d7d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable pooled VM disks' illegal updates
by tnisan＠redhat.com 25 Dec '14

25 Dec '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable pooled VM disks' illegal updates ...................................................................... webadmin: Disable pooled VM disks' illegal updates Disable editing the RO and WipeAfterDelete properties of disks when editing a disk of a VM that's attached to a VM pool. Change-Id: I9d12cd00ff1e56bfb44e60fe7e50d66bef630820 Bug-Url: https://bugzilla.redhat.com/1057721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d12cd00ff1e56bfb44e60fe7e50d66bef630820 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0