July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AsyncTaskManager: Made log final
by lhornyak＠redhat.com 22 Jul '12

22 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: AsyncTaskManager: Made log final ...................................................................... core: AsyncTaskManager: Made log final Changed the declaration of the log to private static final, as per java coding standards. Change-Id: I5df88752c65be560b3d6ba03a2b917f366ef43a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5df88752c65be560b3d6ba03a2b917f366ef43a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CommandBase: Removed redundant null check
by lhornyak＠redhat.com 22 Jul '12

22 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CommandBase: Removed redundant null check ...................................................................... core: CommandBase: Removed redundant null check Removed a null check on the task variable in the CreateTask method. Right before the null check, task.getTaskID() is referenced, so task can clearly not be null at this point. Change-Id: I7c8d20f637d792914b6d6ce15cfd8753aedec64c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 8 insertions(+), 10 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8d20f637d792914b6d6ce15cfd8753aedec64c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CommandBase: Suppressed "unused" warnings
by lhornyak＠redhat.com 22 Jul '12

22 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: CommandBase: Suppressed "unused" warnings ...................................................................... core: CommandBase: Suppressed "unused" warnings Suppressed "unused" warnings for parameters in protected methods with empty implementation (intended to be overridden in extending classes which actually use these parameters). This is done in order to clean up the compilation process and avoid annoying warning markers in IDEs. Change-Id: I8021634989ca8e1bb8f8cd5af98599c612b33046 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8021634989ca8e1bb8f8cd5af98599c612b33046 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Removed obsolete jboss checking code (#837812)
by oschreib＠redhat.com 22 Jul '12

22 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Removed obsolete jboss checking code (#837812) ...................................................................... packaging: Removed obsolete jboss checking code (#837812) https://bugzilla.redhat.com/show_bug.cgi?id=837812 * Removed checking the status of ovirt-engine service before stopping it. Change-Id: Ia89d38cd6c83d8463b4f446f8878e8671b520bbd Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 20 insertions(+), 22 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia89d38cd6c83d8463b4f446f8878e8671b520bbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added function to fetch password from pgpass
by oschreib＠redhat.com 22 Jul '12

22 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added function to fetch password from pgpass ...................................................................... packaging: Added function to fetch password from pgpass * Added getDbPassword function that gets a password for a specific user. Change-Id: I3b2f906f26a47c982ebbad6a8da6a943fba507f5 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b2f906f26a47c982ebbad6a8da6a943fba507f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't initialize cluster in Network
by mkolesni＠redhat.com 22 Jul '12

22 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Don't initialize cluster in Network ...................................................................... core: Don't initialize cluster in Network Cluster should not be initialized by default. Only initialize the cluster when network with cluster data is needed in a context of a specific cluster, otherwise we have defaults which don't make sense in cases where network is not attached to a cluster. Change-Id: Ia0d256b9559e3d4190aadc2821d1d7c87318e9bf Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d256b9559e3d4190aadc2821d1d7c87318e9bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Get network_cluster from DB for setting status
by mkolesni＠redhat.com 22 Jul '12

22 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Get network_cluster from DB for setting status ...................................................................... engine: Get network_cluster from DB for setting status Get the network_cluster from DB at the beginning of the method, since if it's not in the DB then there's no sense in doing all the work as nothing will get updated in the end. Change-Id: I3008dc05cd2554345c8028c5c033f9cd282e6b48 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java 1 file changed, 35 insertions(+), 34 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3008dc05cd2554345c8028c5c033f9cd282e6b48 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change client ctor to create network_cluster
by mkolesni＠redhat.com 22 Jul '12

22 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change client ctor to create network_cluster ...................................................................... core: Change client ctor to create network_cluster Network no longer creates cluster by default, but UI require that this be initialized by default, so adding it for default UI ctor (which is ugly as it is). Change-Id: I5b8df128482ab47177bf47cdc9f1cbcc5e2d5b86 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8df128482ab47177bf47cdc9f1cbcc5e2d5b86 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Set cluster network to new if needed
by mkolesni＠redhat.com 22 Jul '12

22 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Set cluster network to new if needed ...................................................................... restapi: Set cluster network to new if needed Mapper can't rely on cluster field in Network to not be null, so setting it to template's value if available, and if not then to a new instance. Change-Id: I85f5d636b532e0a3f8475fbddb7228bc8d2e7e7b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f5d636b532e0a3f8475fbddb7228bc8d2e7e7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change network queries to omit cluster data
by mkolesni＠redhat.com 22 Jul '12

22 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change network queries to omit cluster data ...................................................................... core: Change network queries to omit cluster data Network basic queries should not return data from the cluster_networks table, unless it is specifically asked for. So fixed the queries that require network without the cluster_networks data to return network data only. Change-Id: I391deef3acd940dbe5bfd675e428d3139e135cfd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java 4 files changed, 45 insertions(+), 51 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I391deef3acd940dbe5bfd675e428d3139e135cfd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0