July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: database: do not use git when building
by dfediuck＠redhat.com 19 Jul '12

19 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: database: do not use git when building ...................................................................... database: do not use git when building If we are not building on development machine, for example we use rpmbuild -tb <tarball>, we probably do not have git or we do not have git checkout to query. There is no actual need to use git, as we can use relative directories. Cleanup the check_for_duplicate_upgrade_scripts.sh script. Change-Id: If06ea52efb4da7c51dad8fc2b32043082ce13263 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/check_for_duplicate_upgrade_scripts.sh 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If06ea52efb4da7c51dad8fc2b32043082ce13263 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Webadmin doesn't block bridge-less networks for 3....
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Webadmin doesn't block bridge-less networks for 3.0 DC ...................................................................... webadmin: Webadmin doesn't block bridge-less networks for 3.0 DC https://bugzilla.redhat.com/829380 New/Update network - Disable unchecking of vm_network for newtworks in dc with compatability version less than 3.1 note- even if the add network is done from a cluster with 3.1 version but the dc version is less than 3.1- the vm_network uncheck should be disabled Change-Id: Id1111216a745461bb00f2a9565a8afa197ad2bb7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 3 files changed, 36 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1111216a745461bb00f2a9565a8afa197ad2bb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Redesign Cluster->Add Network dialog
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Redesign Cluster->Add Network dialog ...................................................................... webadmin: Redesign Cluster->Add Network dialog https://bugzilla.redhat.com/833715 Make the Cluster->logical network->add network look like Dc->logical network->new. With two little diffs- 1. in the assign/detach part, the current cluster would be delected and disabled. 2. The message in the top of the form will be "The Network will be added to the Data Center work as well." Change-Id: I8ea31f60ca63bb255aa66ba2d5070427f150f5bf Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterNetworkPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterNetworkPopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditDataCenterNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/NewDataCenterNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java 18 files changed, 623 insertions(+), 590 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ea31f60ca63bb255aa66ba2d5070427f150f5bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Blank template has active action button...
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal,webadmin: Blank template has active action buttons (#840856) ...................................................................... userportal,webadmin: Blank template has active action buttons (#840856) https://bugzilla.redhat.com/840856 Have at least one non-blank template. Select first the non-blank, than the blank. The action buttons will be enabled. Fixed by enriching the login of TemplateListModel.isBlankTemplateSelected() which now checks all the selected templates (getSelectedItems()) and not only the first selected (getSelectedItem()). This logic is common for both webadmin and userportal, so this fix fixes the same problem in userportal as well. Change-Id: I3959752d734c01d6d1b20afeacbecaa59f2b6608 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3959752d734c01d6d1b20afeacbecaa59f2b6608 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Export shows incorrect warning(#840854)
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Export shows incorrect warning(#840854) ...................................................................... webadmin: Export shows incorrect warning(#840854) https://bugzilla.redhat.com/840854 Have 2 VMs/Templates which are already exported to an export domain. Select them again and press export. In the export dialog a warning containing only one of this VMs/Templates is shown. Fixed by rewriting the algorithm composing the message in VmBaseListModel. This logic is common for both VM export and Template export, so this fix fixes this issue for both exporting VMs and Templates. Change-Id: I84d4103fd2d2b4292575cd8b51839ee18cf42352 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java 1 file changed, 20 insertions(+), 13 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84d4103fd2d2b4292575cd8b51839ee18cf42352 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Wrong title for export template(#840506)
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Wrong title for export template(#840506) ...................................................................... webadmin: Wrong title for export template(#840506) https://bugzilla.redhat.com/840506 template view->select template->export The title of the popup was "Export Virtual Machine". This patch changes it to "Export Template" Change-Id: Ief9d2bed1c1557d48d9c54c0b8d1c86b07712572 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 7 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief9d2bed1c1557d48d9c54c0b8d1c86b07712572 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: misleading mark in host pinning->new/edit vm dialo...
by gchaplik＠redhat.com 19 Jul '12

19 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: misleading mark in host pinning->new/edit vm dialog (#839616) ...................................................................... webadmin: misleading mark in host pinning->new/edit vm dialog (#839616) https://bugzilla.redhat.com/839616 new/edit VM dialog->host->select "Run VM on the selected host (no migration allowed)" than the "Allow VM migration only upon Administrator specific request (system will not trigger automatic migration of this VM)" Should be unchecked and disabled (it was checked and disabled). Change-Id: I919acf09499f1bc38eab6a1566d79591f47507cc Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I919acf09499f1bc38eab6a1566d79591f47507cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added function to parse web-conf.js
by oschreib＠redhat.com 19 Jul '12

19 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added function to parse web-conf.js ...................................................................... packaging: Added function to parse web-conf.js Change-Id: I4b42c27783d4618a1aca2e64261ec9323fdacfa6 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/output_messages.py 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b42c27783d4618a1aca2e64261ec9323fdacfa6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: allow customization of package
by oschreib＠redhat.com 19 Jul '12

19 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: allow customization of package ...................................................................... packaging: allow customization of package Allow customization and branding: 1. Package name. 2. Package description. 3. User name. Allow skip installation and registration of POM files, which is unsupported in rhel. Change-Id: I25198ee1b4855ab69fccf5e36d1bf8bd5935dfcf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 45 insertions(+), 24 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25198ee1b4855ab69fccf5e36d1bf8bd5935dfcf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Bind ports to loopback by default
by oschreib＠redhat.com 19 Jul '12

19 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Bind ports to loopback by default ...................................................................... packaging: Bind ports to loopback by default This patch changes the JBoss configuration file so that most ports are bound to the loopback interface by default, as they are not expected to be used from outside the machine. This also reduces the attack surface of the engine, even if the firewall is disabled. Change-Id: If90e140e8767f229eaaf141a68231e5964c724ca Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.xml.in 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90e140e8767f229eaaf141a68231e5964c724ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0