July 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Activate and remove host one after another causes dead...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core: Activate and remove host one after another causes deadlock (system stuck) (#840467) ...................................................................... core: Activate and remove host one after another causes deadlock (system stuck) (#840467) https://bugzilla.redhat.com/840467 The activate and remove should not be happened simenteniously, the mechanism was already written, but was missed annottation to class Change-Id: I92d6c8bf0060e5eade1057dfa75aea211525ad80 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92d6c8bf0060e5eade1057dfa75aea211525ad80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add configured range validator

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Add configured range validator ...................................................................... core: Add configured range validator The patch introduces configured range validator which could be set on business entities properties to enforce the valid range of a given input. The declaration of the validator requires a configuration value to specify the upper limit of the range. The lower limit could be specified either by a configuration value or by setting a constant or using the default (zero). Change-Id: I23642aa79b263019acbdde4ee44e27f5a0ac992e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ConfiguredRange.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ConfiguredRangeValidatorTest.java 3 files changed, 234 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23642aa79b263019acbdde4ee44e27f5a0ac992e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Get network connectivity timeout from configuratio...

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Get network connectivity timeout from configuration ...................................................................... webadmin: Get network connectivity timeout from configuration The patch replaces a hard-coded connectivity timeout and fetch its default value from the engine configuration property. Change-Id: Ia230c175069a4db49b91699c617e7856fee7dd52 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 4 files changed, 44 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia230c175069a4db49b91699c617e7856fee7dd52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Validate the connectivity timeout for SetupNetworks

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Validate the connectivity timeout for SetupNetworks ...................................................................... core: Validate the connectivity timeout for SetupNetworks The patch validate the value of the connectivity timeout when it is passed by the clients for SetupNetworks command. The legal range for the timeout is between 1 and 120 seconds. If the check connectivity property is set to true, but no timeout is passed, the command will be executed with the default timeout. Change-Id: I7e03ec8dc60710780df9bf7b711d639b8c80327e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 31 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e03ec8dc60710780df9bf7b711d639b8c80327e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: CustomFieldSerializers - remove redundant logs

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: CustomFieldSerializers - remove redundant logs ...................................................................... webadmin: CustomFieldSerializers - remove redundant logs Remove redundant GWT.log calls in: VdcReturnValueBase_CustomFieldSerializer and VdcQueryReturnValue_CustomFieldSerializer Change-Id: I78ef60d63ffbee30e06cd2fd3d49a704f7702e10 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/action/VdcReturnValueBase_CustomFieldSerializer.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 2 files changed, 0 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78ef60d63ffbee30e06cd2fd3d49a704f7702e10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: SanStorageLists - pass multiSelection flag

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SanStorageLists - pass multiSelection flag ...................................................................... webadmin: SanStorageLists - pass multiSelection flag Passing multiSelection flag to AbstractSanStorageList constructor (for percolating through SanStorageLunToTargetList and SanStorageTargetToLunList). Change-Id: Ifdcda0efb8b497f5d63ad9d969648ffde5e3d04a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 3 files changed, 7 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdcda0efb8b497f5d63ad9d969648ffde5e3d04a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-dwh[master]: etl: fixed if syntex regression in configuration sync.

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed if syntex regression in configuration sync. ...................................................................... etl: fixed if syntex regression in configuration sync. Change-Id: Id47ac3815a208987a19fedf8219bc95749099273 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_1/ConfigurationSync.java M data-warehouse/history_etl/tos_project/configuration/ExpressionBuilder/ConfigurationSync.xml M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.item M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.properties M data-warehouse/history_etl/tos_project/talend.project 5 files changed, 1,148 insertions(+), 1,355 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id47ac3815a208987a19fedf8219bc95749099273 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: build: use useradd, groupadd, getent from /usr filesystem

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: build: use useradd, groupadd, getent from /usr filesystem ...................................................................... build: use useradd, groupadd, getent from /usr filesystem This is common to fedora-17, fedora-17, rhel-6.3 Change-Id: I5de09eb2ce84169ad350b102fb7261808e025df9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de09eb2ce84169ad350b102fb7261808e025df9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: build: place proper name for jars/poms if package name modif...

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: build: place proper name for jars/poms if package name modified ...................................................................... build: place proper name for jars/poms if package name modified Per Juan notes at[1] According to the Fedora packaging guidelines the names of the POMs should start with JPP.%{name}. See [2]. However, there is dependency between the jar location and the prefix of the pom file. The solution is to create symbolic link at _javadir if package name is different from upstream name. [1] http://gerrit.ovirt.org/#/c/6252/5/packaging/fedora/spec/ovirt-engine.spe... [2] https://fedoraproject.org/wiki/Packaging:Java#maven3. Change-Id: Iae5434a00537892a21446f18c28b263683402d09 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae5434a00537892a21446f18c28b263683402d09 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: build: move /var structure creation from Makefile to spec

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: build: move /var structure creation from Makefile to spec ...................................................................... build: move /var structure creation from Makefile to spec This [may] help us package the "make install" output to different distributions. Most packages' "make install" does not handle /var creation. The impact for rpm based packages is none. Also clenaup spec file symbols for /var locations. Change-Id: Ib450429d4d6e5f5cbf0ae60bf3fb3baf6d5e5fb6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 7 insertions(+), 8 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib450429d4d6e5f5cbf0ae60bf3fb3baf6d5e5fb6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

12 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2012