July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Change "VM is locked" message to contain disk name (81...
by tnisan＠redhat.com 18 Jul '12

18 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Change "VM is locked" message to contain disk name (819291) ...................................................................... core: Change "VM is locked" message to contain disk name (819291) https://bugzilla.redhat.com/819291 Changed the VM is locked message to display the actual reason and the disk name in case the lock is on a disk from the VM Change-Id: I574c3544c9a1977832dcd4365b6ea336a3a3ceff Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 11 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I574c3544c9a1977832dcd4365b6ea336a3a3ceff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: don't update the current logged-in user as returned fr...
by rgolan＠redhat.com 18 Jul '12

18 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: don't update the current logged-in user as returned from VDSM ...................................................................... core: don't update the current logged-in user as returned from VDSM The logged-in user should only be updated via a Login command. Change-Id: I5d2b3fa6581b008178deb3e5e63b2e1120ca8404 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2b3fa6581b008178deb3e5e63b2e1120ca8404 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Status column in LUNs list
by derez＠redhat.com 18 Jul '12

18 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Status column in LUNs list ...................................................................... webadmin: Status column in LUNs list Added 'Status' column in SanStorageLunToTargetList and SanStorageTargetToLunList.java. Change-Id: I30e70eacb759beebf68ed089cf728f48e9cff207 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 5 files changed, 29 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30e70eacb759beebf68ed089cf728f48e9cff207 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Small improvements at reconstruct flow
by mkublin＠redhat.com 18 Jul '12

18 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Small improvements at reconstruct flow ...................................................................... core: Small improvements at reconstruct flow We don't need to use a query in order to retrieve id of master domain, it is known Change-Id: I976f84125951df16eb99c24e4f25ede9dd53681b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976f84125951df16eb99c24e4f25ede9dd53681b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change reconstruct flow
by mkublin＠redhat.com 18 Jul '12

18 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Change reconstruct flow ...................................................................... core: Change reconstruct flow The following patch will add an option to mark a time when domain was used as master for reconstruct flow, also patch will allow to choose a same storage domain as master during reconstruct flow, will solve a problem of one storage domain at pool and will help when we alreday tried all other storage domains Patch contains appropriate change, remove of unneeded functionality, disabling of unneeded transactions Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/storages_sp.sql A backend/manager/dbscripts/upgrade/03_01_1290_add_last_time_used_as_master_col.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domain_static.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 20 files changed, 211 insertions(+), 203 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie95c014b232e9a929f988a115c824d9960f9a290 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Set different key for timeout entity in TimeoutBaseTes...
by masayag＠redhat.com 18 Jul '12

18 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Set different key for timeout entity in TimeoutBaseTest ...................................................................... core: Set different key for timeout entity in TimeoutBaseTest The patch modifies the entity key to be unique per test, as it is being stored in a static collection and violates the autonomous test execution. Change-Id: I0c46f3d8709e48d96e79d97815935b9089bff0bd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/6393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c46f3d8709e48d96e79d97815935b9089bff0bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extend the lapse of timeout
by rgolan＠redhat.com 17 Jul '12

17 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: Extend the lapse of timeout ...................................................................... core: Extend the lapse of timeout The unit-test fails selectively when trying to validate the expiration time of a specific value. The value is set with time of the system and compared to another call for that system time. The suspicious is that the second call might return a lower time than the first one, as there is no contract for accuracy. The solution is to increase the lapse of timeout. Change-Id: I330a9b1ff5c20b0885f262943d1fe2107f8da7c7 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/6376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I330a9b1ff5c20b0885f262943d1fe2107f8da7c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Fixed log path to /var/log/ovirt-engine
by ydary＠redhat.com 17 Jul '12

17 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Fixed log path to /var/log/ovirt-engine ...................................................................... packaging: Fixed log path to /var/log/ovirt-engine Change-Id: I9e731812a4dd06781ed6d1224f83bb030beadf53 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e731812a4dd06781ed6d1224f83bb030beadf53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Setup network- bug in editing vlan
by derez＠redhat.com 17 Jul '12

17 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Setup network- bug in editing vlan ...................................................................... webadmin: Setup network- bug in editing vlan https://bugzilla.redhat.com/836459 https://bugzilla.redhat.com/824432 1. The edit dialog of the vlan reflected the nic the vlan attached to and not the bridge. 2. Fix NPE when dragging an Unaatached network back to the Unattached networks panel. 3. Adding some missing enums. Change-Id: I02e570dc2e529d47b9370bd5df2ccaa2b8aeedd4 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 5 files changed, 42 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02e570dc2e529d47b9370bd5df2ccaa2b8aeedd4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MAC address released when MAC is used (#839201)
by masayag＠redhat.com 17 Jul '12

17 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: MAC address released when MAC is used (#839201) ...................................................................... core: MAC address released when MAC is used (#839201) https://bugzilla.redhat.com/839201 The patch prevents from releasing an allocated MAC address before the completion of the can-do-action. The MAC address will be released as the last step of the command execution. However if from some reason the command will fail to complete its transaction, the rollback will try to allocate the MAC address again and free the allocated one. Change-Id: Ifb5109831cf1e290628e579add0ed060393b0d99 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java 1 file changed, 36 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb5109831cf1e290628e579add0ed060393b0d99 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0