July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: fixing logging issues at engine-config
by yzaslavs＠redhat.com 29 Jul '12

29 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: fixing logging issues at engine-config ...................................................................... tools: fixing logging issues at engine-config 1. Usage of -Dlog4j.configuration instead of DOMConfiguration 2. Removal of warning messages (no append can be found for EngineConfigCLIPParser) Change-Id: I5a4642d605ba4c5460acb69fb92d899458371402 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/resources/engine-config 3 files changed, 3 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a4642d605ba4c5460acb69fb92d899458371402 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: wrongly attach rhev-tools for other or unassigned vms ...
by oourfali＠redhat.com 29 Jul '12

29 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: wrongly attach rhev-tools for other or unassigned vms (#838545) ...................................................................... core: wrongly attach rhev-tools for other or unassigned vms (#838545) https://bugzilla.redhat.com/838545 This patch changes the logic of attaching the guest tools, to run only on windows VM's (instead of non-Linux ones). Change-Id: I09c5e26d7e5378e38d82b9c66cabdc7d020f545b Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09c5e26d7e5378e38d82b9c66cabdc7d020f545b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove vnic from unplugged running vm
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove vnic from unplugged running vm ...................................................................... webadmin: Remove vnic from unplugged running vm https://bugzilla.redhat.com/841582 On running vm- the remove of vnics needs to be enabled if the vnics are unplugged (deactivated). Change-Id: I2697c3686f7b456c22581af3c722ae40eb8f0eb6 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2697c3686f7b456c22581af3c722ae40eb8f0eb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Not sync network should display the host info
by derez＠redhat.com 29 Jul '12

29 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Not sync network should display the host info ...................................................................... webadmin: Not sync network should display the host info https://bugzilla.redhat.com/842300 Setup Networks- If a host contains a netwrok that is not in sync with the cluster network. The setup networks dialo g displays the cluster network data (mtu and vlan_id) and not the real (host) data. Should be the opposite. Change-Id: I491d2057cf6f771e3cedead454d9f851b9d9d584 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I491d2057cf6f771e3cedead454d9f851b9d9d584 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup Mac Address when NetworkInterface Fails (#8423...
by msalem＠redhat.com 29 Jul '12

29 Jul '12

Muli Salem has submitted this change and it was merged. Change subject: core: Cleanup Mac Address when NetworkInterface Fails (#842317) ...................................................................... core: Cleanup Mac Address when NetworkInterface Fails (#842317) https://bugzilla.redhat.com/842317 This patch makes sure the Mac address is removed from the MacPoolManager when UpdateNetworkInterface and AddNetworkInterface fail. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: Icfb5662d94db249125e77e72634375330fd9f34d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java 2 files changed, 62 insertions(+), 47 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfb5662d94db249125e77e72634375330fd9f34d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Enable Using Lowercase Usage in Network (#817798)
by msalem＠redhat.com 29 Jul '12

29 Jul '12

Muli Salem has submitted this change and it was merged. Change subject: restapi: Enable Using Lowercase Usage in Network (#817798) ...................................................................... restapi: Enable Using Lowercase Usage in Network (#817798) https://bugzilla.redhat.com/817798 Refer to subject. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: Id77c90d094f09516f7e23ae55116af7c6b08b651 --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java 2 files changed, 13 insertions(+), 9 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id77c90d094f09516f7e23ae55116af7c6b08b651 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: core:pre upgrade scripts will not run ...(#842119)
by emesika＠redhat.com 29 Jul '12

29 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core:pre upgrade scripts will not run ...(#842119) ...................................................................... core:pre upgrade scripts will not run ...(#842119) pre upgrade scripts will not run correctly upon 3.0 DB restore https://bugzilla.redhat.com/show_bug.cgi?id=842119 Restore a 3.0 database and running the 3.1 upgrade scripts on it is not working. This patch fixes this problem by : 1) force pre-upgrade scripts to run if any upgrade file is about to run , this will be done even if no change was detected in views, sp & upgrade files as it may occur when the database is restored. 2) make pre-upgrade and post upgrade scripts ordered since the configuration settings and some fixes in the custom sql file must run first. This is done by prefixing the script name with a 4 digit number. (0000 00010 00020 etc.) Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit 5845c732560dc325132661e1d1260de0a096c6b7) --- M backend/manager/dbscripts/dbfunctions.sh R backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0010_custom.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0020_add_comment_col_to_schema_version.sql 5 files changed, 9 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: userportal: not passing hostsubject to spice-xpi
by emesika＠redhat.com 29 Jul '12

29 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: userportal: not passing hostsubject to spice-xpi ...................................................................... userportal: not passing hostsubject to spice-xpi The problem was, that the add_object_column_white_list_table.sql was ran as pre-upgrade script, but it tried to fill the object_column_white_list according to the not-yet crated view named 'vds'. Solved by creating also post-upgrade scripts, as a last step of the upgrade process and making the add_object_column_white_list_table.sql to be a post-upgrade script. Change-Id: Ice7c00a158a8778a6cb424be4e9720715a4df283 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> (cherry picked from commit 79cbe9b016abbf82e307c0b037d84df580c89738) --- M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/upgrade/post_upgrade/add_object_column_white_list_table.sql D backend/manager/dbscripts/upgrade/pre_upgrade/add_object_column_white_list_table.sql 3 files changed, 86 insertions(+), 74 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice7c00a158a8778a6cb424be4e9720715a4df283 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Animal-sniffer to check JDK6 compatibility
by dfediuck＠redhat.com 29 Jul '12

29 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Animal-sniffer to check JDK6 compatibility ...................................................................... core: Animal-sniffer to check JDK6 compatibility Since it was agreed that oVirt should remain backwards compatible to JDK6 APIs, it is needed to introduce a mechanism to validate this. Animal Sniffer is a standard maven plugin that enforces code compatibility to jar versions (including but not limited to JDKs), without requiring these jars to be installed - only a signature spec is required, and Animal Sniffer provides such signatures to older JDK versions. Change-Id: I83ffd34058ae3862087725acb1bcc21b1b4dcd38 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Allon Mureinik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ffd34058ae3862087725acb1bcc21b1b4dcd38 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added method to calculate network details (#838300)
by mkolesni＠redhat.com 29 Jul '12

29 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added method to calculate network details (#838300) ...................................................................... core: Added method to calculate network details (#838300) https://bugzilla.redhat.com/838300 This method accepts an interfaces, and a map of networks, and calculates the details in accordance. Currently only the "sync" property is set, and in the near future more details will be available (when added). Change-Id: I5634fa47f30096e4c58bf3186ccba53f2fa3bbd2 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 163 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Livnat Peer: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5634fa47f30096e4c58bf3186ccba53f2fa3bbd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0