July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add network details to host's network device (#838300)
by mkolesni＠redhat.com 29 Jul '12

29 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add network details to host's network device (#838300) ...................................................................... core: Add network details to host's network device (#838300) https://bugzilla.redhat.com/838300 Added an inner class to hold various details regarding the logical network that is assigned to the network device (represented by VdsNetworkInterface). Currently only detail is if the network physical definition is in sync with the logical one. Change-Id: I4d5bd0986eccac5de2c146c9e47cd424e9ead3bb Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNetworkInterface.java 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Livnat Peer: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d5bd0986eccac5de2c146c9e47cd424e9ead3bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove nic's vlan from add/edit dialog
by gchaplik＠redhat.com 29 Jul '12

29 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove nic's vlan from add/edit dialog ...................................................................... webadmin: remove nic's vlan from add/edit dialog https://bugzilla.redhat.com/842734 vlan networks attached to a nic has a separate dialog and should be in the network list of the nics add/edit dialog. Change-Id: I75619f0efee90601ad4f47db666a4af0b576420d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 106 insertions(+), 154 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75619f0efee90601ad4f47db666a4af0b576420d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replacing StringUtils for StringHelper in LdapBrokerCo...
by yzaslavs＠redhat.com 28 Jul '12

28 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Replacing StringUtils for StringHelper in LdapBrokerCommandBase. ...................................................................... core: Replacing StringUtils for StringHelper in LdapBrokerCommandBase. StringHelper is deprecated. Change-Id: Ib7f37ce176684d9cb35199507e03097cacc150cd Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f37ce176684d9cb35199507e03097cacc150cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix notifier script
by yzaslavs＠redhat.com 27 Jul '12

27 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix notifier script ...................................................................... core: Fix notifier script The jaxb-impl jar file is no longer in the lib directory of the .ear, where the notifier expects it. This patch fixes the classpath so that the notifier uses the file in the /usr/share/java directory. Change-Id: I09de69e62aa21ae2e9fa2c20ad31fb3fbb60bb45 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.conf M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/conf/notifier.conf 4 files changed, 5 insertions(+), 76 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09de69e62aa21ae2e9fa2c20ad31fb3fbb60bb45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: make the whole tabs clickable (#783176...
by vszocs＠redhat.com 27 Jul '12

27 Jul '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal, webadmin: make the whole tabs clickable (#783176) ...................................................................... userportal, webadmin: make the whole tabs clickable (#783176) https://bugzilla.redhat.com/783176 Solved by replacing the InlineHyperlink by Label and enclosing the whole tab into an anchor element (with corresponding CSS adjustments) for the following components: - SimpleTab [used for main and sub tabs] - UserPortalMainTab [Basic/Extended tabs] - VerticalTab [Extended side tabs] Change-Id: Ia3b238cafb0e8cc6915a6b914eb7125cc901df41 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/SimpleTab.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/VerticalTab.ui.xml 4 files changed, 107 insertions(+), 50 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b238cafb0e8cc6915a6b914eb7125cc901df41 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Use AspectJ annotations instead of compiler
by vszocs＠redhat.com 27 Jul '12

27 Jul '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Use AspectJ annotations instead of compiler ...................................................................... webadmin: Use AspectJ annotations instead of compiler The advantage of using the AspectJ annotations style instead of the AspectJ language and compiler is that there is no need to use an special maven plugin to do the build of the aspects. This also means that there is no need to use any special Eclipse plugin to support that maven pluging. Change-Id: I19fceace94978ada932f214f936041e1257fafa9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/pom.xml R frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/DontPrune.java M frontend/webadmin/modules/gwt-extension/src/main/resources/META-INF/aop.xml M frontend/webadmin/modules/pom.xml 4 files changed, 20 insertions(+), 34 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19fceace94978ada932f214f936041e1257fafa9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Support newer versions M2E plugin
by yzaslavs＠redhat.com 27 Jul '12

27 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Support newer versions M2E plugin ...................................................................... core: Support newer versions M2E plugin Recent versions of the M2E plugin (e.g., the one bundled with Eclipse Juno) fail the Eclipse build since they are unable to execute the Maven Checkstyle Plugin. This patch disables running the checkstyle plugin in Eclipse (only!) until M2E supports it properly. Change-Id: I1d40bc0a7e49f417421b0eff9d1715aa44e12273 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 25 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d40bc0a7e49f417421b0eff9d1715aa44e12273 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix GetVdsCertificateSubject query
by oourfali＠redhat.com 26 Jul '12

26 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix GetVdsCertificateSubject query ...................................................................... core: fix GetVdsCertificateSubject query This patch fixes two bugs in this query: 1. succeeded setting 2. Return value of the internal query should be the string one, and not the VdcReturnValue Change-Id: Ifb0a157ca2561ae8563da46c66354db5f28ccb37 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVmIdQuery.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb0a157ca2561ae8563da46c66354db5f28ccb37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing log4j.xml of engine-config
by yzaslavs＠redhat.com 26 Jul '12

26 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing log4j.xml of engine-config ...................................................................... core: fixing log4j.xml of engine-config This patch fixes log4j.xml of engine-config In such a way that the output can be used by engine-manage-domains Change-Id: Id49aa1090ba9ddab3c4b1af15c0786791fb6f9dd Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/log4j.xml 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id49aa1090ba9ddab3c4b1af15c0786791fb6f9dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: excluding log4.xml from engine-config
by yzaslavs＠redhat.com 26 Jul '12

26 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: excluding log4.xml from engine-config ...................................................................... tools: excluding log4.xml from engine-config log4j.xml should not be included at engine-config.jar Engine-config should use the log4.xml file at /etc/ovirt-engine/engine-config Change-Id: I7cb2d9653c7a0f5d20369d44e59c9bf39e04baa9 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-config/pom.xml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cb2d9653c7a0f5d20369d44e59c9bf39e04baa9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0