December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused SnapshotManager.getVmDao()
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused SnapshotManager.getVmDao() ...................................................................... core: Remove unused SnapshotManager.getVmDao() Change-Id: I5f65b591abef6b3581ed483f9f240e5f37d1e86c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f65b591abef6b3581ed483f9f240e5f37d1e86c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm serialVersionUUID in a non-Serializable
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm serialVersionUUID in a non-Serializable ...................................................................... core: rm serialVersionUUID in a non-Serializable Removed StorageHandlingCommandBaseTest.TestStorageHandlingCommandBase.serialVersionUUID, as this class is not Serializable. Change-Id: Id34608ce6055f061c32e8764d8961e882572aeec Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id34608ce6055f061c32e8764d8961e882572aeec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enable GlusterCoreUtilTest.testContainsBrick
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Enable GlusterCoreUtilTest.testContainsBrick ...................................................................... core: Enable GlusterCoreUtilTest.testContainsBrick Added the @Test annotation so this test is actually run. Change-Id: I2c1ffa0023294d93d04942c84bc2ac3e6c63f025 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtilTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1ffa0023294d93d04942c84bc2ac3e6c63f025 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm UpdateStoragePool.getResourceManager
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm UpdateStoragePool.getResourceManager ...................................................................... core: rm UpdateStoragePool.getResourceManager This method is unused and can safely be deleted. Change-Id: I8703a7dd984dbc02751055e05040a4a8f8571d3a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8703a7dd984dbc02751055e05040a4a8f8571d3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removed unused RepoImage members
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused RepoImage members ...................................................................... core: Removed unused RepoImage members Removed the unused storagePoolStatus, StorageDomainStatus and vdsStatus members (along with their getters and setters) from RepoImage. Change-Id: Ie1d2c02df37b7c21568f73e65c0fed875f249f79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage.java 1 file changed, 0 insertions(+), 48 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d2c02df37b7c21568f73e65c0fed875f249f79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused methods from ErrorTranslator[Impl]
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused methods from ErrorTranslator[Impl] ...................................................................... core: rm unused methods from ErrorTranslator[Impl] Change-Id: Iff84d5cd7e9dc0690eff490c463ea9ebe36dfc97 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java 2 files changed, 0 insertions(+), 35 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff84d5cd7e9dc0690eff490c463ea9ebe36dfc97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: Remove unused DateTime methods
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core,webadmin: Remove unused DateTime methods ...................................................................... core,webadmin: Remove unused DateTime methods Change-Id: I3dcb8be6ca44e6f7fa1e1ca7bb4f0f5a647370ad Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java 2 files changed, 0 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dcb8be6ca44e6f7fa1e1ca7bb4f0f5a647370ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: run VmDeviceTest.testSelfAndIdthentifyEquality
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: run VmDeviceTest.testSelfAndIdthentifyEquality ...................................................................... core: run VmDeviceTest.testSelfAndIdthentifyEquality testSelfAndIdentifyEquality() was missing the @Test annotation, and thus was never run. This patch rectifies that mistake. Change-Id: Ie441d2dd33b44f90dfd56a59317cd1589f0a42c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmDeviceTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie441d2dd33b44f90dfd56a59317cd1589f0a42c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm VmCompletionMap from SyntaxChecker
by amureini＠redhat.com 04 Dec '13

04 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm VmCompletionMap from SyntaxChecker ...................................................................... core: rm VmCompletionMap from SyntaxChecker The VmCompletionMap is a deprecated concept which does not make sense (and is indeed unused) in ISyntaxChecker and all its implementations. This patch removes this property and all references to it. Change-Id: I93999dfb0287730fee294de45b284571807e25bf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ISyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 0 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93999dfb0287730fee294de45b284571807e25bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename tags class to Tags
by oourfali＠redhat.com 04 Dec '13

04 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine: rename tags class to Tags ...................................................................... engine: rename tags class to Tags Change-Id: If8c9094fe033d3e2a6c4dce7fc7df3c5e134efa5 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddTagCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveTagCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsCommandOperationBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateTagCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TagsDirectorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TagsOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Tags.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ITagsHandler.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BatchProcedureCallTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MultiThreadedDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedTagResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUserTagsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmTagsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedTagsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTagsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TagMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TagMapperTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/TagsEqualityComparer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 40 files changed, 347 insertions(+), 346 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c9094fe033d3e2a6c4dce7fc7df3c5e134efa5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0