March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: agent: Running PEP8 checks on python files
by bazulay＠redhat.com 20 Mar '13

20 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Running PEP8 checks on python files ...................................................................... agent: Running PEP8 checks on python files Change-Id: Ie41f1126dfd124e393ae11e9c4c054c7c23ce7aa Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M Makefile.am M configure.ac 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie41f1126dfd124e393ae11e9c4c054c7c23ce7aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Pep8 fixes
by bazulay＠redhat.com 20 Mar '13

20 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Pep8 fixes ...................................................................... agent: Pep8 fixes * CredServer * GuestAgentLinux2 * VirtIoChannel * WinFile * version * setup.py - FP on py2exe import * OVirtGuestAgent * OVirtAgentLogic * ovirt-guest-agent * LockActiveSession * GuestAgentWin32 Change-Id: I74c33ed2ef2e5c33b9d25cb8b38e4201d67a957b Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/CredServer.py M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/LockActiveSession.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/OVirtGuestService.py M ovirt-guest-agent/VirtIoChannel.py M ovirt-guest-agent/WinFile.py M ovirt-guest-agent/ovirt-guest-agent.py M ovirt-guest-agent/setup.py M ovirt-guest-agent/version.py 11 files changed, 410 insertions(+), 207 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74c33ed2ef2e5c33b9d25cb8b38e4201d67a957b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cluster policy details moved to a new sub-tab
by kmayilsa＠redhat.com 20 Mar '13

20 Mar '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Cluster policy details moved to a new sub-tab ...................................................................... webadmin: Cluster policy details moved to a new sub-tab Cluster policy details are moved from cluster's 'General' sub-tab to a new 'Policy' sub-tab. Policy sub-tab will be shown only if the selected cluster supports virt service. Refactored ClusterPolicyModel code. 'Cluster Node Type' field in General tab will be visible only if the application is running on Virt+Gluster mode. Change-Id: I600b1614f6e8a1a82b254b76c7713678cfb9e557 Bug-Url: https://bugzilla.redhat.com/920078 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterHostPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterNetworkPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterPolicyPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterServicePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterVmPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterPolicyView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterPolicyView.ui.xml 20 files changed, 459 insertions(+), 364 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I600b1614f6e8a1a82b254b76c7713678cfb9e557 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Call restorecon on pidfile
by bazulay＠redhat.com 20 Mar '13

20 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Call restorecon on pidfile ...................................................................... agent: Call restorecon on pidfile Change-Id: I8729ce8018566b400846e0d639dfdb6b11d51862 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/ovirt-guest-agent 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8729ce8018566b400846e0d639dfdb6b11d51862 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Reported MAC on Windows now the same as on Linux
by bazulay＠redhat.com 20 Mar '13

20 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Reported MAC on Windows now the same as on Linux ...................................................................... agent: Reported MAC on Windows now the same as on Linux Reporting of the MAC differs between linux and Windows guest operating systems. The windows operating system reports it separated by dashes '-'. This changeset will replace those dashes with colons ':' Change-Id: Id19a8944025ee22d82a57b99fe4ba1c4315c27e9 Bug-Url: https://bugzilla.redhat.com/908761 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id19a8944025ee22d82a57b99fe4ba1c4315c27e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Sorted gitignore and added .idea
by bazulay＠redhat.com 20 Mar '13

20 Mar '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Sorted gitignore and added .idea ...................................................................... agent: Sorted gitignore and added .idea Change-Id: Iad052f3d272b5df68275de9baeac3f9e45ea32c5 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M .gitignore 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad052f3d272b5df68275de9baeac3f9e45ea32c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: refactor in VmModelBehaviorBase
by tjelinek＠redhat.com 20 Mar '13

20 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: refactor in VmModelBehaviorBase ...................................................................... frontend: refactor in VmModelBehaviorBase Replace usage of List+indexes with Map+enum values which are more appropriate to store the timezone values per timezone type (windows timezone, general timezone). Change-Id: Ib7f12c4f8be93adfd0c1983a57c8e60c629ad331 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 21 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f12c4f8be93adfd0c1983a57c8e60c629ad331 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated parsing of the tasks
by juan.hernandez＠redhat.com 20 Mar '13

20 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated parsing of the tasks ...................................................................... packaging: Updated parsing of the tasks This patch replaces the execRemoteSql call with the parseRemoteSqlCall, which allows easier parsing of the output during tasks and compensation check. Then the lenght of the output is tested and actual list of tasks is returned if necessary. Change-Id: I3b1f24ef5e83cf09c01c3ebbb00375098ddc52c1 Bug-Url: https://bugzilla.redhat.com/921578 Bug-Url: https://bugzilla.redhat.com/912426 Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 33 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b1f24ef5e83cf09c01c3ebbb00375098ddc52c1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Don't generate .jar.index files
by juan.hernandez＠redhat.com 19 Mar '13

19 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Don't generate .jar.index files ...................................................................... packaging: Don't generate .jar.index files The service has already been modified so that it doesn't use the .index.jar files, but both the service and the tools need to be modified so that they don't generate new .index.jar files. Change-Id: If842d8d4a9c1ba8303f440d2ce70c42f23a29e06 Bug-Url: https://bugzilla.redhat.com/923389 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-config.sh M backend/manager/tools/src/main/shell/engine-encrypt-passwd.sh M backend/manager/tools/src/main/shell/engine-manage-domains.sh M backend/manager/tools/src/main/shell/engine-notifier.sh M packaging/fedora/engine-service.py.in 5 files changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If842d8d4a9c1ba8303f440d2ce70c42f23a29e06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update version of postgresql driver
by emesika＠redhat.com 19 Mar '13

19 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: update version of postgresql driver ...................................................................... packaging: update version of postgresql driver For some reason the 9.1-901.jdbc4 downloads 9.0 driver, may be a problem in maven mirrors, as download directly from search downloads currect version. 9.1-901-1.jdbc4 works correctly. Change-Id: I8e59d1de684f70539385637a1a03efb4b4a8c701 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e59d1de684f70539385637a1a03efb4b4a8c701 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0