Change in ovirt-engine[master]: engine : Set endAction try again to false on failure
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : Set endAction try again to false on failure
......................................................................
engine : Set endAction try again to false on failure
On failure of commands with handlers, if no handler
has been executed the endWithFailure is not invoked
on the handlers. This can leave setEndActionTryAgain to
true causing AsyncTaskManager to continuously wait for
commands completion. In such cases the CommandBase should
set the setEndActionTryAgain to false so the command
can converge.
Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Bug-Url: https://bugzilla.redhat.com/1159325
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: adjusted width of create template dialog
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adjusted width of create template dialog
......................................................................
webadmin: adjusted width of create template dialog
Adjusted width for better accommodating disks table.
Change-Id: I23649dd270935aead25815eaff311b2efadba814
Bug-Url: https://bugzilla.redhat.com/1149466
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java
5 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/34799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23649dd270935aead25815eaff311b2efadba814
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: packaging: fail the build if osinfo-defaults.properties fail...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse
......................................................................
packaging: fail the build if osinfo-defaults.properties fails to parse
check the properties file we ship with the exact code that checks it
at runtime when the engine loads.
this test is hooked into the packaging process and must fail it.
Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c
Bug-Url: https://bugzilla.redhat.com/1056965
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M Makefile
A build/validations/pom.xml
A build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java
M packaging/conf/osinfo-defaults.properties
4 files changed, 50 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: Date formatting when deleting a snapshot
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Date formatting when deleting a snapshot
......................................................................
webadmin: Date formatting when deleting a snapshot
When deleting a VM's snapshot a formatted date is now shown based on a
constant taken from another component in the system (DiskGeneralModel)
for system consistency. this constant is intended to be exported to
some util class later on.
Bug-Url: https://bugzilla.redhat.com/1158959
Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit http://gerrit.ovirt.org/34837
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[master]: webadmin: Correction of UI Constants
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Correction of UI Constants
......................................................................
webadmin: Correction of UI Constants
Messages that was using the word "Detach" incorrectly, namely using
capital "D" when there was no need to- changed to "detach".
In addition, the "Data Center" part of the message who related
to detaching storage from a data center has changed back to
"Data Center(s)" due to the fact that it is possible that some
chosen Storage is attached to more than one Data Center.
Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7
Bug-Url: https://bugzilla.redhat.com/1152558
Relates-To:https://bugzilla.redhat.com/1149457
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Amit Aviram: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/34595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: Hot plug CPU - allow over-commit in QEMU limits
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Hot plug CPU - allow over-commit in QEMU limits
......................................................................
core: Hot plug CPU - allow over-commit in QEMU limits
Allow to hot plug CPUs up to QEMU limits[1] even if they over-commit the
host resources.
[1] http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.kvm.lim...
Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863
Bug-Url: https://bugzilla.redhat.com/1097195
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java
1 file changed, 13 insertions(+), 3 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: frontend: Fix Vm Dialog name validation
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix Vm Dialog name validation
......................................................................
frontend: Fix Vm Dialog name validation
Add missing call to setValidTab upon validation of name, description and
comment properties.
Change-Id: If15c482953c48107d155d1c5e8206c675ff9fb23
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124363
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
--
To view, visit http://gerrit.ovirt.org/34858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If15c482953c48107d155d1c5e8206c675ff9fb23
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 1 month
Change in ovirt-engine[master]: webadmin: create template - sub version label
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: create template - sub version label
......................................................................
webadmin: create template - sub version label
Changed label to: "Create as a Template Sub Version"
Change-Id: Ied4b6637dfc4ce34c2f59286db305314fc2217a4
Bug-Url: https://bugzilla.redhat.com/1149466
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/34798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied4b6637dfc4ce34c2f59286db305314fc2217a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: validate osinfo properties files - fail backend on error
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: validate osinfo properties files - fail backend on error
......................................................................
core: validate osinfo properties files - fail backend on error
validate the osinfo properties files by the order of loading.
on-error, a RuntimeException is thrown, which should fail the backend
from loading.
The parsing itself is implemented using ANTLR parser and lexer
generator and the Osinfo.g4 grammar file.
Osinfo.g4
grammar file that expresses the syntax of the properties file and
except for unique validation needs should be the only place to be
changed when needed.
OsinfoPreferencesParser.java
the tool to parse a property file with and match is against the syntax
OsinfoPreferencesParser.parse("path/to/file")
Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c
Bug-Url: https://bugzilla.redhat.com/1056965
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
A backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/utils/exclude-filters.xml
M backend/manager/modules/utils/pom.xml
A backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java
M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml
M backend/manager/modules/utils/src/test/resources/osinfo.conf.d/00-osinfo-test.properties
M pom.xml
11 files changed, 321 insertions(+), 5 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: aaa: Pass password across filters so it will be known during...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Pass password across filters so it will be known during LoginUserCommand
......................................................................
aaa: Pass password across filters so it will be known during LoginUserCommand
As basic authentication passed auth record to Login filter, the passsword
used for authentication was not passed, hence was not set in the session data container.
Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2
Bug-Url: https://bugzilla.redhat.com/1141541
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
(cherry picked from commit 3d4c423269b8dd099b2fe4bce43b0d2efa6f9e33)
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java
4 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 1 month