June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid connect to the same target multiple times
by laravot＠redhat.com 23 Jun '14

23 Jun '14

Liron Aravot has submitted this change and it was merged. Change subject: core: avoid connect to the same target multiple times ...................................................................... core: avoid connect to the same target multiple times When querying for the storage server connections of a VG, there's no need to return the same connection multiple times if the it's the same to avoid multiple operations on engine and on vdsm side. As we currently have one session for target, so this shouldn't cause to regression while eliminating unneeded operations. before: ------- engine: START, ConnectStorageServerVDSCommand connectionList = [{ id: 1212f182-9593-4cef-8c98-a3e99bf29fa2... }; { id: 1212f182-9593-4cef-8c98-a3e99bf29fa2... }; { id: 1212f182-9593-4cef-8c98-a3e99bf29fa2, ... };]), vdsm: Run and protect: connectStorageServer, Return response: {'statuslist': [{'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}, {'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}, {'status': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}]} after: ------- engine: connectionList = [{ id: 1212f182-9593-4cef-8c98-a3e99bf29fa2, ..};]) vdsm: Run and protect: connectStorageServer, Return response: {'statuslist': [{'stat us': 0, 'id': '1212f182-9593-4cef-8c98-a3e99bf29fa2'}]} Change-Id: If40ef468dc4eca4237ad824dc81aa39a90cce017 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1111994 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/storages_san_sp.sql 4 files changed, 31 insertions(+), 3 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If40ef468dc4eca4237ad824dc81aa39a90cce017 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.3]: packaging: setup: less strict parsing of pg_hba.conf
by ydary＠redhat.com 23 Jun '14

23 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: less strict parsing of pg_hba.conf ...................................................................... packaging: setup: less strict parsing of pg_hba.conf In addition to I374d578735c910451bc7698444a446728b33fd58, also use a regexp for matching the 'engine' lines. Change-Id: If43df5c1e22cd02a3ccd88acb36d35e1abbc6322 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 46 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If43df5c1e22cd02a3ccd88acb36d35e1abbc6322 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: map auth record just before fetch principal
by yzaslavs＠redhat.com 22 Jun '14

22 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: map auth record just before fetch principal ...................................................................... aaa: map auth record just before fetch principal this is required so we always map the auth record regardless of how it was constructed. Topic: AAA Change-Id: I73851ccb7594107baa98d32917f2b47318c7bb32 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 17 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73851ccb7594107baa98d32917f2b47318c7bb32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bll: LoginBaseCommand: remove unneeded indent
by yzaslavs＠redhat.com 22 Jun '14

22 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: bll: LoginBaseCommand: remove unneeded indent ...................................................................... bll: LoginBaseCommand: remove unneeded indent if the pattern is return as soon as error is detected, there is no reason to indent success. Topic: AAA Change-Id: Icc79f40102327ae6ba02558758a067a0a3104121 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java 1 file changed, 73 insertions(+), 75 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc79f40102327ae6ba02558758a067a0a3104121 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: return principal record only if success
by yzaslavs＠redhat.com 22 Jun '14

22 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: return principal record only if success ...................................................................... aaa: return principal record only if success Topic: AAA Change-Id: I6d07f137ac7a51b1638ad31a66ff54d0a521f812 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d07f137ac7a51b1638ad31a66ff54d0a521f812 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: rework nego filter to make it actually work
by yzaslavs＠redhat.com 22 Jun '14

22 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: rework nego filter to make it actually work ...................................................................... aaa: rework nego filter to make it actually work Topic: AAA Change-Id: Ice5a5720cff24fd8c4e88b68b883ae7d8f22d1eb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 1 file changed, 80 insertions(+), 87 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice5a5720cff24fd8c4e88b68b883ae7d8f22d1eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix typo
by yzaslavs＠redhat.com 22 Jun '14

22 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix typo ...................................................................... aaa: fix typo Topic: AAA Change-Id: If027ac2484e2f8372ee303181ac16aa7a677810f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If027ac2484e2f8372ee303181ac16aa7a677810f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: style for discover button in DiscoverTargetsView
by derez＠redhat.com 22 Jun '14

22 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: style for discover button in DiscoverTargetsView ...................................................................... webadmin: style for discover button in DiscoverTargetsView * Added a style for 'Discover Targets' button (to override default style). * Amended style of the message label. Change-Id: I06aadea871fb9b3c7edf613f78503c09a93de3d1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/29030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06aadea871fb9b3c7edf613f78503c09a93de3d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: change the length tooltip of QoS's name
by gchaplik＠redhat.com 22 Jun '14

22 Jun '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: change the length tooltip of QoS's name ...................................................................... webadmin: change the length tooltip of QoS's name The length tooltip of QoS's name is not correct now. The length of name field in the database(network_qos table) is 50. But the tooltip tells the length is 255. This patch fix the problem. It modify the tooltip, make it to show the correct message (i.e. under 50 characters). Change-Id: Ic9cb4e40dfc213016a819866baccba40529bd270 Bug-Url: https://bugzilla.redhat.com/1105010 Signed-off-by: Ma Like <like.ma(a)cs2c.com.cn> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 5 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9cb4e40dfc213016a819866baccba40529bd270 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Malike <like.ma(a)cs2c.com.cn> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Engine: Wrong case for Sysprep UiLanguage
by ofrenkel＠redhat.com 22 Jun '14

22 Jun '14

Omer Frenkel has submitted this change and it was merged. Change subject: Engine: Wrong case for Sysprep UiLanguage ...................................................................... Engine: Wrong case for Sysprep UiLanguage The replace of "$UiLangues$" in SysprepHandler is skipped because of the wrong case (should be UILanguage) Also setting the $SetupUiLanguageUiLanguage$ to UILanguage. Change-Id: Iaf4a37e4607af7238076050213b9c5c5b6914b74 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4a37e4607af7238076050213b9c5c5b6914b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0