Change in ovirt-engine[master]: backend: Make several entities implement Nameable
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Make several entities implement Nameable
......................................................................
backend: Make several entities implement Nameable
Change-Id: Icaa0e531e88f041f28645c6892f651d93a5aed18
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileStats.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
7 files changed, 22 insertions(+), 7 deletions(-)
Approvals:
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaa0e531e88f041f28645c6892f651d93a5aed18
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: frontend: Fix Permissions.id value on instance creattion
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: frontend: Fix Permissions.id value on instance creattion
......................................................................
core: frontend: Fix Permissions.id value on instance creattion
1. Reverts setting Permissions.id to Guid.Empty introduced in patch
I35aad0115394fde0bf30a27b3eb47c46496bd821.
2. It sets Permission.id to Guid.Empty in GWT code, because correct id
is set in AddPermissionCommand
Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Bug-Url: https://bugzilla.redhat.com/1195119
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java
4 files changed, 25 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: Fix naming convetions in Role class
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Fix naming convetions in Role class
......................................................................
core: Fix naming convetions in Role class
Change-Id: Id6059e75461d8c3bb120dc1cc911fe0ec0670da3
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRoleCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRolesQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RolesCommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendRoleResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RoleMapper.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/IsLockedImageTypeColumn.java
19 files changed, 63 insertions(+), 63 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/38548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6059e75461d8c3bb120dc1cc911fe0ec0670da3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: core: frontend: Fix Permissions.id value on instance creattion
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: frontend: Fix Permissions.id value on instance creattion
......................................................................
core: frontend: Fix Permissions.id value on instance creattion
1. Reverts setting Permissions.id to Guid.Empty introduced in patch
I35aad0115394fde0bf30a27b3eb47c46496bd821.
2. It sets Permission.id to Guid.Empty in GWT code, because correct id
is set in AddPermissionCommand
Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Bug-Url: https://bugzilla.redhat.com/1195119
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java
4 files changed, 25 insertions(+), 11 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38575
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: core: fix tests
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix tests
......................................................................
core: fix tests
This fixes a test regression occurred while [1] was merged after [2] has
successful tests and was rebased and merged
[1] https://gerrit.ovirt.org/#/c/36946/
[2] https://gerrit.ovirt.org/#/c/38459/
Change-Id: I140abf53675a945088f75d671a4f48179fc5ab0d
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I140abf53675a945088f75d671a4f48179fc5ab0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: packaging: setup: fixing action_type type
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: fixing action_type type
......................................................................
packaging: setup: fixing action_type type
action_type is retourned from the DB as an int but we need a string
for use it as a key for the decription map.
casting it.
Change-Id: Ic309c9ac4badc8ace307f32cd01ca03adb7ced2e
Bug-Url: https://bugzilla.redhat.com/1161012
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic309c9ac4badc8ace307f32cd01ca03adb7ced2e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 3 months
Change in ovirt-engine[master]: webadmin: avoid sending an empty ManageNetworkClusteers command
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: avoid sending an empty ManageNetworkClusteers command
......................................................................
webadmin: avoid sending an empty ManageNetworkClusteers command
Avoid sending an empty ManageNetworkClusteers command if user choose
not to attach the new network to a cluster.
Change-Id: If0744c499a6034c92aad1072daa7442e51a7d984
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
1 file changed, 19 insertions(+), 13 deletions(-)
Approvals:
Lior Vernia: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/38209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0744c499a6034c92aad1072daa7442e51a7d984
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Clear eclipse warnings in AsyncTaskManager * Removed...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Clear eclipse warnings in AsyncTaskManager * Removed dead code * Remove useless warning suppress * Instantiate map with <>
......................................................................
engine: Clear eclipse warnings in AsyncTaskManager
* Removed dead code
* Remove useless warning suppress
* Instantiate map with <>
Change-Id: I768f57466b117a289e238221933f6a262d7b64e3
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java
1 file changed, 1 insertion(+), 10 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38515
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I768f57466b117a289e238221933f6a262d7b64e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: The name argument is ignored and removed
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: The name argument is ignored and removed
......................................................................
engine: The name argument is ignored and removed
There is no consideration of the name argument which
is passed to the CacheWrapper.
Change-Id: I9d25fd8c6afbd8e508f2d696e0edbebd2aa0aac4
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java
3 files changed, 5 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d25fd8c6afbd8e508f2d696e0edbebd2aa0aac4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: engine: Add argument type to CommandBase
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Add argument type to CommandBase
......................................................................
engine: Add argument type to CommandBase
Change-Id: I4beea9713e8554588cc6d6f0300ab213f53b731b
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38522
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4beea9713e8554588cc6d6f0300ab213f53b731b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months