March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add type argument to Provider
by masayag＠redhat.com 11 Mar '15

11 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add type argument to Provider ...................................................................... engine: Add type argument to Provider Change-Id: I6a470467df12b9851dcedc30106caf26d898f696 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a470467df12b9851dcedc30106caf26d898f696 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change rsdl target argument to iscsi_target
by juan.hernandez＠redhat.com 11 Mar '15

11 Mar '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Change rsdl target argument to iscsi_target ...................................................................... core: Change rsdl target argument to iscsi_target Change rsdl optional argument name for unregisteredstoragedomainsdiscover from target to iscsi_target so the request will be consistent with the rsdl. Change-Id: Ib89b1912ea631e4bbdf4699c6ade22d530ddebd6 Bug-Url: https://bugzilla.redhat.com/1200483 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib89b1912ea631e4bbdf4699c6ade22d530ddebd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add type argument to Provider
by masayag＠redhat.com 11 Mar '15

11 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add type argument to Provider ...................................................................... engine: Add type argument to Provider Change-Id: I579d4f865194ac859c61b4dc8d78cef543779317 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I579d4f865194ac859c61b4dc8d78cef543779317 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Removed useless warning suppression
by masayag＠redhat.com 11 Mar '15

11 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Removed useless warning suppression ...................................................................... engine: Removed useless warning suppression Change-Id: Ia125c5f1a73212817bdbce8398b16858cb793c5e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetProviderByIdQuery.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia125c5f1a73212817bdbce8398b16858cb793c5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add generated serial version id for the exception
by masayag＠redhat.com 11 Mar '15

11 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add generated serial version id for the exception ...................................................................... engine: Add generated serial version id for the exception Change-Id: I88e0ab80860b2e560ddb5a1804b5e946abbbfc22 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageException.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e0ab80860b2e560ddb5a1804b5e946abbbfc22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-portals[master]: added reference to oVirtDash sample portal
by ecohen＠redhat.com 10 Mar '15

10 Mar '15

Einav Cohen has submitted this change and it was merged. Change subject: added reference to oVirtDash sample portal ...................................................................... added reference to oVirtDash sample portal Change-Id: I5c0e54652d89d811d24158153b336d82f0b8d0d3 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A javascript/oVirtDash/README.md 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0e54652d89d811d24158153b336d82f0b8d0d3 Gerrit-PatchSet: 1 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Quering FCP unregistered Storage Domains
by mlipchuk＠redhat.com 10 Mar '15

10 Mar '15

Maor Lipchuk has submitted this change and it was merged. Change subject: restapi: Quering FCP unregistered Storage Domains ...................................................................... restapi: Quering FCP unregistered Storage Domains Adding the possibility to execute a query to get all the unregistered storage domain of FCP. If the user does not apply an iscsi address in the request the REST query for unregistered Storage Domains of FCP type. Change-Id: Iafe2f2afcd0e6e68adbbbb2054c857388acc30a7 Bug-Url: https://bugzilla.redhat.com/1200513 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 2 files changed, 14 insertions(+), 8 deletions(-) Approvals: Ori Liel: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/38512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafe2f2afcd0e6e68adbbbb2054c857388acc30a7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: infra: Alert/Abandon old Gerrit patches Any patch with no ac...
by eedri＠redhat.com 10 Mar '15

10 Mar '15

Eyal Edri has submitted this change and it was merged. Change subject: infra: Alert/Abandon old Gerrit patches Any patch with no activity for 30 days send an email to author and cc all parties. If author not from RedHat cc iheim@ and bazulay@ by default. ...................................................................... infra: Alert/Abandon old Gerrit patches Any patch with no activity for 30 days send an email to author and cc all parties. If author not from RedHat cc iheim@ and bazulay@ by default. Any patch with no activity for 60 days abandoned with comment "Abandoned due to no activity - please restore if still relevant". Usage: alert_old_patches.py [-h] [--server SERVER] [--port PORT] [--user USER] [--key KEY] [--mail MAIL] [--cc CC [CC ...]] [--warning-days-limit WARNING_DAYS] [--abandon-days-limit ABANDON_DAYS] [--dry-run] projects [projects ...] Positional arguments: projects List of projects Optional arguments: --server SERVER Gerrit server, default: gerrit.ovirt.org --port PORT SSH Port,default: 29418 --user USER SSH User, default: $USER --key KEY SSH Key file path --mail MAIL Mail server, default: localhost --warning-days-limit WARNING_DAYS Number of days, default: 30 --abandon-days-limit ABANDON_DAYS Number of days, default 60 --dry-run Dry run --cc CC [CC ...] CC mail id's for non-redhat emails, default iheim@, bazulay@ Example: alert_old_patches.py vdsm ovirt-engine alert_old_patches.py --user alice --key ~/alice_rsa vdsm ovirt-engine Changelog: Use a global variable for the ssh command + common options. Updated all the email addresses as given in Code-review-1. Use argparse for command line options. Print return code, error and output on failures. Fixed the formatting issues with print statements. Removed all un-used global variable declarations. Specified exception type in except statements. Removed heading and trailing white spaces from doc string. Fixed all the issues given in Code-review-7. Updated the module docstring explaining what the script does. Use lowercase names for non-constant variables. Send email to owner for abandoned patches. Add an option for dry run. Add command line options to specify warning and abandon days limit. Signed-off-by: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> Change-Id: Ic911411a61e097c734d0199cc04057c393b974f9 --- M scripts/alert_old_patches.py 1 file changed, 163 insertions(+), 51 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved Vishnu Sreekumar: Verified -- To view, visit https://gerrit.ovirt.org/37426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic911411a61e097c734d0199cc04057c393b974f9 Gerrit-PatchSet: 16 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com>

1 0

Change in ovirt-engine[master]: aaa: Fix build error in SessionDataContainer
by ahadas＠redhat.com 10 Mar '15

10 Mar '15

Arik Hadas has submitted this change and it was merged. Change subject: aaa: Fix build error in SessionDataContainer ...................................................................... aaa: Fix build error in SessionDataContainer Could not compare "incomparable types: Object and long" Change-Id: I7b851feedb04fc5362afc6c91d63e8008fd2f1cc Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Betak: Verified Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b851feedb04fc5362afc6c91d63e8008fd2f1cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: ignore wait for async task on dev env
by sbonazzo＠redhat.com 10 Mar '15

10 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: ignore wait for async task on dev env ...................................................................... packaging: setup: ignore wait for async task on dev env Ignoring waiting for async task on dev env upgrades Change-Id: I1fed22db60dd376499a6c3c4ad28bb080069f0cd Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fed22db60dd376499a6c3c4ad28bb080069f0cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0