March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: convert LabelWithTextTruncation to use...
by awels＠redhat.com 11 Mar '15

11 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: convert LabelWithTextTruncation to use PatternFly tooltips ...................................................................... userportal, webadmin: convert LabelWithTextTruncation to use PatternFly tooltips (Patch 3 of 12) Renamed LabelWithTextOverflow --> LabelWithTextTruncation. "overflow" has a very specific meaning in CSS, and what is actually happening in this Label is "truncation." Added WidgetTooltip. Converted LabelWithTextTruncation to use PatternFly tooltips. Change-Id: I4c22d5003c26ef2df418d2df7c76af009ab383e4 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTextTruncation.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkLabelPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java 6 files changed, 81 insertions(+), 44 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c22d5003c26ef2df418d2df7c76af009ab383e4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: new tooltip infrastructure
by awels＠redhat.com 11 Mar '15

11 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: new tooltip infrastructure ...................................................................... userportal, webadmin: new tooltip infrastructure (Patch 2 of 12) New tooltip infrastructure that works with Element, Cells, and Widgets. Uses PatternFly tooltips for rendering. Change-Id: Ie60ebe16e2d8830498fd819ffdb39aa043daadd2 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/JqueryUtils.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TooltipCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractColumn.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageResourceCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/ElementTooltipDetails.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/Tooltip.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipConfig.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipMixin.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/TooltipCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn2.java A packaging/branding/ovirt.brand/mousetrack.js M packaging/branding/ovirt.brand/ovirt.css 17 files changed, 2,022 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/36597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60ebe16e2d8830498fd819ffdb39aa043daadd2 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: switch to GwtBootstrap3CDN module
by awels＠redhat.com 11 Mar '15

11 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: switch to GwtBootstrap3CDN module ...................................................................... userportal, webadmin: switch to GwtBootstrap3CDN module (Patch 1 of 12) Switched to GwtBootstrap3CDN module from which to inherit gwt-common, userportal, and and webadmin. Previously used GwtBootstrap3NoTheme. The effect of this change is to stop gwtbootstrap3 from injecting jquery.js and bootstrap.js. As we move to a move modular UI, we have decided to control JavaScript and CSS assets outside of GWT as much as possible. If we want to support a newer version of jquery in the future (for, say, UI plugin usage), we won't be tied to the version that ships with gwtbootstrap3. Added bootstrap.min.js and jquery.min.js includes in javascripts.tag to replace the gwtbootstrap3-injected copies of bootstrap.js and jquery.js. Also added patternfly.min.js, which is not currently required but is useful. It includes script for a few PatternFly widgets that we do not yet use. Change-Id: I77f50562ea8bc67f59246eb68a17f87584a5fd9b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38554 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77f50562ea8bc67f59246eb68a17f87584a5fd9b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add missing type argument
by oourfali＠redhat.com 11 Mar '15

11 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add missing type argument ...................................................................... engine: Add missing type argument Change-Id: Ie01a2a2dd51f38d438c780f5010b81fdd72cbd70 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/CommandMocks.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01a2a2dd51f38d438c780f5010b81fdd72cbd70 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add serial version id to InvalidQuotaParametersExcep...
by oourfali＠redhat.com 11 Mar '15

11 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add serial version id to InvalidQuotaParametersException ...................................................................... engine: Add serial version id to InvalidQuotaParametersException Change-Id: I59c47231cc23a37fc8abdc2cc854d35e20488cdd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59c47231cc23a37fc8abdc2cc854d35e20488cdd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: core: Set Guid.EMPTY to Permissions.id by default
by oourfali＠redhat.com 11 Mar '15

11 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set Guid.EMPTY to Permissions.id by default ...................................................................... core: Set Guid.EMPTY to Permissions.id by default Sets Guid.EMPTY to Permissions.id by default when creating new instance because: 1. Guid.newGuid() cannot be used in frontend code, because it call UUID.randomUUID() which is not supported in GWT 2. In AddPermission command there's always assigned Guid.newGuid() into Permissions.id for created permissions. Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Bug-Url: https://bugzilla.redhat.com/1195119 Signed-off-by: Martin Perina <mperina(a)redhat.com> (cherry picked from commit f3c71e1197a0ea1906539162ae19057ff4021b3d) (cherry picked from commit f877373820ba64d39497f23f39015fe186a7bff9) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set Guid.EMPTY to Permissions.id by default
by oourfali＠redhat.com 11 Mar '15

11 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set Guid.EMPTY to Permissions.id by default ...................................................................... core: Set Guid.EMPTY to Permissions.id by default Sets Guid.EMPTY to Permissions.id by default when creating new instance because: 1. Guid.newGuid() cannot be used in frontend code, because it call UUID.randomUUID() which is not supported in GWT 2. In AddPermission command there's always assigned Guid.newGuid() into Permissions.id for created permissions. Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Bug-Url: https://bugzilla.redhat.com/1195119 Signed-off-by: Martin Perina <mperina(a)redhat.com> (cherry picked from commit f3c71e1197a0ea1906539162ae19057ff4021b3d) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Set Guid.EMPTY to Permissions.id by default
by oourfali＠redhat.com 11 Mar '15

11 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set Guid.EMPTY to Permissions.id by default ...................................................................... core: Set Guid.EMPTY to Permissions.id by default Sets Guid.EMPTY to Permissions.id by default when creating new instance because: 1. Guid.newGuid() cannot be used in frontend code, because it call UUID.randomUUID() which is not supported in GWT 2. In AddPermission command there's always assigned Guid.newGuid() into Permissions.id for created permissions. Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Bug-Url: https://bugzilla.redhat.com/1195119 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35aad0115394fde0bf30a27b3eb47c46496bd821 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Remove useless injected dao
by masayag＠redhat.com 11 Mar '15

11 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove useless injected dao ...................................................................... engine: Remove useless injected dao The injected dao isn't being used within this been, hence it should be removed. Change-Id: Ida1b0803fe94cac38120788af9ef7b78de4d1a6d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterPermissionsChecker.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/38531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida1b0803fe94cac38120788af9ef7b78de4d1a6d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: load only managed device payload on run vm
by ofrenkel＠redhat.com 11 Mar '15

11 Mar '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: load only managed device payload on run vm ...................................................................... core: load only managed device payload on run vm run vm command loads the vm payload from the devices in order to send it to vdsm. we should only load devices that are managed, as unmanaged devices were not created in the engine or not meant to be persisted and sent on later runs. Change-Id: Icc0c1876228d9b8cc72cb5698b8d8f12135594d0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1190696 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Omer Frenkel: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc0c1876228d9b8cc72cb5698b8d8f12135594d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0