Change in ovirt-engine[master]: engine: Remove class-level variable managementNetwork
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove class-level variable managementNetwork
......................................................................
engine: Remove class-level variable managementNetwork
The variable managementNetwork isn't being used within
the class. Instead a local variable named the same is
used. Hence the class level variable can be removed.
Change-Id: If189a24c1a52af6e8f654739984912efdd0706e7
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/38532
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If189a24c1a52af6e8f654739984912efdd0706e7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Add diamond type declaration
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add diamond type declaration
......................................................................
engine: Add diamond type declaration
Change-Id: I3b756ac1f2163cd04d835382166c08c1ea8f943a
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/38528
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b756ac1f2163cd04d835382166c08c1ea8f943a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Replace warnings suppress with proper matcher
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Replace warnings suppress with proper matcher
......................................................................
engine: Replace warnings suppress with proper matcher
anySetOf(Class) eliminates the need to suppress type check.
Change-Id: I4948c743dcfe22330e22591bab385d6fd9f3f35f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java
1 file changed, 6 insertions(+), 10 deletions(-)
Approvals:
Sahina Bose: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/38537
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4948c743dcfe22330e22591bab385d6fd9f3f35f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: determine whether domain monitoring result is actual
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: determine whether domain monitoring result is actual
......................................................................
core: determine whether domain monitoring result is actual
When the domain monitoring results are reported back from vdsm, the
first monitor run may haven't finished yet. In that case the returned
status from vdsm is a dummy status and not an actual result.
The non actual status could lead to a wrong decision making on the engine
status (for example - decide that an inactive domain is now active).
This patch uses the logic added on vdsm side (change I1fea5) to inspect
whether the reported status is actual or not.
For earlier version that doesn't return that info, each returned report
will be considered as actual to leave the behavior as it was.
Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1183977
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSDomainsData.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
9 files changed, 61 insertions(+), 21 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38039
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddbba94d81694bd6cb1ce3648872eb81182a50ab
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: restapi, core: Enabling disk's description edit when adding a...
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: restapi,core: Enabling disk's description edit when adding a new template.
......................................................................
restapi,core: Enabling disk's description edit when adding a new template.
Currently when adding a new template the user is able to change the
template's disk's alias.
Editing the disk's description looks natural to edit to the user
along editing the alias, and also seems to be a relevant use case
when adding a new template.
This patch adds the possibility to also edit the disk's description.
Change-Id: Ic68114c072565ad2d0938fc0256448da9bce0910
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
3 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
Objections:
oVirt Jenkins CI Server: Fails
--
To view, visit https://gerrit.ovirt.org/38290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic68114c072565ad2d0938fc0256448da9bce0910
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Sync geo-rep config information
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Sync geo-rep config information
......................................................................
engine: Sync geo-rep config information
Added method to update database with CLI
information for geo-replication configuration
Removed the constraint that discovered georep keys
needs to be present in config master.
Handled possible null default values for config
Change-Id: I0ee0bc7e916df3becfc99b701de8a0c9e95e2a4d
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionConfiguration.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionInfo.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/gluster_georep_sp.sql
A packaging/dbscripts/upgrade/03_06_0990_georep_drop_constraint_config_key.sql
12 files changed, 179 insertions(+), 18 deletions(-)
Approvals:
Sahina Bose: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ee0bc7e916df3becfc99b701de8a0c9e95e2a4d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: gluster: Corrected VDS commands as per latest VDSM verbs
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Corrected VDS commands as per latest VDSM verbs
......................................................................
gluster: Corrected VDS commands as per latest VDSM verbs
Corrected error codes, parameters etc for VDS commands as per
latest VDSM verbs changes.
Change-Id: Ief9bcdf7d05f5d4e0bb54a3163ec27c57ccf81e0
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ActivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeactivateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJobTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterSnapshotStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeSnapshotConfigInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotConfigReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeSnapshotInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterVolumeSnapshotStatusCell.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
18 files changed, 73 insertions(+), 66 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief9bcdf7d05f5d4e0bb54a3163ec27c57ccf81e0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: do not use distinct if sort expr have func
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: do not use distinct if sort expr have func
......................................................................
core: do not use distinct if sort expr have func
A former patch made by Omer F added distinct to the search in order to
prevent duplicates.
In the case the search is in the format :
SELECT DISTINCT * FROM T .... ORDER BY f({arguments})
There is a problem since the DISTINCT is performed first and then the
sorting, so f is unknown since it is not part of the result set.
This patch checks if the sort clause has a function call and removes the
DISTINCT if it finds one.
Also added a unit test for this case.
Change-Id: I7c036b2b9ee94266b6e3df54f2c50167e454ed6a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198506
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Eli Mesika: Verified
Omer Frenkel: Looks good to me, approved
Liran Zelkha: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c036b2b9ee94266b6e3df54f2c50167e454ed6a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core:enable to filter by search query and user
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core:enable to filter by search query and user
......................................................................
core:enable to filter by search query and user
This patch adds support for user search queries that considers both the
search expression as given by the user and the filtering that should
apply in order to cope with user permissions.
This is done by doing the regular filtering query (SP) followed by the
search query (without filtering) , then the intersection of this two
results is returned.
Change-Id: Ic8beef0abbac999e49a726f1fecd9bcabec2a923
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163105
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/externalhostproviders/BackendExternalHostProvidersResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResourceTest.java
13 files changed, 66 insertions(+), 21 deletions(-)
Approvals:
Eli Mesika: Verified
Juan Hernandez: Looks good to me, approved
Liran Zelkha: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/35374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8beef0abbac999e49a726f1fecd9bcabec2a923
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: core: Fix splitting logic for ip addresses
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Fix splitting logic for ip addresses
......................................................................
core: Fix splitting logic for ip addresses
This patch fixes broken sorting of IP address columns. There were 2
causes of the problem:
1, The problem reproduced when function received string of whitespaces or
list of more than one ip addresses (the list wasn't correctly split
and caused errors with 'inet' type cast). The cause is non-duplicated
backslash when specifying pattern.
Fixed by adding duplicated backslash [1].
2, Previously, the constructed query looked like this:
(SELECT distinct vms.* FROM vms )
ORDER BY fn_get_comparable_ip_list(vm_ip) DESC NULLS LAST,vm_name ASC;
This is, however problematic since postgresql complains about missing
fn_get_comparable_ip_list(vm_ip) in SELECT clause.
This was fixed by adding a new field in vms and vms_with_tags views.
[1]: http://www.postgresql.org/docs/9.3/static/functions-matching.html
Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92
Bug-Url: https://bugzilla.redhat.com/1164235
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_views.sql
3 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Frank Kobzik: Verified
Omer Frenkel: Looks good to me, approved
Lior Vernia: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/36946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months