April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: get rid of StorageEnv.STORAGE_TYPE
by sbonazzo＠redhat.com 29 Apr '16

29 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: get rid of StorageEnv.STORAGE_TYPE ...................................................................... storage: get rid of StorageEnv.STORAGE_TYPE StorageEnv.STORAGE_TYPE just points to an empty useless variable. Using was causing a failure on additional gluster hosts. Change-Id: If1c196b0070fc00decfb5f53e2c2daf86f0f2c48 Bug-Url: https://bugzilla.redhat.com/1322729 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 3 files changed, 3 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c196b0070fc00decfb5f53e2c2daf86f0f2c48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: get rid of StorageEnv.STORAGE_TYPE
by sbonazzo＠redhat.com 29 Apr '16

29 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: get rid of StorageEnv.STORAGE_TYPE ...................................................................... storage: get rid of StorageEnv.STORAGE_TYPE StorageEnv.STORAGE_TYPE just points to an empty useless variable. Using was causing a failure on additional gluster hosts. Change-Id: If1c196b0070fc00decfb5f53e2c2daf86f0f2c48 Bug-Url: https://bugzilla.redhat.com/1322729 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 3 files changed, 3 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c196b0070fc00decfb5f53e2c2daf86f0f2c48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use System#arraycopy in tests
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use System#arraycopy in tests ...................................................................... restapi: Use System#arraycopy in tests Use System#arraycopy which should be a bit faster than manually copying arrays. Change-Id: I7132e4d5cdb15921f53fa505acdd34776ee4c45c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7132e4d5cdb15921f53fa505acdd34776ee4c45c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Redundant toString() calls
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Redundant toString() calls ...................................................................... restapi: Redundant toString() calls String#toString() just returns the string itself - therefore, these explicit toStirng() calls can safely be removed. Change-Id: I22b9a4b068e53db90b753175149b8aae6d121597 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAffinityGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendJobsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 14 files changed, 25 insertions(+), 25 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22b9a4b068e53db90b753175149b8aae6d121597 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Assert methods usage
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Assert methods usage ...................................................................... restapi: Assert methods usage Use the proper asserts with the proper order of arguments to improve test output readability in case of a test failure. Change-Id: I30d40ddf8bdb0c9e04ab8f9adf18aa3ceb5923b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEventsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmCdromResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmTagResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java 24 files changed, 38 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30d40ddf8bdb0c9e04ab8f9adf18aa3ceb5923b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendQuotaStorageLimitsResourceTest autoboxing
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: BackendQuotaStorageLimitsResourceTest autoboxing ...................................................................... restapi: BackendQuotaStorageLimitsResourceTest autoboxing Allow java to autobox the long value instead of explicitly calling new Long - it's redundant, and Java just does it better. Change-Id: I9d84c268c2b57310fb59df71049fe37741ab1b8f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResourceTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d84c268c2b57310fb59df71049fe37741ab1b8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Generic Lists in tests
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Generic Lists in tests ...................................................................... restapi: Generic Lists in tests Used generic specifications for Lists in test classes instead of using raw classes. Change-Id: I8d21411a712f5423ad2feb5e4b56c29eba3b087e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d21411a712f5423ad2feb5e4b56c29eba3b087e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Use String#contains
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use String#contains ...................................................................... restapi: Use String#contains Replaced usages on idexOf that just compare the return value to -1 with more intuitive contains calls. Change-Id: I741339bf31f60ba0a45f83a3d3fef3b73794596b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java 4 files changed, 4 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I741339bf31f60ba0a45f83a3d3fef3b73794596b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: RM BackendVmPoolsResourceTest#init
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: RM BackendVmPoolsResourceTest#init ...................................................................... restapi: RM BackendVmPoolsResourceTest#init Removed a redundant method that did nothing but delegate to the method it overrides. Change-Id: Id608dda79e37b5d5e9e8edf58d62f62afe44e478 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResourceTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id608dda79e37b5d5e9e8edf58d62f62afe44e478 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendSystemAssignedPermissionsResourceTest#testAd...
by juan.hernandez＠redhat.com 28 Apr '16

28 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: BackendSystemAssignedPermissionsResourceTest#testAddPermissions ...................................................................... restapi: BackendSystemAssignedPermissionsResourceTest#testAddPermissions As test methods are inherited from superclasses, having a method that does nothing but call the method it overrides is redundant, and can (and should!) be removed. Change-Id: I893b86102881edde4a05a64ff806c4a29706ef4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSystemAssignedPermissionsResourceTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/56783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I893b86102881edde4a05a64ff806c4a29706ef4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0