- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Allow skipping vm command execution
by ofrenkel＠redhat.com 26 Nov '14

26 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Allow skipping vm command execution ...................................................................... core: Allow skipping vm command execution This patch adds an easy way to skip vm command execution, by overriding 'shouldSkipCommandExecution' method, we can mark the command not to run can-do-action and execute code. the command will just finish as succeeded and operation will be logged. in change-id: I75925d528cca52603660d5a7ec6c5c871304f3d0 there is an example of usage for the 'stop down vm' scenario. Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I290055f759afcc554d1f49fac12455ae18d2d194 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: skip execution of stop vm if its down
by ofrenkel＠redhat.com 26 Nov '14

26 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: skip execution of stop vm if its down ...................................................................... core: skip execution of stop vm if its down if vm is down, instead of failing in canDoAction, skip execution and notify the user in audit log. Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 24 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75925d528cca52603660d5a7ec6c5c871304f3d0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: better exception handling on APIs connection
by sbonazzo＠redhat.com 26 Nov '14

26 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: better exception handling on APIs connection ...................................................................... packaging: setup: better exception handling on APIs connection Better handling of APIs connection errors better discriminating and reporting them. Adding some debug log lines. Bug-Url: https://bugzilla.redhat.com/1168267 Change-Id: I13a286ffaac955b821de830a4562413ee071c860 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 31 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13a286ffaac955b821de830a4562413ee071c860 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: packaging: bump version to 0.4.3
by alitke＠redhat.com 26 Nov '14

26 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: packaging: bump version to 0.4.3 ...................................................................... packaging: bump version to 0.4.3 Change-Id: I1178233cfc0f0d56615f867efe04e4c58ba2ce41 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35588 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Adam Litke: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1178233cfc0f0d56615f867efe04e4c58ba2ce41 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: prevent persistence of runtime NUMA info
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: prevent persistence of runtime NUMA info ...................................................................... core: prevent persistence of runtime NUMA info NUMA runtime info is shown wrongfully (bug 1100202), also causes double pinning on the same node (bug fix). This patch removes the persistence of NUMA runtime info, till it gets resolved. Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681 Bug-Url: https://bugzilla.redhat.com/1147880 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: unset DisconnectDwh on failure
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: unset DisconnectDwh on failure ...................................................................... packaging: setup: unset DisconnectDwh on failure Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Bug-Url: https://bugzilla.redhat.com/1168160 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 7348799e9dcd38b5bc974debaa96be85d116c559) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: tpgt should not be sent when empty
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: tpgt should not be sent when empty ...................................................................... core: tpgt should not be sent when empty Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer. I.e. 'tpgt' is optional, but if specified, it must be an integer. Vdsm API: " {'type': 'IscsiConnectionParameters', 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int', '*iface': 'str', '*credentials': 'IscsiCredentials'}} @tpgt: #optional The Target Portal Group Tag to use " Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Bug-Url: https://bugzilla.redhat.com/1160785 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: fix fn_db_add_config_value_for_versions_up_to
by emesika＠redhat.com 26 Nov '14

26 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: db: fix fn_db_add_config_value_for_versions_up_to ...................................................................... db: fix fn_db_add_config_value_for_versions_up_to The FOREACH keyword used in the function is not compatible with PG 8.x and was replaced with a FOR loop that is supported for both 8.x and 9.x Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: unset DisconnectDwh on failure
by sbonazzo＠redhat.com 26 Nov '14

26 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: unset DisconnectDwh on failure ...................................................................... packaging: setup: unset DisconnectDwh on failure Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Bug-Url: https://bugzilla.redhat.com/1168160 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09083bc79ead4711a7a998fab112c58ef80b0b4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Fix calculation of score for gateway and bridge problems.
by msivak＠redhat.com 26 Nov '14

26 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix calculation of score for gateway and bridge problems. ...................................................................... Fix calculation of score for gateway and bridge problems. Because wrong casting lm['gateway'] and lm['bridge'] always received True value. Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Bug-Url: https://bugzilla.redhat.com/1164557 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0