- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Fix calculation of score for gateway and bridge problems.
by msivak＠redhat.com 26 Nov '14

26 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: Fix calculation of score for gateway and bridge problems. ...................................................................... Fix calculation of score for gateway and bridge problems. Because wrong casting lm['gateway'] and lm['bridge'] always received True value. Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Bug-Url: https://bugzilla.redhat.com/1164557 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750ef496ae1983be20b9bd61d5757fc37ba39b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: tpgt should not be sent when empty
by derez＠redhat.com 26 Nov '14

26 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: tpgt should not be sent when empty ...................................................................... core: tpgt should not be sent when empty Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer. I.e. 'tpgt' is optional, but if specified, it must be an integer. Vdsm API: " {'type': 'IscsiConnectionParameters', 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int', '*iface': 'str', '*credentials': 'IscsiCredentials'}} @tpgt: #optional The Target Portal Group Tag to use " Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Bug-Url: https://bugzilla.redhat.com/1160785 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: update vm version for pool-vm
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: update vm version for pool-vm ...................................................................... core: update vm version for pool-vm When pool-vm is started by admin, it is not attached to any user, nor doest it have a stateless snapshot. so in this case, the logic that check if new version exists is skipped. this patch calls restoreStatelessSnapshot (that contains the new version logic) also to pool vms that are not attached to any user. Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167102 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix Live Merge recovery with JSON-RPC hosts
by tnisan＠redhat.com 26 Nov '14

26 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix Live Merge recovery with JSON-RPC hosts ...................................................................... core: Fix Live Merge recovery with JSON-RPC hosts JSON-RPC calls to the reconcileVolumeChain verb were not done correctly, causing recovery to fail if live merge was interrupted by e.g. host shutdown during the merge operation. Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Bug-Url: https://bugzilla.redhat.com/1161127 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New ...
by oourfali＠redhat.com 26 Nov '14

26 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog ...................................................................... webadmin: [fr_FR][ja_JP][Admin Portal] Misalignment in 'New Host' dialog Misalignment in New Host Dialog in jp_JP and fr_FR locales Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Bug-Url: https://bugzilla.redhat.com/1123324 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 23 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id69a2a6146a1827168721071e79583d42ba9b58e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: agent: handle malformed metadata better
by msivak＠redhat.com 26 Nov '14

26 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: agent: handle malformed metadata better ...................................................................... agent: handle malformed metadata better Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158925 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit cc5a96957fdc0b5c6ab59ceb26a9c5aa50614312) --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC)
by lvernia＠redhat.com 25 Nov '14

25 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC) ...................................................................... webadmin: Coverity CID 1201953 (FB.SIC_INNER_SHOULD_BE_STATIC) Changed EmptyColumn to a static inner class, as Coverity advised. Change-Id: I46528182dc5a526367086af250611a6f3ae530e5 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46528182dc5a526367086af250611a6f3ae530e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Push ioTune QoS info when hotplugging disk
by tnisan＠redhat.com 25 Nov '14

25 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Push ioTune QoS info when hotplugging disk ...................................................................... core: Push ioTune QoS info when hotplugging disk This adds the support for disk QoS for disks that are hotplugged while the VM is already running. Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Adding an existing block Storage Domain should be blocked
by tnisan＠redhat.com 25 Nov '14

25 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Adding an existing block Storage Domain should be blocked ...................................................................... core: Adding an existing block Storage Domain should be blocked Adding an existing Storage Domain should be blocked by a CDA message Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add lock when importing an exsiting block Storage Domain
by tnisan＠redhat.com 25 Nov '14

25 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add lock when importing an exsiting block Storage Domain ...................................................................... core: Add lock when importing an exsiting block Storage Domain Add memory lock while importing an existing block Storage Domain. Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0