- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: extapi: build: fix checkstyle plugin
by yzaslavs＠redhat.com 19 Nov '14

19 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extapi: build: fix checkstyle plugin ...................................................................... extapi: build: fix checkstyle plugin Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/extensions-api-root/extensions-api/checkstyle.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtMap.java M backend/manager/modules/extensions-api-root/pom.xml 4 files changed, 58 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f2f7b1f883faabdb28d9cd9cec3a577120f362 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Allow registerVds with same name and hostname if provisioned
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Allow registerVds with same name and hostname if provisioned ...................................................................... Allow registerVds with same name and hostname if provisioned Currently we delete the old vds record with InstallingOS status to allow adding new record as waiting for approval. This is wrong approach which causes lose of all the initial information that set on the vds record. With this fix we don't delete the record and skip the duplication check Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115343 Change-Id: I157b567b2c868b12a89a394e909e97895338380d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 19 insertions(+), 10 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I157b567b2c868b12a89a394e909e97895338380d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: sos: fix missing backport of add_alert
by sbonazzo＠redhat.com 19 Nov '14

19 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix missing backport of add_alert ...................................................................... sos: fix missing backport of add_alert fixes add_alert -> addAlert backport from sos 3.y to 2.y Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit a0e280011c1b8f310d24689f6ee1033deffb81b1) --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[master]: sos: fix missing backport of add_alert
by sbonazzo＠redhat.com 19 Nov '14

19 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix missing backport of add_alert ...................................................................... sos: fix missing backport of add_alert fixes add_alert -> addAlert backport from sos 3.y to 2.y Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3469fc13cfd1ece311476a5c1a5200f294763587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: reduced logging in Even distribution policy
by tnisan＠redhat.com 19 Nov '14

19 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: reduced logging in Even distribution policy ...................................................................... engine: reduced logging in Even distribution policy Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126839 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> (cherry picked from commit 7f74698b81b55156d9d779e9aff248cdf5064709) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Expose vm.auto_converge and vm.migrate_compressed p...
by juan.hernandez＠redhat.com 19 Nov '14

19 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Expose vm.auto_converge and vm.migrate_compressed properties ...................................................................... restapi: Expose vm.auto_converge and vm.migrate_compressed properties <vm> <migration> <auto_converge>true|false|inherit</auto_converge> <compressed>true|false|inherit</compressed> </migration> </vm> And similarly for <cluster> Change-Id: I9161896d1709c7492201667aa2c5955c5e37efd0 Signed-off-by: Martin Betak <mbetak(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151001 --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HasMigrationOptions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/InheritableBoolean.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ClusterValidator.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MigrationOptionsValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java M backend/manager/modules/restapi/types/exclude-filters.xml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/InheritableBooleanMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MigrationOptionsMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 18 files changed, 215 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/32133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9161896d1709c7492201667aa2c5955c5e37efd0 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Add support for auto-convergence and XBZRLE compre...
by tjelinek＠redhat.com 19 Nov '14

19 Nov '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Add support for auto-convergence and XBZRLE compression ...................................................................... frontend: Add support for auto-convergence and XBZRLE compression Added ListBox widgets for auto-convergence and migration compression in VM and Cluster dialogs. ListBoxes are used because values for auto-convergence and migration compression can be true/false/null where null signifies inheritance from higher-level configuration. Change-Id: Iff0c082dfddf22704a0ff26593b52f1385f342ea Signed-off-by: Martin Betak <mbetak(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151001 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/BooleanRendererWithNullText.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CoreVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 15 files changed, 192 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/32495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff0c082dfddf22704a0ff26593b52f1385f342ea Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: handle memory allignment when checking the balloon h...
by dfediuck＠redhat.com 19 Nov '14

19 Nov '14

Doron Fediuck has submitted this change and it was merged. Change subject: engine: handle memory allignment when checking the balloon health ...................................................................... engine: handle memory allignment when checking the balloon health Engine used to check if the ballooning works properly by comparing the target memory with the actual available memory and throws a warning if it doesn't match, the problem is when the requsted target memory value is not alligned. The system then returns the alligned memory and the engine thinks the balloon is not working, becuase the requested value != curent value. This patch changes the behaviour so it only checks if the current value is closer to the requested value than the previous value (in other words: if the current memory moves towards the requested target) Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Bug-Url: https://bugzilla.redhat.com/1120197 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBalloonInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VM dialog: combobox content trim in IE9 fix
by tjelinek＠redhat.com 19 Nov '14

19 Nov '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: VM dialog: combobox content trim in IE9 fix ...................................................................... webadmin: VM dialog: combobox content trim in IE9 fix IE9 wrongly calculates the width of element - it doesn't take scrollbar into accout. This causes the content to be shifted to the left and trimmed. Resetting 'overflow-y' css property to 'hidden' and back again prevents the left shift. Extending the element adds space for scrollbar. Change-Id: I203939fbf96b664280a50b98ca4a2baccec8325d Bug-Url: https://bugzilla.redhat.com/1160774 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java 1 file changed, 50 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified -- To view, visit http://gerrit.ovirt.org/35293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I203939fbf96b664280a50b98ca4a2baccec8325d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Adding auth and principal records on session
by oourfali＠redhat.com 19 Nov '14

19 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Adding auth and principal records on session ...................................................................... aaa: Adding auth and principal records on session Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163147 Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 2 files changed, 20 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0