- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bll: remove usage of RandomUtils
by tnisan＠redhat.com 19 Nov '14

19 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: bll: remove usage of RandomUtils ...................................................................... bll: remove usage of RandomUtils RandomUtils is a wrapper to non secure random of java that is not used nor required within runtime. implementation of random utils is way too complex than required and provided as a wrapper instead of utility. move class to tests. Change-Id: Id20da6d8eb93ebbd237d20705440c5e583fc486e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id20da6d8eb93ebbd237d20705440c5e583fc486e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Null check on domain volume group when attempting t...
by juan.hernandez＠redhat.com 19 Nov '14

19 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Null check on domain volume group when attempting to extend domain ...................................................................... restapi: Null check on domain volume group when attempting to extend domain When editing a block domain via REST, the LUN passed in the new entity can come either from the LUNs collection and in case it's empty from the volume group property and it's LUNs, added a null check on the volume group since when you do not provide LUNs it automatically falls back to volume group which might be null Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090 Bug-Url: https://bugzilla.redhat.com/1115966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com>restapi: --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "core: Store iSCSI Target Address instead of IP Addre...
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: Store iSCSI Target Address instead of IP Address in DB" ...................................................................... Revert "core: Store iSCSI Target Address instead of IP Address in DB" This reverts commit c6c9bdb239042ca0ab4543d154d5144740ba4379. The idea of working with the original address we get from the user instead of the IP address we get from VDSM works fine in case that the iscsi server has only one NIC. When it has more than one (Multipath, for example) the VDSM sends all the addresses it discovered, and we override all of them with the original address we got from the user. This makes the login to all of the other targets fail (except for the first one). Thus, working with the original address is not possible. Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1163948 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Objections: Nir Soffer: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/35295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: don't read external files in unit test
by awels＠redhat.com 18 Nov '14

18 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: engine: don't read external files in unit test ...................................................................... engine: don't read external files in unit test - Removed trying to read external files that should be there but in certain situations are not there. Modified it to just read files inside the source tree. Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/ServletUtilsTest.java A backend/manager/modules/utils/src/test/resources/mime.types 4 files changed, 24 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47db3324daf11a19cb76c3866a3f4e4152b9a3a1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cluster parameters override - scheduler \ actions \ qu...
by ofrenkel＠redhat.com 18 Nov '14

18 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cluster parameters override - scheduler \ actions \ queries ...................................................................... core: Cluster parameters override - scheduler \ actions \ queries This feature allows to configure the 'emulated machine' and 'cpu model' parameters for each VM separately instead of relying on the cluster default. Bug-Url: https://bugzilla.redhat.com/838487 Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSupportedCpuListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetSupportedCpuListParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java A packaging/dbscripts/upgrade/03_06_0550_add_cluster_parameters_override_policy_unit.sql 14 files changed, 289 insertions(+), 47 deletions(-) Approvals: Eldan Shachar: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cluster parameters override - OVF
by ofrenkel＠redhat.com 18 Nov '14

18 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cluster parameters override - OVF ...................................................................... core: Cluster parameters override - OVF This feature allows to configure the 'emulated machine' and 'cpu model' parameters for each VM separately instead of relying on the cluster default. Change-Id: Ib772f8674ffb5297fbdce25f2fcf1121851a9def Bug-Url: https://bugzilla.redhat.com/838487 Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 24 insertions(+), 0 deletions(-) Approvals: Eldan Shachar: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib772f8674ffb5297fbdce25f2fcf1121851a9def Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cluster parameters override - fields\db
by ofrenkel＠redhat.com 18 Nov '14

18 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cluster parameters override - fields\db ...................................................................... core: Cluster parameters override - fields\db This feature allows to configure the 'emulated machine' and 'cpu model' parameters for each VM separately instead of relying on the cluster default. Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40 Bug-Url: https://bugzilla.redhat.com/838487 Feature-page: http://www.ovirt.org/Features/Cluster_parameters_override Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidI18NExtraName.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0540_add_cluster_parameters_override_to_vm.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 23 files changed, 302 insertions(+), 28 deletions(-) Approvals: Eldan Shachar: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Store iSCSI Target Address instead of IP Addre...
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "core: Store iSCSI Target Address instead of IP Address in DB" ...................................................................... Revert "core: Store iSCSI Target Address instead of IP Address in DB" This reverts commit c6c9bdb239042ca0ab4543d154d5144740ba4379. The idea of working with the original address we get from the user instead of the IP address we get from VDSM works fine in case that the iscsi server has only one NIC. When it has more than one (Multipath, for example) the VDSM sends all the addresses it discovered, and we override all of them with the original address we got from the user. This makes the login to all of the other targets fail (except for the first one). Thus, working with the original address is not possible. Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1086310 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/35291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3974820e9039f05aa716752330c1b2ec13591137 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Create PairQueryable ID without UUID serialization
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Create PairQueryable ID without UUID serialization ...................................................................... core: Create PairQueryable ID without UUID serialization As it turns out, serializing a UUID is a resource-consuming operation, and is not in fact required to compute a unique ID for a PairQueryable object. The mechanism is therefore swapped for a more efficient one, while maintaining the form of the serialized ID (in case it is needed somewhere, though that does not seem to be the case). The new ID is represented by a new class PairQueryableId which isn't but a Pair of objects - the corresponding IDs of the PairQueryable members. PairQueryableId.toString() maintains the serialized form previously returned from getQueryableId(): "ID1.ID2" (as opposed to the standard Pair serialization). Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Bug-Url: https://bugzilla.redhat.com/1123396 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java 2 files changed, 28 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Invalid locale found in configuration ''
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Invalid locale found in configuration '' ...................................................................... engine: Invalid locale found in configuration '' - Fixed info message warning showing up in log. This was due to missing entry in database, and missing check for blank. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165073 Change-Id: Icae51fdd5427069281ac3d2147af797813228edb Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 13 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icae51fdd5427069281ac3d2147af797813228edb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0