- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine : CommandBase should not set end status for commands ...
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : CommandBase should not set end status for commands with callback ...................................................................... engine : CommandBase should not set end status for commands with callback When mixing async tasks and async commands if a callback is provided by the command the CommandBase should not set the status of the command. The command should override endSuccessfully and endWithFailure to set the status of the async tasks status to succeeded or failed. Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Bug-Url: https://bugzilla.redhat.com/1160872 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c05917003376d2f62d3da7acecd889f8cb79e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: make protocol visible during host edit
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: make protocol visible during host edit ...................................................................... ui: make protocol visible during host edit We would like to see protocol set for a host in edit mode. The protocol is modifable only when a host is moved to maintanance mode. Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1162229 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: dbscripts: drop index if exists
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: dbscripts: drop index if exists ...................................................................... packaging: dbscripts: drop index if exists drop index if exists using fn_db_create_index. Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Bug-Url: https://bugzilla.redhat.com/1155153 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 684206184f5632c151305e4ea429db01c5ca11cf) --- M packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql M packaging/dbscripts/upgrade/03_05_1090_create_index_on_images.sql M packaging/dbscripts/upgrade/03_05_1100_create_index_on_vm_device.sql 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: dbscripts: drop index if exists
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: dbscripts: drop index if exists ...................................................................... packaging: dbscripts: drop index if exists drop index if exists using fn_db_create_index. Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Bug-Url: https://bugzilla.redhat.com/1155153 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/dbscripts/upgrade/03_05_0720_index_for_stoarge_domain_id_in_unregistered_ovf_of_entities.sql M packaging/dbscripts/upgrade/03_06_0440_create_index_on_images.sql M packaging/dbscripts/upgrade/03_06_0450_create_index_on_vm_device.sql 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibacd60bb90ba6e1213b4f0fcb4844aa36ff60fc7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Use existing Engine session for REST API integration
by piotr.kliczewski＠gmail.com 18 Nov '14

18 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Use existing Engine session for REST API integration ...................................................................... webadmin: Use existing Engine session for REST API integration Before this patch ================= * WebAdmin login triggers creation of separate (logical) Engine session through creation of new (physical) REST session using HTTP basic auth -> REST session is acquired using current WebAdmin user credentials -> REST session ID is provided to all UI plugins * above causes two separate user login operations with same credentials and therefore two "user has logged in" events in Engine server log * acquired (physical) REST session, as well as corresponding (logical) Engine session, are _NOT_ closed upon WebAdmin logout, even though these sessions were created with WebAdmin user credentials After this patch ================ * WebAdmin login _DOES NOT_ trigger creation of separate (logical) Engine session; instead, it reuses existing Engine user session -> REST session is still acquired, but instead of HTTP basic auth credentials, we're passing existing Engine session auth token to associate REST session with current user's Engine session -> REST session ID is provided to all UI plugins * above ensures single user login operation upon WebAdmin login * since acquired REST session maps to existing Engine session, WebAdmin user logout makes that REST session unusable, even if the REST session itself is still alive We use Prefer:new-auth to ensure that new REST session is created on each WebAdmin login. Important note for UI plugin developers ======================================= REST session ID passed to UI plugins via "RestApiSessionAcquired" hook, also represented by JSESSIONID cookie for /api, will become unusable after WebAdmin logout. Since UI plugins are active (invoked by the infra) only while the user is authenticated, this shouldn't impact UI plugins that use provided REST session (cookie) to talk directly with Engine. Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Bug-Url: https://bugzilla.redhat.com/1161734 Bug-Url: https://bugzilla.redhat.com/1161730 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/FrontendLoginHandler.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 93 insertions(+), 69 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: add Prefer new-auth option
by piotr.kliczewski＠gmail.com 18 Nov '14

18 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: filters: add Prefer new-auth option ...................................................................... aaa: filters: add Prefer new-auth option this enforces opening a new http session, this is useful when remote wants to enforce new session and authorization in persist mode. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730 Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionValidationFilter.java M backend/manager/modules/aaa/src/test/java/org/ovirt/engine/core/aaa/filters/FiltersHelperTest.java 4 files changed, 41 insertions(+), 29 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: filters: enable accept engine session using header
by piotr.kliczewski＠gmail.com 18 Nov '14

18 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: filters: enable accept engine session using header ...................................................................... aaa: filters: enable accept engine session using header new header OVIRT-INTERNAL-ENGINE-AUTH-TOKEN accepts token that contains engine session id. a new query GetEngineSessionIdToken returns this token. ui should use the new query and apply the header to avoid double login. this may be temporary solution for 3.5 life cycle, as such applied only for restapi. when engine session is invalidated, all instances that used it are also invalidated. Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EngineSessionTokenAuthenticationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetEngineSessionIdTokenQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 6 files changed, 106 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: bll: generate engine session as plain random string
by piotr.kliczewski＠gmail.com 18 Nov '14

18 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: bll: generate engine session as plain random string ...................................................................... aaa: bll: generate engine session as plain random string Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734 Change-Id: I3f7e18e782c42990a19033c190b448f223b57634 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f7e18e782c42990a19033c190b448f223b57634 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.5]: win32: Set registry value with SetValueEx not SetValue
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Set registry value with SetValueEx not SetValue ...................................................................... win32: Set registry value with SetValueEx not SetValue _winreg.SetValue only allows to set the default value on a subkey SetValueEx lets one specify the value name and the value itself. Additionally as a security measure we're now encapsulating all exceptions coming from SAS handling to still at least attempt the login, even if the SAS portion may fail. This is just a precaution to prevent SSO from breaking due to some unforeseen bug. Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54 Bug-Url: https://bugzilla.redhat.com/1158470 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[ovirt-3.5]: win32: Read serial info directly when not available through WMI
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Read serial info directly when not available through WMI ...................................................................... win32: Read serial info directly when not available through WMI The SerialNumber field in the WMI table 'Win32_DiskDrive' is only available from Windows Vista and Windows 2008 Server. This patch works around this issue by querying the device directly, but only if the SerialNumber field is not available. Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750 Bug-Url: https://bugzilla.redhat.com/1158907 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 64 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0