- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: respect user preference on payload, smartcard and watc...
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: respect user preference on payload, smartcard and watchdog ...................................................................... core: respect user preference on payload, smartcard and watchdog The payload, smardcard and watchdog were copied from the instance type if it was selected all the time. Since this properties are no longer the "marked" ones, we need to respect the user preference on them. Change-Id: I1bc56e7b9f6e91431acb9345b4d87e9bfe145ee9 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bc56e7b9f6e91431acb9345b4d87e9bfe145ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use proper units in Storage QoS when talking to VDSM
by rgolan＠redhat.com 18 Nov '14

18 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: engine: Use proper units in Storage QoS when talking to VDSM ...................................................................... engine: Use proper units in Storage QoS when talking to VDSM The engine used Mbps and VDSM expects B/s. This patch changes the engine side to use MB/s (as is more common when dealing with storage) and properly translates that to Bytes when sending the value to VDSM. Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 3 files changed, 20 insertions(+), 14 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: make protocol visible during host edit
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: make protocol visible during host edit ...................................................................... ui: make protocol visible during host edit We would like to see protocol set for a host in edit mode. The protocol is modifable only when a host is moved to maintanance mode. Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1162229 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f6dc3f19ca0df0af4d7acdf7228e6e3c31ac61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: node: added persistent storage configuration
by sbonazzo＠redhat.com 18 Nov '14

18 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: added persistent storage configuration ...................................................................... node: added persistent storage configuration Added persistent storage configuration on modified files and directories when executed on oVirt Node / RHEV-H Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Bug-Url: https://bugzilla.redhat.com/1151339 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py 5 files changed, 122 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: node: added persistent storage configuration
by sbonazzo＠redhat.com 18 Nov '14

18 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: added persistent storage configuration ...................................................................... node: added persistent storage configuration Added persistent storage configuration on modified files and directories when executed on oVirt Node / RHEV-H Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Bug-Url: https://bugzilla.redhat.com/1151339 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/core/answerfile.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py 5 files changed, 122 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67afe1d994437eac841cc4217ed39f68d5b12374 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Create PairQueryable ID without UUID serialization
by lvernia＠redhat.com 18 Nov '14

18 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Create PairQueryable ID without UUID serialization ...................................................................... core: Create PairQueryable ID without UUID serialization As it turns out, serializing a UUID is a resource-consuming operation, and is not in fact required to compute a unique ID for a PairQueryable object. The mechanism is therefore swapped for a more efficient one, while maintaining the form of the serialized ID (in case it is needed somewhere, though that does not seem to be the case). The new ID is represented by a new class PairQueryableId which isn't but a Pair of objects - the corresponding IDs of the PairQueryable members. PairQueryableId.toString() maintains the serialized form previously returned from getQueryableId(): "ID1.ID2" (as opposed to the standard Pair serialization). Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Bug-Url: https://bugzilla.redhat.com/1123396 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java 2 files changed, 29 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0776567c5ef7f20830c70617dc69806cce3a6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fix pep8 issues
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: fix pep8 issues ...................................................................... packaging: setup: fix pep8 issues broken by I34b5c4ab5 Change-Id: I2ab030e8fdde5456e25e236b0174cbdc1a52b0dd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Vered Volansky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ab030e8fdde5456e25e236b0174cbdc1a52b0dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: mla: deny access to specific ID for users in user level API
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: mla: deny access to specific ID for users in user level API ...................................................................... mla: deny access to specific ID for users in user level API User who don't have manipulate_permission action group should not see users in system, even he shouldn't access them directly by their ID's. Change-Id: I90ec94fd0194680548e159f5d9bc010f5c233b91 Bug-Url: https://bugzilla.redhat.com/1160443 Signed-off-by: Ondra Machacek <machacek.ondra(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M packaging/dbscripts/user_sp.sql 4 files changed, 21 insertions(+), 4 deletions(-) Approvals: Ondřej Macháček: Verified Eli Mesika: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ec94fd0194680548e159f5d9bc010f5c233b91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Proper reports SSO token
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: Proper reports SSO token ...................................................................... userportal,webadmin: Proper reports SSO token - Pass the right SSO token to the reports server when loading the webadmin/userportal when already logged in. Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Looks good to me, but someone else must approve Alexander Wels: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: setup: Changing task cleaner utility to also handle removal ...
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: setup: Changing task cleaner utility to also handle removal of commands ...................................................................... setup: Changing task cleaner utility to also handle removal of commands The task cleaner utility now has the ability to present all commands or commands with running tasks, and to erase commands (or commands with running tasks) Bug-Url: https://bugzilla.redhat.com/1161012 Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 88 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d8f83cb7fc1f7fecb4ea68dff5cf0f3c63eeb6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0