- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: don't check for null serverity, forbid it.
by lvernia＠redhat.com 18 Nov '14

18 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: don't check for null serverity, forbid it. ...................................................................... core: don't check for null serverity, forbid it. we can controll that null severity of AuditLogType will not exist, which is better than checking if it's null. Change-Id: Ic44fb1683bacfa1c0f992ad4f272c3bb56526836 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44fb1683bacfa1c0f992ad4f272c3bb56526836 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: display indication if vm is in run-once
by juan.hernandez＠redhat.com 18 Nov '14

18 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: display indication if vm is in run-once ...................................................................... restapi: display indication if vm is in run-once Added a field to the VM REST query to indicate if the vm is running in run-once mode. Change-Id: I69a502a196aed2382acc35302004ea3b7cd89909 Bug-Url: https://bugzilla.redhat.com/1158357 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Eldan Shachar: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69a502a196aed2382acc35302004ea3b7cd89909 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Proper reports SSO token
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: Proper reports SSO token ...................................................................... userportal,webadmin: Proper reports SSO token - Pass the right SSO token to the reports server when loading the webadmin/userportal when already logged in. Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Bug-Url: https://bugzilla.redhat.com/1164788 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified Alexander Wels: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I137a8c03815e9cf9e154bd21f11345383d64485f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[ovirt-3.5]: sudoers: Fix of typo ovirt-shutdown-wrapper{s, }
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,} ...................................................................... sudoers: Fix of typo ovirt-shutdown-wrapper{s,} Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073 Bug-Url: https://bugzilla.redhat.com/1155921 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit e0e6e452f29730ea8c4a2dc889787e09e71c6bc7) --- M scripts/sudoers.ovirt-guest-agent 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Adding auth and principal records on session
by yzaslavs＠redhat.com 18 Nov '14

18 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Adding auth and principal records on session ...................................................................... aaa: Adding auth and principal records on session Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163147 Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 2 files changed, 20 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide92b3832d5007be88465b09a7683bc1034aa6c1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: xmlrpc: marshalling of Long type
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: xmlrpc: marshalling of Long type ...................................................................... xmlrpc: marshalling of Long type The change let people use 64bit numerical type (long) with xmlrpc. Jsonrpc already supports long type. There is xmlrpc extension i8 which let people use long type but we do not want to enable it due to backward compatibility reasons. In order to use this code developer needs to add method name to SUPPORTED_METHODS_FOR_LONG_CONVERSION collection. This reduces overhead of type fixing only to known methods. Long type is normalized to string to let older vdsms understand the value. Change-Id: I97ffc2da3703dbf7ce58607b7461a02aea35f2bb Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1145621 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Sivák: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ffc2da3703dbf7ce58607b7461a02aea35f2bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extension-api: fix multiple compiler warnings
by oourfali＠redhat.com 18 Nov '14

18 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: extension-api: fix multiple compiler warnings ...................................................................... extension-api: fix multiple compiler warnings Fixed warnings related to the use of Class as a raw type. Fixed unused imports Change-Id: I0a6c4bb2aff40770607a129a83a20ceb2038dd99 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtKey.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/ExtUUID.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Mapping.java 3 files changed, 6 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Tim Speetjens: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a6c4bb2aff40770607a129a83a20ceb2038dd99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix naming in CpuFlagsManagerHandler
by ofrenkel＠redhat.com 18 Nov '14

18 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix naming in CpuFlagsManagerHandler ...................................................................... core: Fix naming in CpuFlagsManagerHandler Fix naming convention to avoid build errors. Change-Id: I85b83637c1f3ee30a10abb36a86c8dd46a2ac8be Bug-Url: https://bugzilla.redhat.com/838487 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostArchitectureQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByVdsIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java 12 files changed, 20 insertions(+), 18 deletions(-) Approvals: Eldan Shachar: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85b83637c1f3ee30a10abb36a86c8dd46a2ac8be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: sudoers: Fix of typo ovirt-shutdown-wrapper{s, }
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: sudoers: Fix of typo ovirt-shutdown-wrapper{s,} ...................................................................... sudoers: Fix of typo ovirt-shutdown-wrapper{s,} Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073 Bug-Url: https://bugzilla.redhat.com/1155921 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M scripts/sudoers.ovirt-guest-agent 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9247c6c2048a1f20f048c8232d2c18698a414073 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: medium Instance Type mismatch feature page
by tnisan＠redhat.com 18 Nov '14

18 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: medium Instance Type mismatch feature page ...................................................................... core: medium Instance Type mismatch feature page According to feature page, in medium instance type, total virtual CPUs should be 2, but it is 1. Fixed by updating this property in the DB. The update statement tries to be as specific about the instance type as possible, but since it is not possible to use it's ID which was generated, it relyes on the name/description + some configuration. Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d Bug-Url: https://bugzilla.redhat.com/1142924 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_1170_medium_instance_type_has_two_cpus.sql 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03407f86c272578cec671f49e89d2ffbeb93ae4d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0