- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: mismatch in dialog header
by gchaplik＠redhat.com 29 Sep '14

29 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: mismatch in dialog header ...................................................................... webadmin: mismatch in dialog header edit CPU QoS dialog. Change-Id: I04da25eda198e2e4e59e51ce854dddf9a4ddaef4 Bug-Url: https://bugzilla.redhat.com/1142336 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditCpuQosModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04da25eda198e2e4e59e51ce854dddf9a4ddaef4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: enforce that datacenter id cannot be changed.
by lvernia＠redhat.com 29 Sep '14

29 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core,webadmin: enforce that datacenter id cannot be changed. ...................................................................... core,webadmin: enforce that datacenter id cannot be changed. Change-Id: I1a1a0e5fa0dfd9c1756ebba75f84d3a12c723317 Bug-Url: https://bugzilla.redhat.com/1140492 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 12 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a1a0e5fa0dfd9c1756ebba75f84d3a12c723317 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: enforce that label cannot be added to externa...
by lvernia＠redhat.com 29 Sep '14

29 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core,webadmin: enforce that label cannot be added to external network ...................................................................... core,webadmin: enforce that label cannot be added to external network Change-Id: I1c697a06afa15ff5c31c0396d0744c9c456c2dc9 Bug-Url: https://bugzilla.redhat.com/1140491 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 27 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c697a06afa15ff5c31c0396d0744c9c456c2dc9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: node: fixup broken I4b24131 code to properly import modules
by Alon Bar-Lev 29 Sep '14

29 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: node: fixup broken I4b24131 code to properly import modules ...................................................................... node: fixup broken I4b24131 code to properly import modules Change-Id: I2f24d31d001df63f4b8467ef52fb6640af712047 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128033 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/node/persist.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f24d31d001df63f4b8467ef52fb6640af712047 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: create default disk profile for attached SD
by gchaplik＠redhat.com 29 Sep '14

29 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: create default disk profile for attached SD ...................................................................... core: create default disk profile for attached SD Disk profile wasn't created for 'old' storage domain that is attached to 3.5 data center. Also added compensation support for disk profile. Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f Bug-Url: https://bugzilla.redhat.com/1146073 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic59d6f38096fb5e20fee5b9b4705b4603fdf0d4f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove Memory and OVF Volumes on VM Remove
by tnisan＠redhat.com 29 Sep '14

29 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove Memory and OVF Volumes on VM Remove ...................................................................... core: Remove Memory and OVF Volumes on VM Remove When removing a VM that has a snapshot with memory, its memory and OVF volumes are not removed. The reason for this is the value of the property removeOnlyIfNotUsedAtAll in RemoveMemoryVolumesParameters. If we don't set its value to true, by default it's false and then we can remove the memory and OVF volumes before the VM's disks. Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Bug-Url: https://bugzilla.redhat.com/1145073 Bug-Url: https://bugzilla.redhat.com/1145188 Bug-Url: https://bugzilla.redhat.com/1147085 Bug-Url: https://bugzilla.redhat.com/1145254 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/33432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: don't use hotplug when updating instance type
by tnisan＠redhat.com 29 Sep '14

29 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: don't use hotplug when updating instance type ...................................................................... core: don't use hotplug when updating instance type when updating vms connected to an instance type, if using hotplug (for cpu) and it fails, the change is lost. so always use "apply later" so the changes would anyway apply when the vm is down. Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fixed missing type variable in disk profiles
by tnisan＠redhat.com 29 Sep '14

29 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fixed missing type variable in disk profiles ...................................................................... core: Fixed missing type variable in disk profiles Fixed the missing type variable in disk profiles. Also, fixed the bug for CPU profiles, since it share the same common base class as disk profile. Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateProfileCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 41 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix api/schedulingpolicyunits/policy_unit_id
by juan.hernandez＠redhat.com 29 Sep '14

29 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: engine: fix api/schedulingpolicyunits/policy_unit_id ...................................................................... engine: fix api/schedulingpolicyunits/policy_unit_id Change-Id: Ic3cf7127d437506c842b0be93dc4ed29198b7937 Bug-Url: https://bugzilla.redhat.com/1142916 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/GetPolicyUnitByIdQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPolicyUnitResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPolicyUnitsResource.java 3 files changed, 12 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Gilad Chaplik: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3cf7127d437506c842b0be93dc4ed29198b7937 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixed log for cluster unsupported emulated machine
by rgolan＠redhat.com 29 Sep '14

29 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: Fixed log for cluster unsupported emulated machine ...................................................................... core: Fixed log for cluster unsupported emulated machine When a cluster upgrade occurred and a host didn't support the new cluster requirement, the error that was given included the cluster old emulated machine value (which the host did support). Error printout logic was fixed and messages changed accordingly. Change-Id: I8397cd64364c98aa76818613dbe78ddef2391027 Bug-Url: https://bugzilla.redhat.com/1141508 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 7 files changed, 20 insertions(+), 6 deletions(-) Approvals: Eldan Shachar: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8397cd64364c98aa76818613dbe78ddef2391027 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0