- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: disk widget - generics in event listeners
by derez＠redhat.com 29 Sep '14

29 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: frontend: disk widget - generics in event listeners ...................................................................... frontend: disk widget - generics in event listeners Added proper generics to event listeners to avoid unchecked assignment warnings. Change-Id: I8da8bc74866daf19be16078a7864192c60f3a96d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 16 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8da8bc74866daf19be16078a7864192c60f3a96d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: disk dialog - radio button patternfly fix
by derez＠redhat.com 29 Sep '14

29 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: frontend: disk dialog - radio button patternfly fix ...................................................................... frontend: disk dialog - radio button patternfly fix Disk Dialog: * Added 'avw_contentWidget_pfly_fix' radio buttons container to fix label style. * Removed redundant 'ui:' prefix for accommodating to uibinder valid syntax. Change-Id: I5b010807095b5cc8d37c6ed43a05c809cbf8f617 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b010807095b5cc8d37c6ed43a05c809cbf8f617 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Do not emit email events when the state was not changed
by msivak＠redhat.com 29 Sep '14

29 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: Do not emit email events when the state was not changed ...................................................................... Do not emit email events when the state was not changed This also fixes the trigger regexp to be more in alignment with the current state machine. Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146433 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/broker.conf 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: services: ovirt-engine disable jboss deployments ...
by sbonazzo＠redhat.com 29 Sep '14

29 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine disable jboss deployments per default ...................................................................... packaging: services: ovirt-engine disable jboss deployments per default Change-Id: I9633e83a94b496398171ab9e69ffe1bfee959fe7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py 3 files changed, 18 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9633e83a94b496398171ab9e69ffe1bfee959fe7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: reduced logging in Even distribution policy
by rgolan＠redhat.com 29 Sep '14

29 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: engine: reduced logging in Even distribution policy ...................................................................... engine: reduced logging in Even distribution policy Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126839 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: packaging: spec: add jpackage-utils build requires
by Alon Bar-Lev 28 Sep '14

28 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add jpackage-utils build requires ...................................................................... packaging: spec: add jpackage-utils build requires Change-Id: I9c9d97cd7a7021bd76077fb8400715a0b98fa034 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c9d97cd7a7021bd76077fb8400715a0b98fa034 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate total committed size of a storage domain cor...
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate total committed size of a storage domain correctly ...................................................................... core: Calculate total committed size of a storage domain correctly Bug-Url: https://bugzilla.redhat.com/1147246 Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix typo in error message
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix typo in error message ...................................................................... core: fix typo in error message Capital letter for profile error message. Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Calculate total committed size of a storage domain cor...
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate total committed size of a storage domain correctly ...................................................................... core: Calculate total committed size of a storage domain correctly Bug-Url: https://bugzilla.redhat.com/1147246 Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove Memory and OVF Volumes on VM Remove
by amureini＠redhat.com 28 Sep '14

28 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove Memory and OVF Volumes on VM Remove ...................................................................... core: Remove Memory and OVF Volumes on VM Remove When removing a VM that has a snapshot with memory, its memory and OVF volumes are not removed. The reason for this is the value of the property removeOnlyIfNotUsedAtAll in RemoveMemoryVolumesParameters. If we don't set its value to true, by default it's false and then we can remove the memory and OVF volumes before the VM's disks. Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Bug-Url: https://bugzilla.redhat.com/1145073 Bug-Url: https://bugzilla.redhat.com/1145188 Bug-Url: https://bugzilla.redhat.com/1147085 Bug-Url: https://bugzilla.redhat.com/1145254 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0