- Engine-commits - oVirt List Archives

Change in jenkins[master]: repo_closure: added EL7 support
by dcaroest＠redhat.com 01 Aug '14

01 Aug '14

David Caro has submitted this change and it was merged. Change subject: repo_closure: added EL7 support ...................................................................... repo_closure: added EL7 support Added EL7 support for repository closure checking. Also fixed URLs to Gluster repositories for EL6. Change-Id: I77e7f654318589dcecc4e27c7285c98a74c1164d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/packaging/repo_closure_check.sh 1 file changed, 46 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Verified Eyal Edri: Looks good to me, but someone else must approve David Caro: Looks good to me, approved Ohad Basan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77e7f654318589dcecc4e27c7285c98a74c1164d Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : Reason does not get updated when trying to shut dow...
by oourfali＠redhat.com 01 Aug '14

01 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Reason does not get updated when trying to shut down a VM ...................................................................... engine : Reason does not get updated when trying to shut down a VM When trying to stop the VM while it is powering up or shutting down, the reason comment does not get saved in the DB Change-Id: I8f70177206de3fd3081826ea898ab2a7fb87357b Bug-Url: https://bugzilla.redhat.com/1114903 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f70177206de3fd3081826ea898ab2a7fb87357b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: configure.ac: increase rpm release
by dougsland＠redhat.com 31 Jul '14

31 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure.ac: increase rpm release ...................................................................... configure.ac: increase rpm release Change-Id: I3f66aac520e0390b2fb0b81d58169288d3e54c0f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f66aac520e0390b2fb0b81d58169288d3e54c0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: Include hosted engine plugin into iso form 3.5 on
by dougsland＠redhat.com 31 Jul '14

31 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Include hosted engine plugin into iso form 3.5 on ...................................................................... Include hosted engine plugin into iso form 3.5 on >From 3.5 on we want to include the hosted-engine plugin by default into the iso for oVirt. Change-Id: Idda19745018541a51866aca2108510e67c907c03 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038616 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M recipe/vdsm-plugin-iso.ks 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idda19745018541a51866aca2108510e67c907c03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: Include hosted engine plugin into iso form 3.5 on
by dougsland＠redhat.com 31 Jul '14

31 Jul '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Include hosted engine plugin into iso form 3.5 on ...................................................................... Include hosted engine plugin into iso form 3.5 on >From 3.5 on we want to include the hosted-engine plugin by default into the iso for oVirt. Change-Id: Idda19745018541a51866aca2108510e67c907c03 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038616 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- M recipe/vdsm-plugin-iso.ks 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idda19745018541a51866aca2108510e67c907c03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog ...................................................................... webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog In fr_FR locale the text did not fit into buttons in new VM guide me dialog. Fixed by changing the styles in a way that when the text is longer than 250px (min width) than the button grows. Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8 Bug-Url: https://bugzilla.redhat.com/1123762 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 3 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: backend: Validate cdrom images for .iso suffix
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: backend: Validate cdrom images for .iso suffix ...................................................................... backend: Validate cdrom images for .iso suffix Check for the filename ".iso" suffix of isoPath in UpdateVm and ChangeDisk commands. Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013737 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 6 files changed, 30 insertions(+), 0 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
by tjelinek＠redhat.com 31 Jul '14

31 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog ...................................................................... webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog In fr_FR locale the text did not fit into buttons in new VM guide me dialog. Fixed by changing the styles in a way that when the text is longer than 250px (min width) than the button grows. Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8 Bug-Url: https://bugzilla.redhat.com/1123762 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 3 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixes StackOverflowError during fencing
by emesika＠redhat.com 31 Jul '14

31 Jul '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Fixes StackOverflowError during fencing ...................................................................... core: Fixes StackOverflowError during fencing Fixes StackOverflowError appeared during execution of fencing operation. This fix removes commandContex instance and overriden getContext() from RestartVdsCommand, because command context in CommandBase should be set always during creation of command and successful locks aquiring is checked prior to executeCommand call in CommandBase. Also when RestartVdsCommand and its inherited commands are using global command context, VdsKdumpDetection command executed from VdsNotRespondingTreatmentCommand should also use global command context and not its copy. The overriden getContext() has been introduced in Iaf021010188e3c3662fbf8a057da4c58f2600c02. Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Bug-Url: https://bugzilla.redhat.com/1124141 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsKdumpDetectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 3 files changed, 2 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Transaction issues in CommandsCacheImpl updateStatus
by emesika＠redhat.com 31 Jul '14

31 Jul '14

Eli Mesika has submitted this change and it was merged. Change subject: engine : Transaction issues in CommandsCacheImpl updateStatus ...................................................................... engine : Transaction issues in CommandsCacheImpl updateStatus When async tasks are executed the updateCommandStatus is being performed from two different transaction resulting in transcation lock. Transaction needs to be suspended before updating command status. Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e29d516b4cdf1509ae7838731869684004e5ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0