- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: GWT debug mode speedup.
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: GWT debug mode speedup. ...................................................................... webadmin: GWT debug mode speedup. Debug mode would take around 4:30 to get from the login page to the VM main tab when logging in. This is due to the proxy event on UiCommonInitEvent in AbstractSubTabPresenter. This event would fire and it would cause all sub classes of AbstractSubTabPresenter to initialize and since the code was split, it would have to load every single sub tab presenter everywhere at once. This took about 500ms-3000ms depending on the presenter. With around 200 sub tab presenters, it would take a long long time. This patch removes the proxy event and instead places the handler initialization in the onBind of the presenter. This should have the exact same effect as before (the handlers are initalized when the presenter is activated vs when the application is initalized). Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110788 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostHardwarePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java 8 files changed, 20 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Minor cleanup of ValidationUtilsTest
by ofrenkel＠redhat.com 31 Jul '14

31 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Minor cleanup of ValidationUtilsTest ...................................................................... core: Minor cleanup of ValidationUtilsTest Remove duplication in tests code when testing for pattern match of multiple strings. Change-Id: I3416939844516e3d39538221970c9caa5ca73fd7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java 1 file changed, 4 insertions(+), 21 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3416939844516e3d39538221970c9caa5ca73fd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Validate cdrom images for .iso suffix
by ofrenkel＠redhat.com 31 Jul '14

31 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Validate cdrom images for .iso suffix ...................................................................... backend: Validate cdrom images for .iso suffix Check for the filename ".iso" suffix of isoPath in UpdateVm and ChangeDisk commands. Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013737 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 6 files changed, 30 insertions(+), 0 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d4e6e6464e5f23483748dcd03607612b1fc56f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set images with Storage Pool for images already on tar...
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set images with Storage Pool for images already on target. ...................................................................... core: Set images with Storage Pool for images already on target. Setting images with storage pool id only for images which are already on the Storage Domain, since importing a VM from configuration through the REST does not oblegate an initialized Storage Domain Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40 Bug-Url: https://bugzilla.redhat.com/1124879 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Update os-info max memory sizes for x64 systems
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Update os-info max memory sizes for x64 systems ...................................................................... engine: Update os-info max memory sizes for x64 systems 64-bit RHEL and windows systems inherited max memory size from "other" system which specified appropriate value for 32-bit systems (64000M). Updated value of os.resource.maximum.ram for the following systems: RHEL3x64: 128 GB RHEL4x64: 256 GB RHEL5x64: 1 TB RHEL6x64: 3 TB RHEL7x64: 3 TB Windows2003x64: 1 TB Windows2008x64: 1 TB Windows2008R2x64: 2 TB Windows2012x64 4 TB Windows7x64: 192 GB Windows8x64: 512 GB Based on: [1] https://access.redhat.com/articles/rhel-limits [2] http://msdn.microsoft.com/en-us/library/windows/desktop/aa366778(v=vs.85).a… Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1087745 Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: ui: onboot checkbox is not align with the dialog
by shavivi＠redhat.com 31 Jul '14

31 Jul '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: onboot checkbox is not align with the dialog ...................................................................... ui: onboot checkbox is not align with the dialog Bug-Url: https://bugzilla.redhat.com/1124298 Change-Id: I9dff872a8a4bfad59ba0b0ebcedb6ef0df6952d1 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dff872a8a4bfad59ba0b0ebcedb6ef0df6952d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: removing fenceSpmStorage verb and related classes
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: removing fenceSpmStorage verb and related classes ...................................................................... core: removing fenceSpmStorage verb and related classes The use of fenceSpmStorage was removed in the previous patch in the series, as it's not used anymore it can be safely remove along the related classes. Change-Id: I593a0620696729500d740c632a2a149c09366cbc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092752 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceSpmStorageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SpmStartVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceSpmStorageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 27 insertions(+), 83 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/30890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I593a0620696729500d740c632a2a149c09366cbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: replacing fenceSpmStorage with logic within engine
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: replacing fenceSpmStorage with logic within engine ...................................................................... core: replacing fenceSpmStorage with logic within engine Currently when the SPM is in different statuses the user can manually confirm that the host has been rebooted in order to attempt to start the spm on a different host. That confirmation propogates to the execution of FenceVdsManuallyCommand that may execute the fenceSpmStorage verb on vdsm through some host. The fenceSpmStorage verb edits the pool metadata to indicate that currently there's no host which is the SPM. Later on when the engine will enter the start spm flow, it will execute the getSpmStatus which should return that there's no spm and then the engine will attempt to start the spm on some host within the data center. On storage pools that use the StoragePoolDiskBackend this flow works, but when using the new MemoryBackend the spm status result is being returned from the cluster lock, the data there isn't editable at the moment so on that case, the spm won't be able to start on other host (as the returned result would indicate that there's a spm). On this patch when a user confirm that the spm has been rebooted, we'll save that in the memory, when the spm selection process will attempt to select a new spm in case that the reported spm was confirmed to be fenced by the user - we'll proceed with starting the spm on another host. Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092752 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java 4 files changed, 48 insertions(+), 66 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/30889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Update os-info max memory sizes for x64 systems
by ofrenkel＠redhat.com 31 Jul '14

31 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Update os-info max memory sizes for x64 systems ...................................................................... engine: Update os-info max memory sizes for x64 systems 64-bit RHEL and windows systems inherited max memory size from "other" system which specified appropriate value for 32-bit systems (64000M). Updated value of os.resource.maximum.ram for the following systems: RHEL3x64: 128 GB RHEL4x64: 256 GB RHEL5x64: 1 TB RHEL6x64: 3 TB RHEL7x64: 3 TB Windows2003x64: 1 TB Windows2008x64: 1 TB Windows2008R2x64: 2 TB Windows2012x64 4 TB Windows7x64: 192 GB Windows8x64: 512 GB Based on: [1] https://access.redhat.com/articles/rhel-limits [2] http://msdn.microsoft.com/en-us/library/windows/desktop/aa366778(v=vs.85).a… Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1087745 Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2b098fb0c05cca5d5f9638c7ac693c631317b2f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: allow read-only for VirtIO-SCSI DirectLUN disks
by derez＠redhat.com 31 Jul '14

31 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks ...................................................................... core: allow read-only for VirtIO-SCSI DirectLUN disks In order to support read-only property for VirtIO-SCSI DirectLUN disks, the device type for such disks should be 'disk' (SCSI emulation) instead of 'lun' (SCSI pass-through). I.e. representation in the domain xml sent to libvirt should look like [1] instead of [2]. Note that this limitation (enabling pass-through for read-only VirtIO-SCSI DirectLUN disks) could be removed once 'Support read only VirtIO-SCSI direct LUNs in QEMU' bug [3] is resolved. To provide full flexibility, added a new check-box for enabling pass-through (see screenshot [4]). I.e. the user can choose between emulated and pass-through ('disk' vs. 'lun'); read-only is currently supported only for emulated. [1] <disk type='block' device='disk'>...</disk> [2] <disk type='block' device='lun'>...</disk> [3] https://bugzilla.redhat.com/1110396 [4] screenshot: http://i.imgur.com/5mS3xSk.jpg Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0 Bug-Url: https://bugzilla.redhat.com/1118847 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_0070_update_sgio_for_readonly_disks.sql 17 files changed, 135 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Paolo Bonzini <pbonzini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0