- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: setup: stop and notify if setup is not run as root
by ydary＠redhat.com 06 Oct '13

06 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: stop and notify if setup is not run as root ...................................................................... packaging: setup: stop and notify if setup is not run as root Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512 Bug-Url: https://bugzilla.redhat.com/853955 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: make ctrl-c breaking the command rather than existing s...
by mpastern＠redhat.com 06 Oct '13

06 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: make ctrl-c breaking the command rather than existing shell #869269 ...................................................................... cli: make ctrl-c breaking the command rather than existing shell #869269 Change-Id: Ia6b9020bb8b8177d018dac08e1734c681603445e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=869269 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6b9020bb8b8177d018dac08e1734c681603445e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix cluster creating in guide
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fix cluster creating in guide ...................................................................... webadmin: fix cluster creating in guide When creating a cluster in the datacenter guide, policy units configuretion was not saved. added missing policy unit mapping from ClusterModel to VDSGroup Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Bug-Url: https://bugzilla.redhat.com/1001182 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Don't add VNICs to a VM by default
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't add VNICs to a VM by default ...................................................................... webadmin: Don't add VNICs to a VM by default VNICs used to be added to VMs created from VNIC-less templates by default, to accommodate assigning some sort of network connection to a VM when creating it. This is no longer needed, as VNICs can now be added and removed by the user in the same dialog. Change-Id: I2d00fd6a4fb280d9604bc1ae586fcc588d4a7196 Bug-Url: https://bugzilla.redhat.com/1003779 Bug-Url: https://bugzilla.redhat.com/1009298 Bug-Url: https://bugzilla.redhat.com/1010856 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 15 insertions(+), 36 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d00fd6a4fb280d9604bc1ae586fcc588d4a7196 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Add/Remove VNICs in Add/Edit VM dialog
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add/Remove VNICs in Add/Edit VM dialog ...................................................................... webadmin: Add/Remove VNICs in Add/Edit VM dialog Enabled adding/removing VNICs in the VM dialogs using AddRemoveRowWidget. Change-Id: Id7654d137541aec64ce19aa309021b307253171e Bug-Url: https://bugzilla.redhat.com/1003779 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 9 files changed, 197 insertions(+), 117 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7654d137541aec64ce19aa309021b307253171e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Introducing AddRemoveRowWidget
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Introducing AddRemoveRowWidget ...................................................................... webadmin: Introducing AddRemoveRowWidget This is a reusable widget used to display a list of other widgets, backed by a ListModel of values. Entries may be removed or added using minus/plus buttons. A new entry is added by activating a semi-disabled "ghost" entry. Change-Id: I15958e4b7c1fcf0ec08ea35eb32c690964f2a366 Bug-Url: https://bugzilla.redhat.com/1003779 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java 1 file changed, 242 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15958e4b7c1fcf0ec08ea35eb32c690964f2a366 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Unified VNIC update logic on VM creation
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Unified VNIC update logic on VM creation ...................................................................... webadmin: Unified VNIC update logic on VM creation Towards adding the ability to add and remove VNICs in the add/edit VM dialogs, the VNIC logic is unified so it is the same for all kinds of VM creation flows (e.g. from scratch, from template...); VNICs may always be added, edited or removed. Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086 Bug-Url: https://bugzilla.redhat.com/1003779 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallbacks.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 129 insertions(+), 241 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Replaced null profile with empty profile
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Replaced null profile with empty profile ...................................................................... webadmin: Replaced null profile with empty profile Added a special value to represent an empty profile, and changed empty profile instances to that instead of null. This is needed by a soon-to-be-implemented Add/Remove VNIC widget in the Add/Edit VM dialog, in order to discriminate between the case where a profile hasn't yet been assigned (null) and the case where the empty profile has been assigned (VnicProfileView.EMPTY). Change-Id: I06962e43084ff4fd469e0025527cdd85a47f5ea7 Bug-Url: https://bugzilla.redhat.com/1003779 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfileView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 7 files changed, 31 insertions(+), 18 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06962e43084ff4fd469e0025527cdd85a47f5ea7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Enabled column resizing in Manage Cluster Networks
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Enabled column resizing in Manage Cluster Networks ...................................................................... webadmin: Enabled column resizing in Manage Cluster Networks In certain locales columns would get wider, to the point where a horizontal scroll bar appeared. This fixes it. Also adjusted some preset widths to look better in English. Change-Id: If7bac93b4de9400996a07ffc98fed3a6343fef34 Bug-Url: https://bugzilla.redhat.com/1009745 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7bac93b4de9400996a07ffc98fed3a6343fef34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed table layout upon enableColumnResizing()
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fixed table layout upon enableColumnResizing() ...................................................................... webadmin: Fixed table layout upon enableColumnResizing() This makes sure that column resizing behaves consistently for the tables in which it's enabled (without it some default browser rearranging occurs). Change-Id: Ia36d2d4f1cae395fe9f12d55a05799445d0eca11 Bug-Url: https://bugzilla.redhat.com/1009745 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia36d2d4f1cae395fe9f12d55a05799445d0eca11 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0