- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Block multicast MAC addresses for vNICs
by masayag＠redhat.com 06 Oct '13

06 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Block multicast MAC addresses for vNICs ...................................................................... engine: Block multicast MAC addresses for vNICs The patch blocks the possibility to provide a non- unicast mac address to the vnic: neither broadcast or multicast mac addresses aren't allowed for a vnic. Change-Id: Ida4082be249391494053b56540d5458fecec65da Bug-Url: https://bugzilla.redhat.com/1011912 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterfaceValidationTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacAddressValidation.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 45 insertions(+), 43 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida4082be249391494053b56540d5458fecec65da Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed storage from pools general sub-tab
by derez＠redhat.com 06 Oct '13

06 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: removed storage from pools general sub-tab ...................................................................... webadmin: removed storage from pools general sub-tab Since a pool can contain disks from multiple storage domains, 'Resides on Storage Domain' is no longer relevant. Hence, * removed from pools general sub-tab. * removed redundant method PoolGeneralModel -> updateStorageDomain. Change-Id: I26a1ec85ef404954767aa81042679e3120efad2a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java 3 files changed, 0 insertions(+), 100 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a1ec85ef404954767aa81042679e3120efad2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: removed dead code from VmGeneralModel
by derez＠redhat.com 06 Oct '13

06 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: removed dead code from VmGeneralModel ...................................................................... webadmin: removed dead code from VmGeneralModel VmGeneralModel -> updateStorageDomain method has been used for displaying in which domain the VM resides on. Since a VM can contain disks from multiple storage domains this method is no longer relevant. Change-Id: Ida307e9bf7d8a89d6466569f16ae0596c648d636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 1 file changed, 0 insertions(+), 72 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida307e9bf7d8a89d6466569f16ae0596c648d636 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: UX: more readable error message checking space
by sbonazzo＠redhat.com 04 Oct '13

04 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: more readable error message checking space ...................................................................... UX: more readable error message checking space Changed the error message when there's not enough space for the self hosted engine VM to be more readable. Change-Id: I56d5e011377f6f5bd43b4c86fceb57b6e622ff9d Bug-Url: https://bugzilla.redhat.com/1013662 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/domains.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py 3 files changed, 31 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d5e011377f6f5bd43b4c86fceb57b6e622ff9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added vertical scrolling to BaseListModelSuggestBox
by iheim＠redhat.com 04 Oct '13

04 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added vertical scrolling to BaseListModelSuggestBox ...................................................................... webadmin: Added vertical scrolling to BaseListModelSuggestBox All suggest boxes in the system could probably use a height limitation for their suggestion list, with a vertical scrollbar when the content is too big. Also took the chance to move the logic fitting the height of the suggestion list to that of the content from ListModelTypeAheadListBox to BaseListModelSuggestBox, as ListModelSuggestBox could also use it. Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666 Bug-Url: https://bugzilla.redhat.com/1008523 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: UX: more readable error message checking space
by sbonazzo＠redhat.com 04 Oct '13

04 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: more readable error message checking space ...................................................................... UX: more readable error message checking space Changed the error message when there's not enough space for the self hosted engine VM to be more readable. Change-Id: I56d5e011377f6f5bd43b4c86fceb57b6e622ff9d Bug-Url: https://bugzilla.redhat.com/1013662 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/domains.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py 3 files changed, 31 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56d5e011377f6f5bd43b4c86fceb57b6e622ff9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: Allow using any domain for sysprep
by iheim＠redhat.com 04 Oct '13

04 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Allow using any domain for sysprep ...................................................................... frontend: Allow using any domain for sysprep This patch allows user to alter domain name for sysprep when running the machine using "run once". The problem was caused by wrong condition when filling from model to RunVmOnceParams. Fixed by adjusting the condition. There was also another issue with the ComboBox, which wasn't working correctly when there is a custom text put in and user wants to apply a value from the drop-down menu. In this case the value is not updated. Hot-fixed by manual handling of DOM events. Change-Id: Iff87239de98694cf124a44e7cb39f6d9e867ce93 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1015154 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java 4 files changed, 47 insertions(+), 59 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff87239de98694cf124a44e7cb39f6d9e867ce93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: spec: always pull recent pythonlib
by iheim＠redhat.com 04 Oct '13

04 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: always pull recent pythonlib ...................................................................... packaging: spec: always pull recent pythonlib Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1009863 Change-Id: I113dd0a5bb477b02d857dcca820fd2a2a8b54762 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113dd0a5bb477b02d857dcca820fd2a2a8b54762 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: detect java home at runtime
by iheim＠redhat.com 04 Oct '13

04 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: detect java home at runtime ...................................................................... packaging: detect java home at runtime CURRENT IMPLEMENTATION detect java home during installation. advantage is optimize application execution post-setup. disadvantage is that java home may be altered by system updates. NEW IMPLEMENTATION detect java home during runtime using pre-defined algorithm. algorithm: execute /usr/share/ovirt-engine/bin/java-home. if java-home.local is available, execute that script. this enables distro specific customization. if OVIRT_ENGINE_JAVA_HOME environment is set, validate java validity and use/abort. search predefined selected alternatives location by order, first wins. search /usr/lib/jvm for compatible jvm. NOTES the java-home script resides with the lib package as it cannot reside within any version locked package since it is used by setup, and it cannot reside within setup since it used by post setup. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009863 Change-Id: I833362d0498d534b06e0d7660f1e8a61e9b1713b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in M packaging/bin/engine-prolog.sh.in A packaging/bin/java-home A packaging/pythonlib/ovirt_engine/config.py.in A packaging/pythonlib/ovirt_engine/java.py M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/java.py 13 files changed, 172 insertions(+), 231 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I833362d0498d534b06e0d7660f1e8a61e9b1713b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: services: prepend pythonlib
by iheim＠redhat.com 04 Oct '13

04 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: services: prepend pythonlib ...................................................................... packaging: services: prepend pythonlib devenv should shadow default search path, so system library will not shadow devenv. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1009863 Change-Id: I5383c6529e822d92593d2e915a76bc3b25855866 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/config.py.in M packaging/services/ovirt-engine/config.py.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5383c6529e822d92593d2e915a76bc3b25855866 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0