- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Rename UseSecureConnectionWithServers
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Rename UseSecureConnectionWithServers ...................................................................... engine: Rename UseSecureConnectionWithServers Rename UseSecureConnectionWithServers for EncryptHostCommunication to be more descriptive. Change-Id: Ia25ed8e39a1a0bc737fb198e90d92489a8fe346c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003117 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/setup/plugins/ovirt-engine-setup/config/options.py 10 files changed, 16 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25ed8e39a1a0bc737fb198e90d92489a8fe346c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix db upgrade conflict
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix db upgrade conflict ...................................................................... core: fix db upgrade conflict Change-Id: I1b4abe97a5403a5c75b9b385f1d046f7a14d0131 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- R packaging/dbscripts/upgrade/03_03_0960_add_dwh_heartbeat.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b4abe97a5403a5c75b9b385f1d046f7a14d0131 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adds scheduled job DwhHeartBeat
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adds scheduled job DwhHeartBeat ...................................................................... core: Adds scheduled job DwhHeartBeat Adds DwhHeartBeatInterval option to ConfigValues. Adds scheduled job DwhHeartBeat that periodically updates dwhHeart variable in dwh_history_timekeeping table. DwhHeartBeatInterval is editable in engine-config. Change-Id: I779240b3fe6a1e15a54e8bb5d201462092a6f13f Bug-Url: https://bugzilla.redhat.com/962177 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 5 files changed, 75 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I779240b3fe6a1e15a54e8bb5d201462092a6f13f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adds entity DwhHistoryTimekeeping and variable heartBeat
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adds entity DwhHistoryTimekeeping and variable heartBeat ...................................................................... core: Adds entity DwhHistoryTimekeeping and variable heartBeat Adds store procedures to access dwh_history_timekeeping table. Adds business entity DwhShistoryTimekeeping and its DAO. Adds new variable 'heartBeat' to dwh_history_timekeeping table Change-Id: Ib34301ea921b2fda9fb0e09927b0417c0c096aca Bug-Url: https://bugzilla.redhat.com/962177 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeeping.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeepingVariable.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoTest.java A packaging/dbscripts/dwh_history_timekeeping_sp.sql A packaging/dbscripts/upgrade/03_03_0950_add_dwh_heartbeat.sql 9 files changed, 296 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib34301ea921b2fda9fb0e09927b0417c0c096aca Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Audit log failed external scheduler discovery
by gchaplik＠redhat.com 03 Oct '13

03 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Audit log failed external scheduler discovery ...................................................................... core: Audit log failed external scheduler discovery When the external scheduler thread fails discovery no further external operations occure. Now we let the user know about it. Change-Id: I198b4fd6300d903fcce55afc400a3075af1ea11c Bug-Url: https://bugzilla.redhat.com/1001986 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 11 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I198b4fd6300d903fcce55afc400a3075af1ea11c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change policy unit names
by gchaplik＠redhat.com 03 Oct '13

03 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: change policy unit names ...................................................................... core: change policy unit names Rename "PowerSaving" to "OptimalForPowerSaving" Rename "EvenDistribution" to "OptimalForEvenDistribution" Change-Id: I5f8b2fc699eb70c39ded790ed9c13ce6b456046c Bug-Url: https://bugzilla.redhat.com/999539 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A packaging/dbscripts/upgrade/03_03_0950_change_policy_names.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f8b2fc699eb70c39ded790ed9c13ce6b456046c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPE in decreasePendingVms
by ofrenkel＠redhat.com 03 Oct '13

03 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE in decreasePendingVms ...................................................................... core: fix NPE in decreasePendingVms There was a race between the VdsUpdateRunTimeInfo thread that invokes RunVmCommandBase#decreasePendingVms method through OnPowerringUp callback and the thread that invokes MigrateVmCommand#rerun (the thread is created in VdsEventListener#rerun). The 'rerun thread' was doing 'setVm(null)' in order to refresh the VM on the next getVm invocation and the VdsUpdateRunTimeInfo thread was trying to the get the VM using the 'getVm' method VM in the same time - as a result of this race, the VdsUpdateRunTimeInfo thread might end up with null VM which results in NPE. The solution is to change the VdsUpdateRunTimeInfo thread to fetch the VM directly from the DB instead of using the 'getVm' method, And since we don't need the dynamic info of the VM we can query only the static part of the VM. Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Bug-Url: https://bugzilla.redhat.com/1000824 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaca2a3849a9fefbc33b055c6f4d2dd32959ad28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: doc: add versioning readme
by gpadgett＠redhat.com 03 Oct '13

03 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: doc: add versioning readme ...................................................................... doc: add versioning readme Change-Id: I95ae0908a2849edf4e51e61c1474058be293e798 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A doc/README.versioning 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ae0908a2849edf4e51e61c1474058be293e798 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: fix sudoers packaging
by gpadgett＠redhat.com 03 Oct '13

03 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: packaging: fix sudoers packaging ...................................................................... packaging: fix sudoers packaging Previously sudoers file was distributed instead of sudoers.in. But sudoers is a config file generated by configure and use paths from the host which has built the tarball that may differ from the ones where the package is installed. Now sudoers.in is correctly packaged and sudoers correctly generated during rpm creation or installation on host. Change-Id: Ia5b7e548439d4444216942e0ee0ba567302770dc Bug-Url: https://bugzilla.redhat.com/1013563 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M sudoers/Makefile.am 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b7e548439d4444216942e0ee0ba567302770dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove memory volumes without tasks on import vm failure
by ofrenkel＠redhat.com 03 Oct '13

03 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove memory volumes without tasks on import vm failure ...................................................................... core: remove memory volumes without tasks on import vm failure On failure to import vm with snapshots that contain memory state, we remove the imported memory volumes. This patch fix a bug which is relevant for the memory volumes removal in this scenario, that was caused by not adding the tasks properly (not override the getTaskType method in CommandBase). The solution is to remove those imported memory volumes without tasks, in a similar way to the solution done for I3830992f46b2c3fbea47e69f21a6711718408e95. Change-Id: I596ea3164c70b6c2a4e2c161737421259457a179 Bug-Url: https://bugzilla.redhat.com/1015080 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/19769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I596ea3164c70b6c2a4e2c161737421259457a179 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0