- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: osinfo - change OSs audio device
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: osinfo - change OSs audio device ...................................................................... core: osinfo - change OSs audio device Esentially old OSs[1] supports ac97 emulated sound device while all the new supports ich6 - intell HD audio definition. [1] RHEL 3,4,5, Windows XP, Windows 2003 32/64 Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Bug-Url: https://bugzilla.redhat.com/1002695 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: tools: fix notifier's support of smtp over ssl
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: tools: fix notifier's support of smtp over ssl ...................................................................... tools: fix notifier's support of smtp over ssl Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008975 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Only display gateway if feature supported
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Only display gateway if feature supported ...................................................................... webadmin: Only display gateway if feature supported Set the visibility of the gateway field, when editing a non-management host network, according to whether the multiple gateway feature is supported, so it wouldn't show in older clusters. Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Bug-Url: https://bugzilla.redhat.com/1008999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 4 files changed, 7 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Override getEntity() in HostSetupNetworksModel
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Override getEntity() in HostSetupNetworksModel ...................................................................... webadmin: Override getEntity() in HostSetupNetworksModel It always returns VDS, so no reason to cast every time it's called. Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Bug-Url: https://bugzilla.redhat.com/1008999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e879938d5d3b80d680aa759cc172f957ba77571 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: delete connections on block domain removal
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: delete connections on block domain removal ...................................................................... core: delete connections on block domain removal When removing a block storage domain, the relevant connections must be removed from the DB before removing the corresponding luns (as we can't retrieve connections by VG without the luns). Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Bug-Url: https://bugzilla.redhat.com/1011569 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: Select an empty profile does not work
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Select an empty profile does not work ...................................................................... frontend: Select an empty profile does not work There were the following issuse: - the empty profile is represented by null but the ListModelTypeAheadListBox did not supported it. Fixed by adding the null as a supported value - the null has been rendered by NullSafeSuggestBoxRenderer as an empty String but it was nearly invisable in the editor. Fixed by adding a specific template for this case into the CommonApplicationTemplates - the network name was not set (only the profile id). While the network name is depricated, it is still used by VmInterfaceManager.updateNicForBackwardCompatibility and expected to be set Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003609 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999283 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 7 files changed, 30 insertions(+), 16 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: prevent disabling VirtIO-SCSI on edit VM
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: prevent disabling VirtIO-SCSI on edit VM ...................................................................... core: prevent disabling VirtIO-SCSI on edit VM When a disk with VirtIO-SCSI interface is plugged to a VM, disabling VirtIO-SCSI should be prevented. Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Bug-Url: https://bugzilla.redhat.com/1014491 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 44 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: verify VirtIO-SCSI enabled on DiskValidator
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: verify VirtIO-SCSI enabled on DiskValidator ...................................................................... core: verify VirtIO-SCSI enabled on DiskValidator * DiskValidator -> isVirtIoScsiValid: VirtIO-SCSI interface is valid only when VirtIO-SCSI is enabled for the VM (i.e. a controller is attached to the VM). * Altered relevant commands/tests accordingly. Change-Id: Iff20860a8462df49afbc21a66faf2614904a7a72 Bug-Url: https://bugzilla.redhat.com/1014491 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 73 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff20860a8462df49afbc21a66faf2614904a7a72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: help icon overflow
by ecohen＠redhat.com 03 Oct '13

03 Oct '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: help icon overflow ...................................................................... webadmin: help icon overflow - Fixed issue where if a popup header was too long it would cause the help icon to overflow to the next line and look out of place. Re-arranged the header layout a little bit so the title text is in its own div that is moved on top of the title background to allow for flowing onto any background. Signed-off-by: Alexander Wels <awels(a)redhat.com> Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M packaging/branding/ovirt.brand/common.css 3 files changed, 32 insertions(+), 42 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move getFQN to SetVmTicketCommand
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Move getFQN to SetVmTicketCommand ...................................................................... core: Move getFQN to SetVmTicketCommand The method VdcUser.getFQN() is only used in the SetVmTicketCommand. This patch moves the method to SetVmTicketCommand to simplify the VdcUser class. Change-Id: If4a3a45136db9c42ab347f9722326f597afd26fd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetVmTicketCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/users/VdcUserTest.java 4 files changed, 68 insertions(+), 33 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4a3a45136db9c42ab347f9722326f597afd26fd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0