- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Unified VNIC update logic on VM creation
by lvernia＠redhat.com 03 Oct '13

03 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Unified VNIC update logic on VM creation ...................................................................... webadmin: Unified VNIC update logic on VM creation Towards adding the ability to add and remove VNICs in the add/edit VM dialogs, the VNIC logic is unified so it is the same for all kinds of VM creation flows (e.g. from scratch, from template...); VNICs may always be added, edited or removed. Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallbacks.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 129 insertions(+), 241 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbd61031572a3462af46f24c64fb5bb80343f086 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Replaced null profile with empty profile
by lvernia＠redhat.com 03 Oct '13

03 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Replaced null profile with empty profile ...................................................................... webadmin: Replaced null profile with empty profile Added a special value to represent an empty profile, and changed empty profile instances to that instead of null. This is needed by a soon-to-be-implemented Add/Remove VNIC widget in the Add/Edit VM dialog, in order to discriminate between the case where a profile hasn't yet been assigned (null) and the case where the empty profile has been assigned (VnicProfileView.EMPTY). Change-Id: I06962e43084ff4fd469e0025527cdd85a47f5ea7 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfileView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 7 files changed, 31 insertions(+), 18 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06962e43084ff4fd469e0025527cdd85a47f5ea7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: detect java home at runtime
by oschreib＠redhat.com 03 Oct '13

03 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: detect java home at runtime ...................................................................... packaging: detect java home at runtime CURRENT IMPLEMENTATION detect java home during installation. advantage is optimize application execution post-setup. disadvantage is that java home may be altered by system updates. NEW IMPLEMENTATION detect java home during runtime using pre-defined algorithm. algorithm: execute /usr/share/ovirt-engine/bin/java-home. if java-home.local is available, execute that script. this enables distro specific customization. if OVIRT_ENGINE_JAVA_HOME environment is set, validate java validity and use/abort. search predefined selected alternatives location by order, first wins. search /usr/lib/jvm for compatible jvm. NOTES the java-home script resides with the lib package as it cannot reside within any version locked package since it is used by setup, and it cannot reside within setup since it used by post setup. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009863 Change-Id: I833362d0498d534b06e0d7660f1e8a61e9b1713b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine.spec.in M packaging/bin/engine-prolog.sh.in A packaging/bin/java-home A packaging/pythonlib/ovirt_engine/config.py.in A packaging/pythonlib/ovirt_engine/java.py M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/java.py 13 files changed, 172 insertions(+), 231 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I833362d0498d534b06e0d7660f1e8a61e9b1713b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: always pull recent pythonlib
by oschreib＠redhat.com 03 Oct '13

03 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: always pull recent pythonlib ...................................................................... packaging: spec: always pull recent pythonlib Change-Id: I113dd0a5bb477b02d857dcca820fd2a2a8b54762 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113dd0a5bb477b02d857dcca820fd2a2a8b54762 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: prepend pythonlib
by oschreib＠redhat.com 03 Oct '13

03 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: services: prepend pythonlib ...................................................................... packaging: services: prepend pythonlib devenv should shadow default search path, so system library will not shadow devenv. Change-Id: I5383c6529e822d92593d2e915a76bc3b25855866 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine-notifier/config.py.in M packaging/services/ovirt-engine/config.py.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5383c6529e822d92593d2e915a76bc3b25855866 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added vertical scrolling to BaseListModelSuggestBox
by lvernia＠redhat.com 03 Oct '13

03 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added vertical scrolling to BaseListModelSuggestBox ...................................................................... webadmin: Added vertical scrolling to BaseListModelSuggestBox All suggest boxes in the system could probably use a height limitation for their suggestion list, with a vertical scrollbar when the content is too big. Also took the chance to move the logic fitting the height of the suggestion list to that of the content from ListModelTypeAheadListBox to BaseListModelSuggestBox, as ListModelSuggestBox could also use it. Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666 Bug-Url: https://bugzilla.redhat.com/1008523 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.ui.xml 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c662e3e8d1062e654f10ce275019c28b62f2666 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: disk interfaces - filter VirtIO-SCSI
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: disk interfaces - filter VirtIO-SCSI ...................................................................... webadmin: disk interfaces - filter VirtIO-SCSI New/Edit disk dialog: filter out VirtIO-SCSI from disk interface list when VirtIO-SCSI is disabled for the VM. Change-Id: I07a1b9af5d8c7a0e4dc6f8cc40410b629d201fc4 Bug-Url: https://bugzilla.redhat.com/1014491 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 3 files changed, 24 insertions(+), 7 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a1b9af5d8c7a0e4dc6f8cc40410b629d201fc4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core, ui: VirtIO-SCSI enabled flag
by iheim＠redhat.com 03 Oct '13

03 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core,ui: VirtIO-SCSI enabled flag ...................................................................... core,ui: VirtIO-SCSI enabled flag core: * VmManagementParametersBase -> virtioScsiEnabled Boolean. ** Using a nullable boolean for setting a default value when not specified (null value). * When enabled, a VirtIO-SCSI controller device is added to vm_device table. ** Used for maintaining stable address to the pci controller. ** Necessary for hot-plugging a disk with VirtIO-SCSI interface. * The flag is defaulted to true on cluster >= 3.3. UI: * Added 'VirtIO-SCSI Enabled' check-box in VM dialog (under 'Resource Allocation' tab -> 'Storage Allocation') * Screenshot: http://imgur.com/zP7lxsv Feature page: http://www.ovirt.org/Features/Virtio-SCSI Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58 Bug-Url: https://bugzilla.redhat.com/1014491 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVirtioScsiControllersQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmPoolWithVmsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java 46 files changed, 374 insertions(+), 38 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disable external networks in Setup Networks
by masayag＠redhat.com 03 Oct '13

03 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Disable external networks in Setup Networks ...................................................................... webadmin: Disable external networks in Setup Networks Changed the appearance of external networks in Setup Host Networks to look disabled and not be draggable, as they truly shouldn't be statically assigned to the host's interfaces. Did this by extending the hierarchy of related classes. InternalNetworkPanel should behave like a native network, while ExternalNetworkPanel is a disabled variation of it. Common code is housed in the common ancestor NetworkPanel. Also refactored some code around UnassignedNetworksPanel for reuse. Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8 Bug-Url: https://bugzilla.redhat.com/990612 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworkPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworksPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworkPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 12 files changed, 236 insertions(+), 88 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use ExternalId in DbUser
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Use ExternalId in DbUser ...................................................................... core: Use ExternalId in DbUser This patch changes the DbUser entity and the corresponding DAO to use the ExternalId class for management of the directory identifier of the user. Change-Id: I60ee292f95993c28666bd63bcd153e2416744027 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java 4 files changed, 22 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60ee292f95993c28666bd63bcd153e2416744027 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0