- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Introduce ExternalId
by yzaslavs＠redhat.com 03 Oct '13

03 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Introduce ExternalId ...................................................................... core: Introduce ExternalId This patch introduces a new ExternalId class intended to manage identifiers generated by external systems and attached to internal entities. This external identifiers are basically opaque objects stored as arrays of bytes in the engine. The patch also introduces a custom GWT serializer for this class because GWT RPC doesn't correctly handle arrays of bytes. Change-Id: Ib93020ddc6fe6249f0bf6dd4b24db4d2d0e0b045 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ExternalId.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSource.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml A frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/utils/ExternalId_CustomFieldSerializer.java 4 files changed, 133 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib93020ddc6fe6249f0bf6dd4b24db4d2d0e0b045 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Map status In Progress to Job status Started
by kmayilsa＠redhat.com 03 Oct '13

03 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Map status In Progress to Job status Started ...................................................................... gluster: Map status In Progress to Job status Started Gluster tasks return a status "In progress" for tasks that are currently running. This needs to be mapped to JobExecutionStatus.STARTED for monitoring to work correctly Change-Id: I55c657cb8142b4248f20f1789317726acbdb0852 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c657cb8142b4248f20f1789317726acbdb0852 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleanup CommonModel
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: cleanup CommonModel ...................................................................... webadmin: cleanup CommonModel No logic changes. Just reordered the CommonModel class according to conventions. Change-Id: I382f6d5b5615b91f697198d6e3e4d5d312fcedbc Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 342 insertions(+), 366 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I382f6d5b5615b91f697198d6e3e4d5d312fcedbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Locale dropdown not working
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Locale dropdown not working ...................................................................... engine: Locale dropdown not working - Fixed issue where if you caused a scrollbar to appear in the browser, then locale selection dropdown would stop working. The css placed the element fixed to then browser window instead of relative to the containing element - Fixed the same issue for webadmin and user portal login screens. Change-Id: Id25bb36914c8c2ecdde62fbb04b7b0374be3d88d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009986 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml M packaging/branding/ovirt.brand/welcome_style.css 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25bb36914c8c2ecdde62fbb04b7b0374be3d88d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: update search string on bookmark selection
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: update search string on bookmark selection ...................................................................... webadmin: update search string on bookmark selection After editing a bookmark name, that bookmark wasn't being properly cleared of its selection. The UI component was no longer selected, but the model thought it was still selected. So re-clicking that bookmark had no effect. Fixed by properly clearing the bookmark selection on bookmark save. Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d Bug-Url: https://bugzilla.redhat.com/996611 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: remove last traces of legacy devenv
by yzaslavs＠redhat.com 02 Oct '13

02 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: build: remove last traces of legacy devenv ...................................................................... build: remove last traces of legacy devenv Change-Id: I5af49cd3111bf08d7e42c1eefa13342f525502bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D backend/manager/conf/login-config.xml D backend/manager/conf/postgres-ds.xml D backend/manager/conf/standalone.xml D backend/manager/conf/transaction-jboss-beans.xml M ear/pom.xml M pom.xml 6 files changed, 0 insertions(+), 808 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af49cd3111bf08d7e42c1eefa13342f525502bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: revert when failing to export a template
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: revert when failing to export a template ...................................................................... core: revert when failing to export a template When failing to export a template, the engine can attempt to delete the already exported images. Change-Id: I8d80c5d15f7321f67d54e7593cb2da1fd7186a25 Bug-Url: https://bugzilla.redhat.com/967628 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java 5 files changed, 54 insertions(+), 12 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d80c5d15f7321f67d54e7593cb2da1fd7186a25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: InitVdsOnUp - proceed regardless of problematic iso/ex...
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: InitVdsOnUp - proceed regardless of problematic iso/export domain ...................................................................... core: InitVdsOnUp - proceed regardless of problematic iso/export domain Prior to this patch, when host reported iso/export domain as problematic during the InitVdsOnUp flow it didn't move to status UP. As currently when ISO/Export domains are reported as problematic by some of the hosts those hosts remain UP and doesn't move to NonOperational, the behaviour between those two flows should be unified - therefore it was decided that when hosts reports iso/export domain as in problem it won't stop it from moving to UP. Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3 Bug-Url: https://bugzilla.redhat.com/967604 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 2 files changed, 22 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix tabs shown/hidden when tags selected/unselected
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: fix tabs shown/hidden when tags selected/unselected ...................................................................... webadmin: fix tabs shown/hidden when tags selected/unselected Fixed tab show logic so that when a tag is selected, only Hosts, VMs, and Users tabs are visible. When no tag is selected, tabs behave as if System node is selected. Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f Bug-Url: https://bugzilla.redhat.com/1006282 Bug-Url: https://bugzilla.redhat.com/996594 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 19 insertions(+), 14 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Allowed non-draggable NetworkItemPanel
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Allowed non-draggable NetworkItemPanel ...................................................................... webadmin: Allowed non-draggable NetworkItemPanel It seems that so far setting draggable to false did nothing, the item would still be draggable; for some reason calling setDraggable(Element.DRAGGABLE_FALSE) adds the draggable property to an element and sets it to true! Added some code to disable the "draggable skin" and the actual drag operation when an item has been constructed as non-draggable. Also, changed bonds to be draggable explicitly, as they have been draggable all this time and I've heard no complaints. Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 2 files changed, 20 insertions(+), 17 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0