- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Changed Boolean argument to boolean
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Changed Boolean argument to boolean ...................................................................... webadmin: Changed Boolean argument to boolean There was no reason to ever pass null rather than true or false, and no code called these constructors with a null value. Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Locale dropdown not working
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: engine: Locale dropdown not working ...................................................................... engine: Locale dropdown not working - Fixed issue where if you caused a scrollbar to appear in the browser, then locale selection dropdown would stop working. - Fixed the same issue for webadmin and user portal login screens. Change-Id: Id25bb36914c8c2ecdde62fbb04b7b0374be3d88d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009986 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml M packaging/branding/ovirt.brand/welcome_style.css 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id25bb36914c8c2ecdde62fbb04b7b0374be3d88d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix cluster creating in guide
by gchaplik＠redhat.com 02 Oct '13

02 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix cluster creating in guide ...................................................................... webadmin: fix cluster creating in guide When creating a cluster in the datacenter guide, policy units configuretion was not saved. added missing policy unit mapping from ClusterModel to VDSGroup Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Bug-Url: https://bugzilla.redhat.com/1001182 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: log: add indirect filtering
by Alon Bar-Lev 02 Oct '13

02 Oct '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: log: add indirect filtering ...................................................................... core: log: add indirect filtering Change-Id: Id96a70f5450f9416583b7803dfe7a10aa6c98472 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/constants.py M src/plugins/otopi/core/log.py 3 files changed, 18 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id96a70f5450f9416583b7803dfe7a10aa6c98472 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: fix notifier's support of smtp over ssl
by masayag＠redhat.com 02 Oct '13

02 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: tools: fix notifier's support of smtp over ssl ...................................................................... tools: fix notifier's support of smtp over ssl Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1008975 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifecec2d5972610e6d8fbb4435c1c29c4ad6b32cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: delete connections on block domain removal
by derez＠redhat.com 02 Oct '13

02 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: core: delete connections on block domain removal ...................................................................... core: delete connections on block domain removal When removing a block storage domain, the relevant connections must be removed from the DB before removing the corresponding luns (as we can't retrieve connections by VG without the luns). Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Bug-Url: https://bugzilla.redhat.com/1011569 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1be645779e5ad28e9c2672246e6e68d5aecb00e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Dynamic guide link
by vszocs＠redhat.com 02 Oct '13

02 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Dynamic guide link ...................................................................... userportal: Dynamic guide link - Dynamically switch guide link between basic guide and power user guide based on active tab - Fixed issue where the place managers where not singleton accross modules. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=948653 Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationDynamicMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/MainSectionPresenter.java M packaging/branding/ovirt.brand/external_resources.properties 6 files changed, 55 insertions(+), 7 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6374df0da70fa6f6edf044d4ebadafc7fb1a105 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: host id must not be saved in answer file
by sbonazzo＠redhat.com 02 Oct '13

02 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: host id must not be saved in answer file ...................................................................... packaging: setup: host id must not be saved in answer file saving the host id in the answer file leads to having the same host id of the first host also on additional hosts. With this patch the host id is not saved anymore in the answer file. Bug-Url: https://bugzilla.redhat.com/1014004 Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Select an empty profile does not work
by tjelinek＠redhat.com 02 Oct '13

02 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Select an empty profile does not work ...................................................................... frontend: Select an empty profile does not work There were the following issuse: - the empty profile is represented by null but the ListModelTypeAheadListBox did not supported it. Fixed by adding the null as a supported value - the null has been rendered by NullSafeSuggestBoxRenderer as an empty String but it was nearly invisable in the editor. Fixed by adding a specific template for this case into the CommonApplicationTemplates - the network name was not set (only the profile id). While the network name is depricated, it is still used by VmInterfaceManager.updateNicForBackwardCompatibility and expected to be set Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003609 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 7 files changed, 30 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199d4ce14b55b3f552cf6138b7c3c5d21d620ccc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: host id must not be saved in answer file
by sbonazzo＠redhat.com 02 Oct '13

02 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: host id must not be saved in answer file ...................................................................... packaging: setup: host id must not be saved in answer file saving the host id in the answer file leads to having the same host id of the first host also on additional hosts. With this patch the host id is not saved anymore in the answer file. Bug-Url: https://bugzilla.redhat.com/1014004 Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia742cfe1fd2c3c3c140edb0fa290bdff7b9f4e38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0